Rooba
/
lightning
mirror of https://github.com/Lightning-AI/lightning.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
6,729 Commits 59 Branches 217 Tags 356 MiB
Commit Graph

221 Commits

Author SHA1 Message Date
Carlos Mocholí 4184d7e738
Refactor GPU examples tests (#8294) 2021-07-06 13:14:04 +01:00
Kaushik B f60aae9815
Update `dataloaders` params in example (#8191) 2021-06-29 14:23:48 +02:00
thomas chaton c521624a92
[bugfix] Add mechanism to prevent deadlock for DDP on Exception Trigger (#8167) 
* add mechanism to prevent deadlock

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* resolve flake8 + update changelog

* update on comments

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update

* remove space

* resolve bugs

* overwrite config

* update on comments

* update on comments

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update

* update

* update test with comments

* Update pytorch_lightning/plugins/training_type/parallel.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* update on comments

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2021-06-28 19:26:03 +00:00
deepsource-autofix[bot] 03154eb30a
Refactor unnecessary `else` / `elif` when `if` block has a `return` statement (#8156) 
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
 2021-06-28 15:27:41 +05:30
Carlos Mocholí 4d9b72b8a9
Nuke RPC (#8101) 2021-06-23 18:31:13 +00:00
thomas chaton 917cf83638
[doc] Add more reference around predict_step (#7997) 
* add predict examples

* update on comments
 2021-06-16 12:23:27 +01:00
Kaushik B 92024df20e
Pt 1.9 breaking fix: __iter__ type hint (#7993) 2021-06-15 21:57:15 +00:00
Sean Naren 96433d03ea
IPU Integration 5/5 (#7867) 
* Initial changes

* Add broken example for now

* Fix reference

* Fix format

* Code runs

* Fixes

* Clear up files

* Add tests, helpers, fixes

* Small cleanups

* Refactors based on review

* Swap to special tests

* Add special tests

* Add source

* Cleanups

* Add logic to attach/detach model from devices

* Fixes for tests

* Fixes for tests

* Move earlier

* Cleanups

* Add check for nvcc

* Add tests, cleanups

* Fix errors

* fix

* Try condition

* Add missing annotation

* Clearer

* Clearer message

* Fix variable

* Cleanups

* Add comment

* CHANGELOG.md

* Add simple selection test

* Remove special=True to see what happens

* Fix test

* Update tests/accelerators/test_ipu.py

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>

* Convert ipu_cores -> ipus

* Add typing, fail earlier

* simplify precision

* Add test, add helper

* fix accum

* Update pytorch_lightning/plugins/training_type/ipu.py

Co-authored-by: thomas chaton <thomas@grid.ai>

* Use stages

* Make sure warning message returned

* thorw error

* Add more tests, use fs

* add comment

* Clean

* Address feedback, add IPU tests

* Fixes

* Fix signature

* Add types

* Remove autoround

* Add docstring

* ipu_cores -> ipus

* Add test, remove unnecessary precision set

* Add optimizer test

* Add precision back with test

* Address code review

* Change to probs

* Move some of the asserts earlier

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
 2021-06-11 15:07:04 +00:00
Carlos Mocholí e16d4fbdee
CI code cleaning (#7615) 2021-05-21 11:35:12 +00:00
Carlos Mocholí a584196abf
Default `seed_everything(workers=True)` in the `LightningCLI` (#7504) 2021-05-13 12:18:03 +02:00
Jirka Borovec b181b8c646
release 1.3.0 (#7404) 
* v1.3.0

* ci event

* chlog

* badge

* formatting
 2021-05-06 15:05:35 -04:00
Florian Müller-Fouarge d4d959b342
Call `super().__init__()` in `MilestonesFinetuning` example (#7398) 2021-05-06 21:11:36 +05:30
Mauricio Villegas 78a6fd5588
Example and documentation for LightningCLI linking model and data arguments (#7299) 
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
 2021-05-03 20:45:46 +00:00
Mauricio Villegas b0cd9daf25
Simplify backbone_image_classifier example (#7246) 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
 2021-04-28 23:52:28 +00:00
amisev 6b29211372
Fixed bug: replaced bce_loss_with_logits with bce_loss (#7096) 
* Fixed bug: replaced bce_loss_with_logits with bec_loss

* Fixed bug: removed sigmoid activation from forward pass

* switched names for scores and logits

Co-authored-by: Alexey Misev <amisev@fb.com>
Co-authored-by: Alexey Misev <alexey@MacBook-Pro-Natalia.local>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
 2021-04-28 09:06:10 +00:00
Adrian Wälchli 591b9cee70
make bug_report_model minimal (#7191) 
* simple and boring script

* simplify dataloader

* replace bug report model
 2021-04-25 08:01:25 +02:00
Jirka Borovec ef5feac7ba
fix version + yapf (#6999) 2021-04-22 18:25:51 +00:00
Soham Roy 71b4611c64
Update default gym env version to CartPole-v1 (#7079) 
Version v1 generates a better baseline with higher max_episodes and reward_threshold attained.

changed_params -->

register(
    id='CartPole-v1',
    entry_point='gym.envs.classic_control:CartPoleEnv',
    max_episode_steps=500,
    reward_threshold=475.0,
)
 2021-04-18 12:28:04 +02:00
Mauricio Villegas f852a4f592
Changed basic_examples to use `LightningCLI` (#6862) 
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
 2021-04-15 15:01:16 +00:00
Jirka Borovec f2021ed225
docs: lightning-bolts (#6967) 2021-04-13 18:49:48 +00:00
Carlos Mocholí 6a7f011495
Reuse _TORCHVISION_AVAILABLE (#6976) 2021-04-13 18:33:32 +02:00
Ethan Harris 87f0aeac25
Fix DDP_SPAWN compatibility with bug_report_model.py (#6892) 2021-04-08 19:57:18 +05:30
Akihiro Nitta 9876df16a2
[docs] Update Bolts link (#6743) 
* Update Bolts link

* Update Bolts link

* formt

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2021-03-30 22:52:59 +05:30
Jirka Borovec dcf6e4e310
remake nvidia docker (#6686) 
* use latest

* remake

* examples
 2021-03-29 09:39:06 +01:00
Ben Ahlbrand cbca6cd354
fix: update example autoencoder.py to reflect args (#6638) 
* fix: update example autoencoder.py to reflect args

* Update pl_examples/basic_examples/autoencoder.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
 2021-03-24 08:27:08 +00:00
thomas chaton fd5cb7fcc3
Add PyTorch 1.8 Profiler 5/5 (#6618) 
* Refactor profilers

* Update PassThrough

* WIP - This is broken and will change

* Update pytorch_lightning/profiler/pytorch.py

Co-authored-by: thomas chaton <thomas@grid.ai>

* resolve tests

* resolve tests

* find output

* try something

* update

* add support for test and predict

* update

* update

* use getattr

* test

* test

* update

* tests

* update

* update

* update

* update

* update

* remove file

* update

* update

* update

* update

* update

* test

* update#

* update

* update tests

* update

* add suport for 1.8

* rename records

* add support for 1.8

* update

* resolve flake8

* resolve test

* Refactor basic profilers

* Fixes

* Unused import

* Introduce setup

* Profile on all ranks. Print to stdout on 0

* Introduce dirpath + filename

* CHANGELOG

* Add tests. Address comments

* add `on_run_stage_setup`

* add on_run_stage_setup function

* update

* add test for RegisterRecordFunction

* update lightnng flow direction

* move variable to private

* remove trace

* Undo code that should be in 3/4

* Multi-stage multi-rank

* 2/5 changes

* Pass stage in __del__

* Remove TODOs

* Describe on_evaluation_end. Add tests

* Typo

* Address comments

* deepcopy tests

* Advanced teardown

* Fix teardown test

* Fix tests

* Minor change

* Update CHANGELOG.md

* Fix test

* Quick fixes

* Fix 6522

* resolve ddp tests

* resolve tests

* resolve some tests

* update tests

* resolve tests

* update

* resolve tests

* resolve some tests

* Missed fixes from 3/5

* Fixes

* resolve some tests

* resolve test for 1.7.1

* Broken refactor

* Missed stage

* Minor changes

* resolve tests

* Update CHANGELOG

* resolve bug

* remove print

* Typo

* Cleanup

* resolve ddp test

* remove barrier

* update profiler

* update

* Smaller model

* update

* resolve tests

* update

* Minor changes. CHANGELOG

* Minimize diff

* update to 1.8.1

* RunIf. Extra code. Check segfault

* resolve tests

* Typo. Bad merge

* Fixing a bad merge

* replace for kineto

* Update pytorch_lightning/profiler/pytorch.py

Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>

* Update pytorch_lightning/profiler/pytorch.py

Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>

* Minor changes

* Bad merge

* Use lists for flexibility

* Use sets

* predict_step

* Ananth's suggestion

* update

* Docs

* Update pl_examples/basic_examples/profiler_example.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* update example

* update example

Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2021-03-23 20:43:21 +00:00
Jirka Borovec e62c7c7839
hotfix: mock examples (#6632) 
* mock examples

* drop from GA
 2021-03-22 16:49:01 +00:00
Jirka Borovec cb59039288
fixing examples (#6600) 
* try Azure

* -e

* path
 2021-03-20 18:58:59 +00:00
Jirka Borovec 6453091b8a
Prune metrics base classes 2/n (#6530) 
* base class

* extensions

* chlog

* _stable_1d_sort

* _check_same_shape

* _input_format_classification_one_hot

* utils

* to_onehot

* select_topk

* to_categorical

* get_num_classes

* reduce

* class_reduce

* tests
 2021-03-15 19:28:18 +00:00
Jirka Borovec b341b53f70
deprecate metrics pkg (#6505) 
* deprecate metrics

* examples

* req

* docs

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>

* pep8

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
 2021-03-15 14:39:38 +00:00
Adrian Wälchli 62d4304ca4
remove obsolete todo in pl_examples (#6475) 2021-03-11 18:49:30 +01:00
Eric Cousineau e886d55ac1
argparse: Add use_argument_group=True (#6088) 
* argparse: Add inplace option

Replicate in GAN model

* datamodule: Deduplicate logic w/ argparser utilities

* Update pl_examples/domain_templates/generative_adversarial_net.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>

* Keep docstrings

* Correct name

* Whitespace

* Consistency

* fix weird type stuff

* try alt - use_argument_group

* fix syntax + lint

* fix ci errs

* fix ci

* change examples... still failing w/ "unrecognized arguments: --batch_size"

* address review

* mnist_datamodule: add some docstrings

* argparse: check cls or cls.__init__ for param

didn't capture issue, but meh

* fix lint

* fix no-doc edge case

* address review

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
 2021-03-11 10:50:49 -05:00
Kaushik B 079fe9bc09
Hotfix for torchvision (#6476) 2021-03-11 16:49:48 +05:30
Akihiro Nitta 34b733b35e
Fix manual optimization in pl_example (#6373) 
* Fix automatic_optimization

* Fix automatic_optimization

* Uncomment fairscale
 2021-03-06 18:28:37 +01:00
Jirka Borovec e84854264f
CI: fix examples - patch download MNIST (#6357) 
* patch download

* CI

* isort

* extra
 2021-03-05 16:50:21 +00:00
Adrian Wälchli bc577ca792
fix duplicate console logging bug v2 (#6275) 
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2021-03-02 15:17:55 +05:30
Akihiro Nitta 5cf892b5f6
Fix typo (#6178) 2021-02-24 10:14:25 -05:00
Adrian Wälchli 6cc1a06078
rename accelerator_backend -> accelerator (#6034) 
* rename accelerator backend

* rename new additions from master

* add proper deprecation

* pep8

* warning match

* add missing warning type
 2021-02-18 15:54:12 +00:00
chaton 141316fb29
[BugFix] Resolve bugs in computer_vision_fine_tuning.py example (#5985) 
* update the script to use DataModule

* add message at for the frozen parameters

* add message about trainable parameters

* resolve flake8
 2021-02-16 21:01:04 +00:00
Dusan Drevicky c5919fde63
Basic examples fixes (#5912) 
* Move pl_bolts assert to actually do something

* Define val, test steps, use _DATASETS_PATH

* Use DATASETS_PATH in DALI classifier

* Fix incorrect paths and style in example READMEs

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
 2021-02-16 19:31:07 +00:00
Jirka Borovec 1c87f1f6cd
remove legacy plugins (#5950) 
* remove legacy plugins

* imports

* formatting

* fix docs references

* fix cluster environment inheritance

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
 2021-02-16 19:20:58 +00:00
Jirka Borovec ba806c8ee0
enable testing DDP examples (#4995) 
* enable testing DDP examples

* args

* ddp_spawn

* ddp as extra script

* path

# Conflicts:
#	.drone.yml

* install

* -u

* q
 2021-02-15 15:36:13 +00:00
Jirka Borovec bd920b4102
Refactor simplify tests (#5861) 
* add new

* restructure

* yapf

* move

* fix
 2021-02-08 11:52:02 +01:00
Jihoon Lee d1200af358 fix model arguements (#5653) 2021-02-05 21:40:40 +01:00
chaton e425bf3ba9
[BugOnFeat] Resolve bug with Finetuning (#5744) 
* resolve bug + add doc

* Update pytorch_lightning/callbacks/finetuning.py

* resolve bug

* start adding more test

* add more tests for finetuning callback functions

* rename to flatten_modules

* resolve doc

* Update pytorch_lightning/callbacks/finetuning.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* resolve comments

* remove update on BoringModel

* update on comments

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2021-02-04 18:36:54 +00:00
rohitgr7 a37416843b Fix sync 
resolve wrong merge

tpu

yapf
 2021-02-03 20:11:35 +01:00
Sidhant Sundrani 2b6738832b fix argparse conflicting options error (#5569) 
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2021-02-03 19:41:46 +01:00
Sidhant Sundrani f72d93974c Fix command line run for refinforce_learn_qnet in pl_examples (#5414) 
* fix wrong argument in argparse

* remove wrong default arg in argparser

* disable add help argparse
 2021-02-03 19:41:46 +01:00
Jirka Borovec 21d313edc5
yapf examples (#5709) 2021-01-30 10:17:12 +00:00
Jirka Borovec 7e2e874d95
Refactor: legacy accelerators and plugins (#5645) 
* tests: legacy

* legacy: accel

* legacy: plug

* fix imports

* mypy

* flake8
 2021-01-26 20:04:36 -05:00
Arnaud Gelas fb6c33a52d Fix pre-commit trailing-whitespace and end-of-file-fixer hooks. (#5387) 
(cherry picked from commit 4c6f36e6e1)
 2021-01-26 14:27:56 +01:00
Jirka Borovec 2846322f60
fix docs render (#5610) 2021-01-25 20:21:00 -05:00
Sidhant Sundrani b5e7e030d4
add promxial policy optimization template to pl_examples (#5394) 
* add ppo rl lightning template

* flake

* import gym without try as in qnet example

* fix import format

* remove torch.optim import, not required

* fix import format isort

* add trainer argparse

* change name of trajectory collection method

* add repo in references

* fix typo in comments

* use isinstance to verify actionspace type

* use fstring

* deduplication of logic code

* rename unused forloop variable

* use pl.seed_everything instead

* remove unused numpy import

* format string printed on error

* fix typo in comments

Co-authored-by: chaton <thomas@grid.ai>
 2021-01-09 12:49:11 -05:00
chaton 48718d7ce7
Feat: Add BackboneLambdaFinetunningCallback (#5377) 
* Feat: Add BackboneLambdaFinetunningCallback

* update changelog

* resolve pep8 and update changelog

* add finetunning example

* resolve example

* iremove milestones from model

* iupdate

* update

* Update pytorch_lightning/callbacks/__init__.py

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>

* Update pytorch_lightning/callbacks/__init__.py

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>

* update

* add comments

* resolve test

* Update pytorch_lightning/callbacks/finetuning.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Update tests/trainer/logging/test_logger_connector.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* update on comments

* resolve merge

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
 2021-01-08 16:33:05 -05:00
Jirka Borovec 8a40e80226
fix num_workers for Windows example (#5375) 
* fix num_workers for Windows example

* chlog

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* warn

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
 2021-01-06 19:28:30 -05:00
Jirka Borovec beb8cacf1c fix formatting - flake8 + isort 2021-01-06 21:31:48 +01:00
Carlos Mocholí 3ee3c42035 Prepare 1.1.3 release (#5365) 
* Prepare 1.1.3 release

* Fix flake8 error

* suppress

* Remove 1.1.4 section

* Add missing commits to CHANGELOG

* Update PR template

* Add missing commit

* fix

* Update CHANGELOG.md

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

(cherry picked from commit 4d9db866a1)
 2021-01-06 15:17:27 +01:00
J. Sebastian Paez 0e8ec93b28 black formatting and migrated to self.log logging in finetuning example (#5229) 
* black formatting and migrated to self.log logging

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* migrated to accuracy in the metrics package

migrated to accuracy in the metrics package

* removed trailing whitespace

* Apply suggestions from code review

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
(cherry picked from commit 17a0784c5e)
 2021-01-06 12:49:31 +01:00
Jirka Borovec 53b0cb910b update isort config (#5335) 
* update isort config

* apply

(cherry picked from commit 724f1051f0)
 2021-01-06 12:49:23 +01:00
Akihiro Nitta abc690d720 Apply isort to `pl_examples/` (#5291) 
* Remove examples from isort ignore list

* Apply isort

(cherry picked from commit 0c7c9e8540)
 2021-01-06 12:47:53 +01:00
Jirka Borovec 74d0652164 flake8 ++ 2021-01-05 09:58:37 +01:00
Jirka Borovec 2438d7459b add doctests for example 2/n segmentation (#5083) 
* draft

* fix

* drop folder

Co-authored-by: chaton <thomas@grid.ai>
 2021-01-05 09:58:37 +01:00
Ganesh Anand a5b2392652 update DALIClassificationLoader to not use deprecated arguments (#4925) 
* update DALIClassificationLoader to not use deprecated arguments

* fix line length

* dali version check added and changed args accordingly

* versions

* checking version using disutils.version.LooseVersion now

* .

* ver

* import

Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2021-01-05 09:58:37 +01:00
Jirka Borovec 518d915422 add doctests for example 1/n (#5079) 
* define tests

* fix basic

* fix gans

* unet

* test

* drop

* format

* fix

* revert

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
 2021-01-05 09:58:37 +01:00
Jirka Borovec 3b83666823 prune ecosystem example (#5085) 
* draft

* wip

* CI

* drop pl geometry

* copy

* logo
 2021-01-05 09:58:37 +01:00
Jirka Borovec 0f36525e8f
fix/enable - check F401 (#5201) 
* refactor - check F401

* missed

* fix
 2020-12-21 10:15:04 +01:00
Jirka Borovec 35fd6e93c7
refactor - check E501 (#5200) 2020-12-21 14:23:09 +05:30
Jirka Borovec 059eaecbb4
set xxx_AVAILABLE as protected (#5082) 
* sett xxx_AVAILABLE as protected

* docs
 2020-12-14 20:19:05 +05:30
Jirka Borovec 77fb425dd4
update usage of deprecated profiler (#5010) 
* drop deprecated profiler

* lut

Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
 2020-12-10 08:38:14 +01:00
chaton ef8ef12fd0
[feat] pp 2/n (#5026) 
* Added changes for RPC plugin

* Add missing kwargs

* Fix code format

* Loading refactors by introducing is_distributed var, fix optimizer step flow

* Add rpc guard

* Added docstrings and typing

* resolve comments

* Add additional rpc hook, refactor name of exit process hook for clarity

* remove annotation

* Modify behaviour to allow optional return, add test for rpc plugin

* resolve tests

* rename is_ddp_based

* update

* update for windows

* update

* resolve test

* code smell

* Added sequential plugin

* resolve bug

* update

* cleanup

* add Exception

* resolve docs

* Remove ddp support

* Revert distributed -> ddp

* Update pl_examples/basic_examples/conv_sequential_example.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Update pl_examples/basic_examples/conv_sequential_example.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Address code review points

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Add missing return

* Fix formatting, add datamodule args

* add small comment

* resolve comments

* resolve comments

* update source for fairscale

* update extras

* remove staticmethod

* resolve flake8

* Skip tests that are failing due to bug upstream with multiple optimizers and shard

* update

* update on comments

* clean test

* latest comments

* remove old comments

* add todo

* Update version

* update

* resolve bugs

* resolve bugs

* update test

* remove hanging test

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* resolve on comments

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* resolve on comments

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* remove ImportError

Co-authored-by: SeanNaren <sean@grid.ai>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
 2020-12-09 12:56:51 +00:00
Jirka Borovec 53d7c9555c
drop usage of deprecated distributed_backend (#5009) 
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
 2020-12-09 09:18:23 +01:00
Jirka Borovec 22bd742214
fix examples running in DP (#4764) 
* add option to step result to do aggregation on a specific device

* in dp: do aggregation on root gpu

* Update CHANGELOG.md

* pep8

* trailing whitespace

* uncomment DP

* more cases

* tmpdir

* test

* note

* move to root


move result


stupid result object


revert to master


undo import


add "to" method to result


generalize to


try a test


try a test


Revert "try a test"

This reverts commit 22e3c1001e6c5774ea18ad925830304c245bf145.

Revert "try a test"

This reverts commit 4d2d8fb2a52d552894809a0cbe51af126d78f070.

new test


max epochs


super epoch end 


log in test


hanging test


undo test


initial test that fails on master


step end


pass


step end


step end


epoch end


print


step


check dev


clean up test


sanity check


wtf is go ing on


frustration


debugging test


test


test


test


test


test


test


test


test


unused import

* dist backend -> accelerator

* remove todo

Co-authored-by: Justus Schock <justus.schock@rwth-aachen.de>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
 2020-12-04 23:32:00 +01:00
Sean Naren ed5bda3eda
[docs] Added description of saving using ddp (#4660) 
* Added description of saving using ddp

* Added code block example to explain DDP saving logic

* Fixed underline

* Added verbose explanation

* Apply suggestions from code review

* Added caveat when using custom saving functions

* flake8

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
 2020-12-04 17:59:38 +01:00
Limber Cheng b807c3278d
Update to latest logging format and modify the accuracy method. (#4816) 
* Update to latest logging format and modify the accuracy method.

* Apply suggestions from code review

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: chaton <thomas@grid.ai>
 2020-12-04 15:30:51 +01:00
Lucien d3626b7f50
Organize docstring (#4906) 
* Organize docstring

* Update pl_examples/domain_templates/reinforce_learn_Qnet.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: chaton <thomas@grid.ai>
 2020-12-04 14:45:13 +01:00
brett koonce 4de568a545
tweak imagenet docs to match current script (#4895) 
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
 2020-11-30 09:54:55 +01:00
Lucien-cs ac3f1bd0da
Update reinforce_learn_Qnet.py (#4814) 
Correct the text.

Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
 2020-11-30 08:21:37 +01:00
Jirka Borovec 94a9d3d283
Update examples - use DataModule (#4740) 
* rename

* add mnist_datamodule.py

* dm

* fix

* imports

* clean

* imports

* transforms

* skip
 2020-11-20 23:40:40 +05:30
chaton b7601e9deb
[Example] Add Pytorch Geometric Example (#4568) 
* add example for Pytorch Geometric

* remove hydra

* add docstring

* remove description

* rename folder

* update script to not break test

* remove .lock

* add Pytorch Geometric to doc

* add docstring at the begining

* add comments

* Update pl_examples/pytorch_ecosystem/pytorch_geometric/README.md

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Update pl_examples/pytorch_ecosystem/pytorch_geometric/README.md

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Update pl_examples/pytorch_ecosystem/pytorch_geometric/cora_dna.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* add toml

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <jirka@pytorchlightning.ai>
 2020-11-18 20:03:55 +00:00
Jirka Borovec 9a5d40aff4
test PL examples (#4551) 
* test PL examples

* minor formatting

* skip failing

* skip failing

* args

* mnist datamodule

* refactor tests

* refactor tests

* skip

* skip

* drop DM

* drop DM

Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
 2020-11-17 19:35:17 +01:00
Ludger Paehler 7c4356464c
Minor typo in the description of Adam's beta 2 (#4715) 
Adam's beta 2 parameter was mistakenly referred to as the first order momentum of the gradient, whereas it should be the second order momentum. This has no effect on the correct working of the example.
 2020-11-17 17:00:36 +01:00
edenlightning 53f14391da
Rename distributed_backend to accelerator in examples (#4657) 
* Rename distributed_backend to accelerator

* Update submit_ddp2_job.sh

* Update 05-trainer-flags-overview.ipynb

Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
 2020-11-15 15:47:14 +01:00
Indrayana Rustandi 6e5f232f5c
Add Dali MNIST example (#3721) 
* add MNIST DALI example, update README.md

* Fix PEP8 warnings

* reformatted using black

* add mnist_dali to test_examples.py

* Add documentation as docstrings

* add nvidia-pyindex and nvidia-dali-cuda100

* replace nvidia-pyindex with --extra-index-url

* mark mnist_dali test as Linux and GPU only

* adjust CUDA docker and examples.txt, fix import error in test_examples.py

* adjust the GPU check

* Exit when DALI is not available

* remove requirements-examples.txt and DALI pip install

* Refactored example, moved to new logging api, added runtime check for test and dali script

* Patch to reflect the mnist example module

* add req.

* Apply suggestions from code review

* Removed requirement as it breaks CPU install, added note in README to install DALI

* add DALI to Drone

* test examples

* Apply suggestions from code review

* imports

* ABC

* cuda

* cuda

* pip DALI

* Move build into init function

Co-authored-by: SeanNaren <sean@grid.ai>
Co-authored-by: Jirka Borovec <jirka@pytorchlightning.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
 2020-11-06 14:53:46 +00:00
chaton a32bffcdea
feature/ Add note about Argparse. (#4321) 
* add a note about argparse

* update

Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
 2020-11-03 23:40:51 +06:30
Sahin Kureta 90bb7b1fbb
update examples (#4233) 
* Removed image generation inside the training step.

It was overwriting the image grid generated in `on_epoch_end`. I also made `adversarial_loss` a static method.

* Incorporated Hyperparameter best practices

Using ArgumentParser and hparams as defined in the Hyperparameters section of
the documentation. This way we can set trainer flags (such as precision,
and gpus) from the command line.

* Incorporated Hyperparameter best practices

Using ArgumentParser and hparams as defined in the Hyperparameters section of
the documentation. This way we can set trainer flags (such as precision,
and gpus) from the command line.

* Split the data part into a LightningDataModule

* Update pl_examples/domain_templates/generative_adversarial_net.py

Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
 2020-10-21 18:07:18 +02:00
Jirka Borovec 8873750cf0
remove deprecated early_stop_callback (#3982) 2020-10-08 06:30:33 -04:00
William Falcon 04303b3a2e
added bug report model (#3901) 2020-10-06 09:05:20 -04:00
William Falcon a28528cc8b
ref: remove weight loading hack for ddp_cpu (#3808) 2020-10-02 19:28:50 -04:00
William Falcon 440f837f6d
ref: part a of #3733 (#3766) 
* ref: part a of #3733

* ref: part a of #3733
 2020-10-01 08:15:23 -04:00
William Falcon 7c61fc7c27
ref: fixes logging for eval steps (#3763) 
* fixes logging for eval steps
 2020-10-01 02:31:11 -04:00
William Falcon 00ba2b24b7
Drop all result docs. Make the separation between flow and logging clear (#3744) 
* remove results docs. separate flow from log
 2020-09-30 08:31:16 -04:00
Jirka Borovec aa52c930f4
test examples (#3643) 
* test examples

* testing

* testing

* typo

* req

* exception

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
 2020-09-24 17:33:11 +02:00
William Falcon c94c0a2b1e
fix examples (#3631) 
* fix examples

* fix examples
 2020-09-23 17:58:03 -04:00
William Falcon 12184854f9
Update README.md 2020-09-23 00:21:53 -04:00
William Falcon 031274c25d
fix dp issues + update examples and test examples (#3618) 
* fix dp

* fix dp

* fix dp

* fix dp

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples
 2020-09-23 00:19:46 -04:00
Vasudev Gupta f22292c5f2
GANs in pl-examples updated for lightning-0.9 (#3152) 
* gan updated for lightning-0.9

* bugs fixed
 2020-08-25 11:05:03 -04:00
Adrian Wälchli 6ad27187f3
Finish PR #2432: Imagenet example updates + basic testing (#2889) 
* fix imagenet example: lr_scheduler, loader workers, batch size when ddp

* Fix evaluation for imagenet example

* add imagenet example test

* cleanup

* gpu

* add imagenet example evluation test

* fix test output

* test is fixed in master, remove unecessary hack

* CHANGE

* Apply suggestions from code review

* image net example

* update imagenet example

* update example

* pep

* imports

* type hint

* docs

* obsolete arg

* [wip] fix imagenet example: lr_scheduler, loader workers, batch size when ddp (#2432)

* fix imagenet example: lr_scheduler, loader workers, batch size when ddp

* Fix evaluation for imagenet example

* add imagenet example test

* cleanup

* gpu

* add imagenet example evluation test

* fix test output

* test is fixed in master, remove unecessary hack

* CHANGE

* Apply suggestions from code review

Co-authored-by: Jirka <jirka@pytorchlightning.ai>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* update chlog

* add missing chlog

* pep

* pep

Co-authored-by: Ruotian Luo <rluo@ttic.edu>
Co-authored-by: Jirka <jirka@pytorchlightning.ai>
 2020-08-09 06:02:07 -04:00
Jirka Borovec b7d72706c3
clean imports (#2867) 
* clean imports

* miss
 2020-08-08 00:33:51 +02:00
Ananya Harsh Jha a5f2b89ed0
updated sync bn (#2838) 
* updated sync bn

* updated sync bn

* updated sync bn

* updated sync bn

* updated sync bn

* updated sync bn

* updated sync bn

* updated sync bn

* added ddp_spawn test

* updated test

* clean

* clean

Co-authored-by: Jirka Borovec <jirka@pytorchlightning.ai>
 2020-08-06 01:12:11 +02:00
Ananya Harsh Jha e31c520c21
add support for sync_bn (#2801) 
* initial commit for sync_bn

* updated changelog

* tests

* tests

* ddp tests hanging with script tests

* updated trainer

* updated params

* test

* passingtests

* passing tests

* passing tests

* passing tests

* tests

* removed apex

* doc

* doc

* doc

* doc

* docs

* tests

* tests

* tests
 2020-08-05 13:29:05 -04:00