Commit Graph

1328 Commits

Author SHA1 Message Date
Rangi bd45cfd5fd Add `assert PokemonPicPointers == UnownPicPointers` in `GetFrontpicPointer` 2021-10-06 17:44:34 -04:00
Rangi fb2a95afed `and 50 percent` -> `and %011111111` 2021-09-07 19:18:22 -04:00
IIMarckus a283f44954 More EFFECTIVEness. 2021-08-16 14:44:57 -06:00
IIMarckus 52290d8e03 Use EFFECTIVE constant for 1.0× battle damage. 2021-08-16 14:42:45 -06:00
Rangi d93c13c94c Identify more palettes in CBG layouts 2021-07-19 18:59:16 -04:00
Nescientist 80a3f7e1ba
Fixing comments in BattleCommand_Teleport 2021-06-20 10:56:11 -04:00
Rangi f59f1bdb88 Standardize capitalization of ".Jumptable" 2021-06-19 19:52:05 -04:00
TheFakeMateo 7a03fecc38 Fix incorrectly swapped Players PC menu constants 2021-06-09 19:31:54 -04:00
Rangi e4d82e92d0 Rename `prioritysjump` to `sdefer` 2021-06-08 20:35:04 -04:00
Rangi 1f9e688b76 MON_PKRUS -> MON_POKERUS 2021-06-07 20:00:21 -04:00
Rangi a41dac9a2f "ld [MON_LEVEL], a" in ComputeNPCTrademonStats should be "ld [wCurPartyLevel], a" 2021-06-07 19:36:03 -04:00
Rangi e140e88b7b Add more comments to tileset palette animation functions 2021-05-30 23:32:03 -04:00
Rangi ed0a0f7159 Move the dbbw, dbww, and dbwww macros to legacy 2021-05-30 15:51:49 -04:00
Rangi b1dbadbdd3 Require rgbds 0.5.1
Use some new features: \<10> macro args, SECTION UNION, SIZEOF/STARTOF, and CHARLEN/CHARSUB
2021-05-09 12:26:28 -04:00
Rangi efd1006917
Use {interpolation} to generate sequences of RAM labels
This makes the table_width/assert_table_length usages unnecessary, and also keeps the labels automatically up to date if the length constants change.
2021-04-27 12:11:39 -04:00
Rangi c5f9e25cc4 SPECIAL -> UNUSED_TYPES_END 2021-04-26 12:00:16 -04:00
Rangi 316fa4b695 Use rgbds 0.5.0 2021-04-19 16:31:37 -04:00
Rangi 2fe0cbbb19 Add some comments regarding 16-bit increment/decrement 2021-03-24 18:34:33 -04:00
Rangi dc18e188b2 Sync some files with pokegold 2021-03-24 10:24:52 -04:00
Rangi 8bf76af5a7 Consistent comments in the tileset animation engine 2021-03-23 20:47:32 -04:00
Rangi dbe2360ecd Miscellaneous cleanup 2021-03-22 16:41:17 -04:00
Rangi 8daf8fe19c The radio's "Places & People" does not comment on Mysticalman Eusine 2021-03-21 21:07:45 -04:00
Rangi 90ce126139 Use numeric constants in text strings with "{d:interpolation}" 2021-03-21 18:14:31 -04:00
Rangi 0506e5b1b9 Assert the sBox1-14 tables have NUM_BOXES entries 2021-03-21 17:47:53 -04:00
Rangi 4522162d45 Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
Rangi 6c8f8609cb Assert some more table widths 2021-03-17 11:38:01 -04:00
Rangi 3684296583 Revise some constant definitions 2021-03-16 18:06:18 -04:00
Rangi ec1fe073a3 $11 = wTempMonStructEnd - wTempMonLevel 2021-03-15 15:40:48 -04:00
Rangi 97a11c623e Sync some files with pokegold 2021-03-11 17:43:20 -05:00
Rangi d132a20b7a Verify script command table sizes 2021-03-11 16:28:52 -05:00
Rangi dbabd8b4a9 Define MAPGROUP_* constants and verify MapGroup_* table sizes 2021-03-10 21:16:54 -05:00
Rangi e791c5392b
Merge pull request #806 from Rangi42/tables
Verify data table sizes with table_width and assert_table_length macros
2021-03-08 07:01:31 -08:00
Rangi c1c609ec4a Identify scrolling menu lists in WRAM
Fixes #809
2021-03-08 09:41:55 -05:00
Rangi 40902ffe24 Verify data table sizes with table_width and assert_table_length macros
This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi 4401d24074 Identify link sync buffers, separate from link action bytes
Fixes #803
2021-02-22 12:02:52 -05:00
Rangi 287d893d22 Use PARTY_LENGTH and MAILBOX_CAPACITY constants 2021-02-10 08:50:39 -05:00
Rangi 5b9e6c0299 Identify label BattleTowerFade.loop 2021-02-05 14:56:29 -05:00
Rangi 4be482e587
Merge pull request #799 from FredrIQ/typo_fix
Battle Tower: fix typo in constant (PROGESS -> PROGRESS)
2021-02-05 09:45:11 -08:00
Rangi 4264d53eb6 Identify some more labels 2021-02-05 12:44:21 -05:00
Fredrik Ljungdahl 8f4dcbcb59 Battle Tower: fix typo in constant (PROGESS -> PROGRESS) 2021-02-04 12:42:56 +01:00
Rangi 7d3ea88611 Rename GetFarHalfword to GetFarWord
Fixes #796
2021-01-09 15:16:05 -05:00
Rangi 5db892782a Remove "Buffer" suffix from two HRAM labels 2020-12-23 16:54:28 -05:00
Rangi 99e66c2557 Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"

Fixes #789
2020-12-23 16:29:30 -05:00
Rangi 6f226f584c Identify link.asm WRAM labels based on ax6's research notes <https://pastebin.com/NTxjzKGQ> 2020-12-08 21:24:48 -05:00
Rangi 9fea403be2 grey -> gray 2020-12-08 14:34:54 -05:00
Rangi 098903fc97 FarString -> PlaceFarString, and document a BrokenPlaceFarString bug 2020-12-07 13:32:08 -05:00
Rangi 4ef556cbc8 Document AI_Smart_Conversion2 bug (resolves #786) 2020-12-07 13:13:03 -05:00
aljohnston112 7b9d8767d4
Identified two magic numbers and cleaned up some comments (#783)
Improve the audio engine's comments and replace some magic numbers with constants
2020-12-07 12:44:16 -05:00
Rangi 5e9d43e39b text "<PARA>..." → text_start and para "..." 2020-12-04 22:28:31 -05:00
Rangi 4613bcfadf Use STRING_BUFFER_LENGTH for the wStringBuffers 2020-11-24 20:11:17 -05:00