Commit Graph

147 Commits

Author SHA1 Message Date
PikalaxALT 60cd04b023 Trainer data structure and field move functions
Trainer data in map scripts is now a macro-defined structure.

Field move functions in main.asm are now nearly completely annotated, with local references.

Trailing white space deleted.
2015-07-18 23:45:39 -04:00
PikalaxALT 39524cdb76 More enumeration of constants, more annotations of scripts. 2015-07-15 15:48:44 -04:00
yenatch c00949dddf Labels for the heal machine; spriteface constants. 2015-06-26 23:24:55 -07:00
IIMarckus 4d532beee6 Remove trailing newlines. 2015-06-23 12:24:51 -06:00
IIMarckus 2bf3a322ba Labels for "sent some to mom" text. 2015-06-11 10:57:45 -06:00
Scott Norton 739bac75b7 Updated text pointer in line 5746. 2015-06-07 21:14:20 -04:00
yenatch ee98f7b489 Enumerate the move effect command macros. 2015-04-13 21:41:32 -07:00
yenatch 6c492cb86d Comment PrintTempMonStats. 2015-02-11 13:15:38 -08:00
yenatch 3735185ec2 Use PartyMon labels in GetPartyParamLocation arguments. 2015-02-11 13:14:56 -08:00
yenatch 956b990cd2 Fix a bunch of palette copying errors and wram bank conflicts.
There are probably a bunch more labels with wrong banks. This takes care of the most noticeable ones.
2015-02-10 18:21:38 -08:00
yenatch 62b473d6c6 Blind wram labels part 3. 2015-02-10 15:14:21 -08:00
yenatch 8e03321069 Blindly use wram labels for everything except mobile, part 1.
Wram banks and mobile make this tough, since any address can secretly be a ghost.

As usual, mobile completely disregards 99% of the codebase. It's been ignored in kind.
2015-02-10 00:53:03 -08:00
yenatch 0683bc8770 Fix up remaining coords. 2015-02-07 23:06:52 -08:00
yenatch c611a45486 Inconsequential bank ref in battle graphics code. 2015-02-02 16:39:42 -08:00
yenatch 3fe3cd1a46 hVBlank 2015-01-19 21:31:29 -08:00
yenatch 346844a613 Replace pointless $FF00+$xx with $ffxx. 2014-12-28 18:44:23 -08:00
yenatch e325210a61 Merge remote-tracking branch 'kanzure/master' 2014-12-11 23:25:30 -08:00
yenatch 2f509ab379 Fix some incbins near Magikarp length code.
Also clean up the comments a little.
2014-12-03 20:12:37 -08:00
yenatch 81e2a3f0cf Merge remote-tracking branch 'xcrystal/master' into master
Conflicts:
	battle/ai/scoring.asm
	main.asm
2014-10-23 02:41:52 -04:00
xCrystal dd8653fe6f More AI commentary/labels 2014-10-22 23:08:51 +02:00
xCrystal bb9818e3c3 More AI commentary/labels 2014-10-22 17:36:42 +02:00
xCrystal bf60a6b690 evasionup, accdown, whirlwind, haze 2014-10-22 14:47:33 +02:00
xCrystal 7cbec0d52a More AI commentary/labels 2014-10-22 00:28:51 +02:00
xCrystal 96a89ffad7 More AI commentary 2014-10-21 20:44:42 +02:00
xCrystal 44377acb2a Rename labels and add more commentary to AI stuff 2014-10-21 19:21:13 +02:00
xCrystal 28097be25c Add commentary to some AI layers 2014-10-21 14:17:55 +02:00
xCrystal df2d027501 Start commenting some AI layers 2014-10-21 13:54:04 +02:00
yenatch 78d16c1efa Better labels for item/switch AI. 2014-09-30 11:20:38 -07:00
yenatch da799c80d4 Better trainer AI comments and finish off trainer attributes. 2014-08-13 19:44:56 -07:00
yenatch 849044ce8a Remove generated "jump sources" comments. 2014-07-19 14:11:48 -07:00
yenatch 928cdcfc23 Name cry functions in home.asm. 2014-07-18 10:31:52 -07:00
yenatch 251517812f Rename the internal PlayCry function to _PlayCryHeader. 2014-07-18 10:31:52 -07:00
yenatch ab018a5094 Cry "echo" is actually the upper byte of pitch (now a word). 2014-07-18 10:31:51 -07:00
yenatch d6fbdfb8de More comments and constants in move effect command code.
Also add SUBSTATUS_IN_LOOP for multi-hit moves.
2014-06-23 12:47:52 -07:00
yenatch 32a5f21cc7 More PartyMon labels for relative addressing. 2014-06-23 12:45:30 -07:00
yenatch bc3a21193d Residual damage, battle text labels, pic predefs. 2014-06-18 00:55:44 -07:00
yenatch dbe4c7ab67 Fix some misnamed substatus constants.
SUBSTATUS_ROLLOUT was actually SUBSTATUS_RAMPAGE.
SUBSTATUS_ENCORED was actually SUBSTATUS_ROLLOUT.
Substatus 5 bit 4 was actually SUBSTATUS_ENCORED.

Also use some more (sub)status constants where needed.
2014-06-17 12:52:32 -07:00
yenatch c2dba43188 Contest battle type and comment the battle menu. 2014-06-17 11:58:11 -07:00
yenatch 541a9c7347 Name the UpdateEnemyHUD predef.
Also start using hp palette constants.
2014-06-16 22:53:56 -07:00
yenatch 8639fcd29b Use a predef macro that takes labels instead of juggling constants.
Besides making predefs convenient, naming a predef no longer requires
adding or renaming a predef constant. This also lets predefs be rearranged at will.
2014-06-16 11:20:01 -07:00
yenatch db27602679 Name and comment the trainer party reader.
Reads the contents of trainers/trainers.asm.
2014-06-14 22:35:00 -07:00
yenatch e6271ca450 Move trainer item AI into battle/ai/items.asm. 2014-06-14 15:03:23 -07:00
yenatch b83f237254 Rename _GetBattleVar -> GetBattleVarAddr.
Functions prefixed with _ imply they're private.
The real purpose of this function is to use an address,
rather than saving a few cycles on push/pop.
2014-06-14 00:41:34 -07:00
yenatch e23f341258 Battle type constants in the wild.
Also add constants for trap and Celebi event battles.
2014-06-13 22:53:20 -07:00
yenatch eb9fc6676c More battle code cleanup.
- Use more substatus constants.
- Reformat some code to be more atomic.
- Add constants for unused status prevention held item effects.
- Remove pointless or redundant comments.
2014-06-13 21:18:14 -07:00
yenatch 023cfdbb05 Consolidate monster structs in wram and sram.
The PartyMon struct is really the box struct with volatile variables like status added.

Some other labels have been reworked.
Move structs no longer have explicit labels since their location is arbitrary and usually shared.
2014-06-12 18:32:42 -07:00
yenatch 23f9b5d21e Use constants for move struct positioning.
This eliminates the need for arbitrary move labels like Move2 and Move1 that don't have anything to do with their respective moves.
2014-06-10 23:24:25 -07:00
yenatch 86c1e0feea Consolidate NUM_MOVES usage and monster struct labels.
There turned out to be a lot of instances of NUM_MOVES.
2014-06-10 23:08:07 -07:00
yenatch fd8804472d Use {hl,de,bc}coord macros wherever possible. 2014-06-04 01:10:56 -07:00
yenatch 20444d2f63 More MAX_LEVEL use. 2014-06-03 14:07:10 -07:00