Commit Graph

5367 Commits

Author SHA1 Message Date
thomas chaton 9e61de2063
Torch Elastic DDP DeadLock bug fix (#8655)
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-08-02 21:48:43 +02:00
Carlos Mocholí d83dd7969d
Disable recurrent events on forks (#8668) 2021-08-02 18:12:13 +00:00
Jirka Borovec 661522e173
black: magic trailing comma (#8560) 2021-08-02 20:02:36 +02:00
Carlos Mocholí ca96b2d23e
Delete deprecated save function (#8680) 2021-08-02 19:28:31 +02:00
Jirka Borovec f67892ea96
CI: yesqa (#8564)
* add yesqa
* fix flake8

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-08-02 16:05:56 +00:00
Jirka Borovec 66cc505339
update NGC (#8652)
* update NGC

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-08-02 16:05:36 +00:00
Carlos Mocholí cf0d362658
Delete deprecated `TrainerTrainingTricksMixin` (#8679) 2021-08-02 18:00:32 +02:00
Carlos Mocholí d187008e84
Un-skip some Horovod tests (#8676) 2021-08-02 17:54:05 +02:00
Kaushik B 850416f0a0
Fix distributed types support for CPUs (#8667) 2021-08-02 16:42:28 +05:30
thomas chaton 85bba06529
update (#8674) 2021-08-02 11:56:09 +02:00
Sean Naren 7a1e97203e
Add property to skip restoring optimizers and schedulers via plugin (#8644) 2021-07-31 10:08:10 +02:00
Daniel Stancl 1f01db8b30
Fix mypy in utilities.argparse (#8124)
Co-authored-by: tchaton <thomas@grid.ai>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-07-30 16:36:55 +00:00
Adrian Wälchli 16392a7de7
Update links for `zero_grad` to PyTorch docs (#8618) 2021-07-30 16:09:36 +02:00
Wei Ji a78709751a
Reverse width, height to height, width in docs (#8612)
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-07-30 13:56:17 +00:00
Rio H ba8053492f
Deprecate LightningModule.model_size (#8495)
Co-authored-by: Caleb Robinson <calebrob6@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-07-30 13:53:40 +00:00
Adrian Wälchli 529c42f848
fix collecting training_step outputs (#8613) 2021-07-30 13:03:15 +00:00
Carlos Mocholí 5789e9f5e4
Fix reference issues during epoch end result collection (#8621)
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-07-30 12:16:47 +00:00
Carlos Mocholí 93784da2c3
Fix pre-commit blacken-docs failures (#8624) 2021-07-30 12:10:15 +00:00
Adrian Wälchli 1bc052c290
Remove dead code in eval loop output tracking (#8625) 2021-07-30 14:04:51 +02:00
Carlos Mocholí bb4887368c
Docs improvements around hparams (#8577)
Co-authored-by: thomas chaton <thomas@grid.ai>
2021-07-30 11:06:03 +00:00
Carlos Mocholí 9720e264f5
Fix references for `ResultCollection.extra` and improve `str` and `repr` (#8622) 2021-07-30 12:47:34 +02:00
Sean Naren 07b7dc9c17
[Fix] Add delay property for checkpointing, refactor loading checkpoint (DeepSpeed Checkpointing Fix 1/n) (#8627)
* Add property to delay checkpointing, move loading checkpoint file into the run function to allow deepspeed engine to be loaded

* Add a small test

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* Update pytorch_lightning/accelerators/accelerator.py

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* Address review

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-07-30 11:31:08 +01:00
Adrian Wälchli b6ea6373dd
exclude mpi run from auto-detection of horovod (#8610) 2021-07-30 12:01:00 +02:00
Carlos Mocholí c99e2fe0d2
Test `Callback.on_load_checkpoint` order (#8588) 2021-07-29 12:28:29 +02:00
Adrian Wälchli 7901d297d3
remove support for optimizer_idx in the training_step for manual optimization (#8576) 2021-07-29 08:30:45 +00:00
Kaushik B 9c80727b8c
Add ddp_cpu to DistributedType Enum (#8596) 2021-07-29 10:02:32 +02:00
Carlos Mocholí c2199fbbee
Fix `trainer.fit_loop.split_idx` reference (#8601)
* Fix split idx reference

* Update CHANGELOG

* Add comment
2021-07-29 08:00:04 +00:00
Carlos Mocholí 0dc0472e1f
Use class name in SWA info message (#8602) 2021-07-29 09:39:46 +02:00
Carlos Mocholí ebd2e87752
Delete deprecated `TrainerLoggingMixin` (#8609)
* Delete deprecated `TrainerLoggingMixin`
* Update CHANGELOG
* Delete from Trainer
2021-07-29 08:39:16 +02:00
Adrian Wälchli 8c27fa71fa
[1 / 3] improvements to saving and loading callback state (#6886)
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-07-29 00:12:32 +02:00
Jirka Borovec 0c0b24c031
Prune deprecated metrics (#8586)
* drop metrics

* drop tests

* fix imports

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-07-28 16:57:31 +00:00
Carlos Mocholí 47c47faeae
Remove `outputs` in `on_train_epoch_end` hooks (#8587) 2021-07-28 18:27:54 +02:00
Jirka Borovec 470842f5c8
CI: validate JSON & fix benchmark (#8567)
* CI: validate JSON

* as GHA

* PT1.8

* 32g

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-07-28 18:09:15 +02:00
Jirka Borovec 0a71fe2859
CI: black docs (#8566)
* black docs

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-07-28 18:08:31 +02:00
Sean Naren aadd2a9d9c
Load ckpt path when model provided in validate/test/predict (#8352)
* Change trainer loading behaviour for validate/test/predict

* Fix

* Fix/add tests

* remove

* Cleanups

* Space

* cleanups

* Add CHANGELOG.md

* Move after setup

* Cleanups on logic

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Remve

* fix test

* feedback

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update pytorch_lightning/trainer/properties.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Feedback

* Same fix

* Same fix

* Add test for behaviour, modify based on feedback

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Wording

* Apply suggestions from code review

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Cleanup docs

* Update pytorch_lightning/trainer/trainer.py

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>

* feedback

* Fixes to test API

* Add carlos description

* Move logic further

* Move checkpoint connector logic

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
2021-07-28 10:12:46 +00:00
Santiago Castro b256d6acd3
Avoid unnecessary list creation (#8595) 2021-07-28 13:36:45 +05:30
Adrian Wälchli df16713745
bump version 1.3 to 1.4 in README (#8582) 2021-07-27 19:29:04 -07:00
Jirka Borovec 6b47cbe3ca
Update version to `1.5.0dev` (#8585)
* dev + chlog

* Add placeholders

* Clean previous entry

* Add CHANGELOG fix

Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-07-27 12:52:18 -04:00
Carlos Mocholí 7914e494dd
Replace `iteration_count` and other index attributes in the loops with progress dataclasses (#8477)
* Delete `iteration_count` and `batches_seen`

* Update CHANGELOG

* Protect should accumulate

* Update pytorch_lightning/loops/epoch/training_epoch_loop.py
2021-07-27 18:36:20 +02:00
thomas chaton c7f8c8c3c8
[bugfix] DeepSpeed with no schedulers (#8580)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-07-27 15:28:10 +00:00
Kaushik B 39de7fefeb
Lightning Release v1.4 (#8579)
* Update Lightning version to v1.4

* update notebooks

* Update release date in Changelog

* docs

Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-07-27 14:00:13 +00:00
edenlightning c7e5743d54
Update cloud docs (#8569)
* amp

* amp

* docs

* add guides

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* amp

* amp

* docs

* add guides

* speed guides

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Delete ds.txt

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update conf.py

* Update docs.txt

* remove 16 bit

* remove finetune from speed guide

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* speed

* speed

* speed

* speed

* speed

* speed

* speed

* speed

* speed

* speed

* speed

* speed

* remove early stopping from speed guide

* remove early stopping from speed guide

* remove early stopping from speed guide

* fix label

* fix sync

* reviews

* Update trainer.rst

* Update trainer.rst

* Update speed.rst

* Apply suggestions from code review

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* managing data

* managing data

* amp

* amp

* docs

* sync

* sync

* amp

* amp

* add data guide

* from review

* Apply suggestions from code review

Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>

* from review

* from review

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add data guide

* add data guide

* add data guide

* sync issues

* from reviw

* Update docs/source/guides/data.rst

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>

* add info if import fails

* fix cross referencing

* Add Datamodule motivation

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* grid docs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update cloud_training.rst

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-07-27 16:22:52 +03:00
Kaushik B 4b7f78e200
Add deprecation warning & test for distributed_backend flag (#8575)
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-07-27 18:01:48 +05:30
Aslı Sabancı 4605e8a4a5
Add missing highlighting for Python snippets (#8411)
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-07-27 13:22:05 +02:00
Max d90cb7fceb
Bugfix: Scheduler monitor for manual optimization (#7643)
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kaushik B <kaushikbokka@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-07-27 16:04:14 +05:30
Adrian Wälchli eaa16c7480
docs: explain how Lightning uses closures for automatic optimization (#8551) 2021-07-26 15:40:16 +00:00
Jirka Borovec 75e18a5298
v1.4.0rc2 (#8553)
* v1.4.0rc2

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* Apply suggestions from code review

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-07-26 10:01:23 -04:00
Kaushik B f457f97d97
Raise exception for ddp_cpu not supported for TPUs (#8530) 2021-07-26 13:52:34 +00:00
Carlos Mocholí c5167e90e1
Fix profiler test on Windows minimal (#8556) 2021-07-26 13:25:24 +00:00
Carlos Mocholí e63968ab88
Add `pyupgrade` to `pre-commit` (#8557)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-07-26 14:38:12 +02:00