Commit Graph

5367 Commits

Author SHA1 Message Date
Carlos Mocholí 3e6f884a89
Avoid Pillow 8.3.0 due to errors with numpy (#8234)
* Avoid Pillow 8.3.0

* Move it to last
2021-07-01 13:16:38 +00:00
Palermo 36b893c43e
Add `ModelSummary.max_depth` (#8062)
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-07-01 12:08:16 +02:00
Mauricio Villegas 3c74502919
Add support for optimizers and learning rate schedulers to LightningCLI (#8093)
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-07-01 12:04:11 +02:00
karthikrangasai 1afc1ca7ef
Logging Non-matching keys when loading from checkpoint in non-strict … (#8152)
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-06-30 18:33:13 +00:00
thomas chaton acb6f26006
[Refactor] Remove should_raise_exception (#8202)
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
2021-06-30 17:02:10 +00:00
deepsource-autofix[bot] c0782ffd1f
Remove unnecessary generator (#8154)
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-06-30 11:40:13 +00:00
Carlos Mocholí 74eb6cc7e9
Clean `cuda.empty_cache` usage (#8199) 2021-06-30 13:04:24 +02:00
Ethan Harris 57dce7244c
Fix double precision casting complex buffers (#8208)
* Fix double precision casting complex buffers

* Update CHANGELOG.md

* Fixes

* Fixes

* Fix

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-06-30 10:57:42 +01:00
Adrian Wälchli d2203a8f18
update bug report issue template - include PL version (#8209)
* update github template

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Update .github/ISSUE_TEMPLATE/bug_report.md

Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
2021-06-30 10:47:44 +02:00
SATISH J 4af8eff0a1
fix: training_step_end doesn't work as stated in docs (#8188) 2021-06-30 00:24:06 +00:00
Carlos Mocholí 2e537b75e3
Deprecate `DDPPlugin.task_idx` (#8203) 2021-06-30 01:02:55 +02:00
Carlos Mocholí 87b1b86e2f
Add missing logging tests (#8195) 2021-06-29 22:52:50 +00:00
Carlos Mocholí df601405d9
Use full `torch.distributed` import (#8200) 2021-06-29 22:44:10 +00:00
Carlos Mocholí 47c76548aa
Sync our torchmetrics wrappers after the 0.4 release (#8205)
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
2021-06-29 22:05:48 +00:00
Kaushik B 9444a08d56
Fix Deprecation warning in DDPSpawn (#8193) 2021-06-29 09:29:51 -07:00
Carlos Mocholí 9aaa6822ec
Add CODEOWNERS for progress dataclasses (#8196) 2021-06-29 10:01:51 -04:00
thomas chaton bae08514d1
[refactor] Add should_raise_exception for gpus / tpus utilities (#8194)
* add should_raise

* update changelog

* Update pytorch_lightning/utilities/device_parser.py

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>

* add to tpu_cores parser

* add should_raise description

* update on comments

* update changelog

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
2021-06-29 10:00:06 -04:00
Jirka Borovec df6885cd37
add how to contribute (#8129)
* add how to contribute

* docs

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* Apply suggestions from code review

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>

* Update README.md

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
2021-06-29 13:25:10 +00:00
Carlos Mocholí 571a810a7c
Improvements and changes to progress tracking dataclasses (#8140)
* Improvements to progress dataclasses

* Update CHANGELOG

* Rename function

* Undo CODEOWNERS update
2021-06-29 13:47:41 +01:00
Kaushik B 2a7fad92b9
Avoid passing unnecessary params from TPUSpawn to DDPSpawn (#8192) 2021-06-29 14:30:54 +02:00
Kaushik B f60aae9815
Update `dataloaders` params in example (#8191) 2021-06-29 14:23:48 +02:00
Adrian Wälchli 6db0fe3659
training loop refactor - move val loop (#8120)
* EvaluationDataLoaderLoop -> EvaluationLoop

* proposed rename files

* imports

* bad merge

* update init files

* glue imports together

* rename fit_loop.validation_loop to fit_loop.val_loop

* move loop

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Group imports

* Resolve circular import

* Comment

* fix test

* try to resolve circ import

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-06-29 09:06:44 +00:00
Adrian Wälchli ae34df00cc
remove deadcode in trainer (#8121) 2021-06-29 09:11:24 +01:00
Justus Schock b12a0d0a0a
Make Plugins Proxies after transfering ownership (#8117)
* Update accelerator_connector.py

* Update accelerator_connector.py

* Update accelerator_connector.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update accelerator_connector.py

* Update accelerator_connector.py

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-06-28 22:21:48 +01:00
Justus Schock d6435a5b73
Bugfix/swa iterable dset (#8172)
* add test

* add fix

* Update CHANGELOG.md
2021-06-28 21:18:25 +00:00
Ethan Harris b1d8840fd8
Fix metric attribute lookup (#8181)
* Fix metric attribute lookup

* Update CHANGELOG.md

* Split tests
2021-06-28 20:17:43 +00:00
Adrian Wälchli bf54ac1cad
fix NCCL error with non-consecutive trainer gpus (#8165)
* device ids in barrier


x


x


s


same fix for spawn


fix non-nccl 


x

* add changelog

* get nccl backend

* get backend

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
2021-06-28 22:08:10 +02:00
Kaushik B 2f3c65e57b
XLA Profiler integration (#8014) 2021-06-29 00:58:05 +05:30
thomas chaton c521624a92
[bugfix] Add mechanism to prevent deadlock for DDP on Exception Trigger (#8167)
* add mechanism to prevent deadlock

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* resolve flake8 + update changelog

* update on comments

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update

* remove space

* resolve bugs

* overwrite config

* update on comments

* update on comments

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update

* update

* update test with comments

* Update pytorch_lightning/plugins/training_type/parallel.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* update on comments

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-06-28 19:26:03 +00:00
thomas chaton 1f025789fc
[bugfix] Clean Validation Sanity Checking metrics (#8171)
* resolve logging issue

* update changelog

* remove breakpoint

* resolve bugs

* remove pass
2021-06-28 13:49:56 -04:00
thomas chaton c4492ad6aa
Merge pull request #8174 from PyTorchLightning/bugfix/8159_log_gpu_memory_on_step
[bugfix] Resolve memory not logged when missing metrics
2021-06-28 09:39:17 -04:00
Ethan Harris 2a372e3682
Fix module dict in base finetuning (#8170)
* Fix module dict in base finetuning

* Update CHANGELOG.md
2021-06-28 10:55:32 +00:00
Adrian Wälchli b978d2a1f2
remove message (#8163) 2021-06-28 09:57:52 +00:00
deepsource-autofix[bot] 03154eb30a
Refactor unnecessary `else` / `elif` when `if` block has a `return` statement (#8156)
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
2021-06-28 15:27:41 +05:30
deepsource-autofix[bot] 67f7e1318f
Fix dangerous default argument (#8164)
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
2021-06-28 09:52:37 +00:00
deepsource-autofix[bot] 9bd3747c71
Remove unnecessary use of comprehension (#8147)
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
2021-06-28 11:38:50 +02:00
deepsource-autofix[bot] c3065c5ce9
Iterate dictionary directly (#8155)
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
2021-06-27 21:55:16 +02:00
Adrian Wälchli 51ea84222b
resurface lost ddp info message (#8111) 2021-06-27 21:51:15 +02:00
Jirka Borovec 28afc7a10d
ignore tests in DeepSource analyses (#8151)
* ignore tests

* .
2021-06-27 11:08:20 +00:00
deepsource-autofix[bot] e11fe19673
Remove unnecessary use of comprehension (#8149)
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
2021-06-27 10:00:02 +01:00
Jirka Borovec 3526d9323a
add .deepsource.toml (#8144) 2021-06-26 18:38:08 +00:00
thomas chaton 24db914093
Support state restoration of logged results 2/2(#7966)
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-06-25 19:16:11 +00:00
DJ ad95710812
document exceptions in utilities (#8122)
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-06-25 13:41:45 +00:00
Adrian Wälchli 55a90af7fc
`pytorch_lightning.loops` file structure: group by dataloader, epoch, and batch loop (#8077) 2021-06-24 23:40:46 +02:00
Carlos Mocholí 2c43bfc5ef
GPU CI - run torch 1.8 (LTS) (#8116) 2021-06-24 16:56:43 +00:00
edenlightning d4d5418cc4
Fix notebook links (#8089)
* Fix notebook links

* update

* BERT

* docs

* Update README.md

* Apply suggestions from code review

Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-06-23 21:36:31 +00:00
Carlos Mocholí 4d9b72b8a9
Nuke RPC (#8101) 2021-06-23 18:31:13 +00:00
Sean Naren 8bd7b1bdd7
Add torchelastic check when sanitizing GPUs (#8095)
* Add torchelastic check

* Add changelog

* Address review

* fix
2021-06-23 14:09:53 +02:00
Adrian Wälchli 4dc08e4035
Loop Refactor 6/N - Remove Old Predict Loop (#8094) 2021-06-23 14:05:06 +02:00
Adrian Wälchli fe48203111
restrict public interface of training loop (#8024)
* active optimizers

* check checkpoint callback

* epoch loop properties

* epoch loop methods

* training_batch_loop

* changelog

* update chlog

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* unused imports

* yapf

* backward

* fix missing string reference

* is_last_batch remains public

* remove dead code

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
2021-06-23 10:25:29 +00:00