Commit Graph

83 Commits

Author SHA1 Message Date
Jirka Borovec f67892ea96
CI: yesqa (#8564)
* add yesqa
* fix flake8

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-08-02 16:05:56 +00:00
Carlos Mocholí e63968ab88
Add `pyupgrade` to `pre-commit` (#8557)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-07-26 14:38:12 +02:00
Carlos Mocholí a64cc37394
Replace `yapf` with `black` (#7783)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-07-26 13:37:35 +02:00
Carlos Mocholí ae1fd6a201
Unblock GPU CI (#8456)
* Debug

* Increase SHM size

* Debug

* Refactor MNIST imports

* Undo debugging

* Prints
2021-07-19 09:41:18 +02:00
deepsource-autofix[bot] b2ba2e6333
Use literal syntax instead of function calls to create data structure (#8406) 2021-07-14 10:32:13 +00:00
deepsource-autofix[bot] 03154eb30a
Refactor unnecessary `else` / `elif` when `if` block has a `return` statement (#8156)
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
2021-06-28 15:27:41 +05:30
Kaushik B 92024df20e
Pt 1.9 breaking fix: __iter__ type hint (#7993) 2021-06-15 21:57:15 +00:00
Florian Müller-Fouarge d4d959b342
Call `super().__init__()` in `MilestonesFinetuning` example (#7398) 2021-05-06 21:11:36 +05:30
Mauricio Villegas 78a6fd5588
Example and documentation for LightningCLI linking model and data arguments (#7299)
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-05-03 20:45:46 +00:00
amisev 6b29211372
Fixed bug: replaced bce_loss_with_logits with bce_loss (#7096)
* Fixed bug: replaced bce_loss_with_logits with bec_loss

* Fixed bug: removed sigmoid activation from forward pass

* switched names for scores and logits

Co-authored-by: Alexey Misev <amisev@fb.com>
Co-authored-by: Alexey Misev <alexey@MacBook-Pro-Natalia.local>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-04-28 09:06:10 +00:00
Soham Roy 71b4611c64
Update default gym env version to CartPole-v1 (#7079)
Version v1 generates a better baseline with higher max_episodes and reward_threshold attained.

changed_params -->

register(
    id='CartPole-v1',
    entry_point='gym.envs.classic_control:CartPoleEnv',
    max_episode_steps=500,
    reward_threshold=475.0,
)
2021-04-18 12:28:04 +02:00
Jirka Borovec f2021ed225
docs: lightning-bolts (#6967) 2021-04-13 18:49:48 +00:00
Carlos Mocholí 6a7f011495
Reuse _TORCHVISION_AVAILABLE (#6976) 2021-04-13 18:33:32 +02:00
Jirka Borovec b341b53f70
deprecate metrics pkg (#6505)
* deprecate metrics

* examples

* req

* docs

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>

* pep8

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
2021-03-15 14:39:38 +00:00
Eric Cousineau e886d55ac1
argparse: Add use_argument_group=True (#6088)
* argparse: Add inplace option

Replicate in GAN model

* datamodule: Deduplicate logic w/ argparser utilities

* Update pl_examples/domain_templates/generative_adversarial_net.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>

* Keep docstrings

* Correct name

* Whitespace

* Consistency

* fix weird type stuff

* try alt - use_argument_group

* fix syntax + lint

* fix ci errs

* fix ci

* change examples... still failing w/ "unrecognized arguments: --batch_size"

* address review

* mnist_datamodule: add some docstrings

* argparse: check cls or cls.__init__ for param

didn't capture issue, but meh

* fix lint

* fix no-doc edge case

* address review

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-03-11 10:50:49 -05:00
Kaushik B 079fe9bc09
Hotfix for torchvision (#6476) 2021-03-11 16:49:48 +05:30
Jirka Borovec e84854264f
CI: fix examples - patch download MNIST (#6357)
* patch download

* CI

* isort

* extra
2021-03-05 16:50:21 +00:00
Adrian Wälchli bc577ca792
fix duplicate console logging bug v2 (#6275)
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-03-02 15:17:55 +05:30
Akihiro Nitta 5cf892b5f6
Fix typo (#6178) 2021-02-24 10:14:25 -05:00
chaton 141316fb29
[BugFix] Resolve bugs in computer_vision_fine_tuning.py example (#5985)
* update the script to use DataModule

* add message at for the frozen parameters

* add message about trainable parameters

* resolve flake8
2021-02-16 21:01:04 +00:00
Jihoon Lee d1200af358 fix model arguements (#5653) 2021-02-05 21:40:40 +01:00
chaton e425bf3ba9
[BugOnFeat] Resolve bug with Finetuning (#5744)
* resolve bug + add doc

* Update pytorch_lightning/callbacks/finetuning.py

* resolve bug

* start adding more test

* add more tests for finetuning callback functions

* rename to flatten_modules

* resolve doc

* Update pytorch_lightning/callbacks/finetuning.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* resolve comments

* remove update on BoringModel

* update on comments

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-02-04 18:36:54 +00:00
rohitgr7 a37416843b Fix sync
resolve wrong merge

tpu

yapf
2021-02-03 20:11:35 +01:00
Sidhant Sundrani 2b6738832b fix argparse conflicting options error (#5569)
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-02-03 19:41:46 +01:00
Sidhant Sundrani f72d93974c Fix command line run for refinforce_learn_qnet in pl_examples (#5414)
* fix wrong argument in argparse

* remove wrong default arg in argparser

* disable add help argparse
2021-02-03 19:41:46 +01:00
Jirka Borovec 21d313edc5
yapf examples (#5709) 2021-01-30 10:17:12 +00:00
Jirka Borovec 2846322f60
fix docs render (#5610) 2021-01-25 20:21:00 -05:00
Sidhant Sundrani b5e7e030d4
add promxial policy optimization template to pl_examples (#5394)
* add ppo rl lightning template

* flake

* import gym without try as in qnet example

* fix import format

* remove torch.optim import, not required

* fix import format isort

* add trainer argparse

* change name of trajectory collection method

* add repo in references

* fix typo in comments

* use isinstance to verify actionspace type

* use fstring

* deduplication of logic code

* rename unused forloop variable

* use pl.seed_everything instead

* remove unused numpy import

* format string printed on error

* fix typo in comments

Co-authored-by: chaton <thomas@grid.ai>
2021-01-09 12:49:11 -05:00
chaton 48718d7ce7
Feat: Add BackboneLambdaFinetunningCallback (#5377)
* Feat: Add BackboneLambdaFinetunningCallback

* update changelog

* resolve pep8 and update changelog

* add finetunning example

* resolve example

* iremove milestones from model

* iupdate

* update

* Update pytorch_lightning/callbacks/__init__.py

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>

* Update pytorch_lightning/callbacks/__init__.py

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>

* update

* add comments

* resolve test

* Update pytorch_lightning/callbacks/finetuning.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Update tests/trainer/logging/test_logger_connector.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* update on comments

* resolve merge

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-01-08 16:33:05 -05:00
Jirka Borovec beb8cacf1c fix formatting - flake8 + isort 2021-01-06 21:31:48 +01:00
J. Sebastian Paez 0e8ec93b28 black formatting and migrated to self.log logging in finetuning example (#5229)
* black formatting and migrated to self.log logging

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* migrated to accuracy in the metrics package

migrated to accuracy in the metrics package

* removed trailing whitespace

* Apply suggestions from code review

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
(cherry picked from commit 17a0784c5e)
2021-01-06 12:49:31 +01:00
Jirka Borovec 53b0cb910b update isort config (#5335)
* update isort config

* apply

(cherry picked from commit 724f1051f0)
2021-01-06 12:49:23 +01:00
Akihiro Nitta abc690d720 Apply isort to `pl_examples/` (#5291)
* Remove examples from isort ignore list

* Apply isort

(cherry picked from commit 0c7c9e8540)
2021-01-06 12:47:53 +01:00
Jirka Borovec 74d0652164 flake8 ++ 2021-01-05 09:58:37 +01:00
Jirka Borovec 2438d7459b add doctests for example 2/n segmentation (#5083)
* draft

* fix

* drop folder

Co-authored-by: chaton <thomas@grid.ai>
2021-01-05 09:58:37 +01:00
Jirka Borovec 518d915422 add doctests for example 1/n (#5079)
* define tests

* fix basic

* fix gans

* unet

* test

* drop

* format

* fix

* revert

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
2021-01-05 09:58:37 +01:00
Jirka Borovec 3b83666823 prune ecosystem example (#5085)
* draft

* wip

* CI

* drop pl geometry

* copy

* logo
2021-01-05 09:58:37 +01:00
Jirka Borovec 77fb425dd4
update usage of deprecated profiler (#5010)
* drop deprecated profiler

* lut

Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
2020-12-10 08:38:14 +01:00
Jirka Borovec 53d7c9555c
drop usage of deprecated distributed_backend (#5009)
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
2020-12-09 09:18:23 +01:00
Sean Naren ed5bda3eda
[docs] Added description of saving using ddp (#4660)
* Added description of saving using ddp

* Added code block example to explain DDP saving logic

* Fixed underline

* Added verbose explanation

* Apply suggestions from code review

* Added caveat when using custom saving functions

* flake8

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
2020-12-04 17:59:38 +01:00
Limber Cheng b807c3278d
Update to latest logging format and modify the accuracy method. (#4816)
* Update to latest logging format and modify the accuracy method.

* Apply suggestions from code review

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: chaton <thomas@grid.ai>
2020-12-04 15:30:51 +01:00
Lucien d3626b7f50
Organize docstring (#4906)
* Organize docstring

* Update pl_examples/domain_templates/reinforce_learn_Qnet.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: chaton <thomas@grid.ai>
2020-12-04 14:45:13 +01:00
brett koonce 4de568a545
tweak imagenet docs to match current script (#4895)
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
2020-11-30 09:54:55 +01:00
Lucien-cs ac3f1bd0da
Update reinforce_learn_Qnet.py (#4814)
Correct the text.

Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
2020-11-30 08:21:37 +01:00
Ludger Paehler 7c4356464c
Minor typo in the description of Adam's beta 2 (#4715)
Adam's beta 2 parameter was mistakenly referred to as the first order momentum of the gradient, whereas it should be the second order momentum. This has no effect on the correct working of the example.
2020-11-17 17:00:36 +01:00
Sahin Kureta 90bb7b1fbb
update examples (#4233)
* Removed image generation inside the training step.

It was overwriting the image grid generated in `on_epoch_end`. I also made `adversarial_loss` a static method.

* Incorporated Hyperparameter best practices

Using ArgumentParser and hparams as defined in the Hyperparameters section of
the documentation. This way we can set trainer flags (such as precision,
and gpus) from the command line.

* Incorporated Hyperparameter best practices

Using ArgumentParser and hparams as defined in the Hyperparameters section of
the documentation. This way we can set trainer flags (such as precision,
and gpus) from the command line.

* Split the data part into a LightningDataModule

* Update pl_examples/domain_templates/generative_adversarial_net.py

Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
2020-10-21 18:07:18 +02:00
Jirka Borovec 8873750cf0
remove deprecated early_stop_callback (#3982) 2020-10-08 06:30:33 -04:00
William Falcon 00ba2b24b7
Drop all result docs. Make the separation between flow and logging clear (#3744)
* remove results docs. separate flow from log
2020-09-30 08:31:16 -04:00
William Falcon 031274c25d
fix dp issues + update examples and test examples (#3618)
* fix dp

* fix dp

* fix dp

* fix dp

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples

* fix examples
2020-09-23 00:19:46 -04:00
Vasudev Gupta f22292c5f2
GANs in pl-examples updated for lightning-0.9 (#3152)
* gan updated for lightning-0.9

* bugs fixed
2020-08-25 11:05:03 -04:00