Commit Graph

7652 Commits

Author SHA1 Message Date
Laverne Henderson 692f0f3d5d
Resolve minor formatting issue (#14706) 2022-09-15 08:37:50 +00:00
Adrian Wälchli deca6cc5c4
Standalone Lite: DDP Strategy Family (#14670)
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2022-09-15 01:36:17 +00:00
Carlos Mocholí 98cf134bb3
Add the probot check-group action (#14621)
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2022-09-15 02:08:11 +02:00
Adrian Wälchli 8b3d6d8feb
Add easy access to `state_dict` in Lite module wrapper (#14629)
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2022-09-14 19:29:23 -04:00
Adrian Wälchli 7867d152b3
Standalone Lite: DataParallel Strategy (#14681)
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2022-09-14 19:27:53 -04:00
Benjamin Krala c2378bd3b1
Add documentation for trainer.datamodule and dataloaders of a trainer object (#14600)
* Update trainer.rst
* Update datamodule.rst
2022-09-14 15:46:34 +00:00
Adrian Wälchli 32cb774a5c
Standalone Lite: Single Device TPU Strategy (#14663)
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2022-09-14 14:22:07 +00:00
Manan Goel 48e783dd0d
Added support for downloading wandb artifacts in the WandbLogger (#14551)
* Added functions to the WandbLogger to download and use artifacts without having to access the experiment object
* Updated CHANGLELOG.md
* Added suggested changes
* Delete test_script

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: awaelchli <aedu.waelchli@gmail.com>
2022-09-14 14:11:52 +00:00
Adrian Wälchli 6333caabb0
Standalone Lite: Strategy base classes and registry (#14662)
* add accelerator implementations to lite

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix imports

* rename registry argument

* fix test

* fix tests

* remove duplicated test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix tests

* deprecation

* deprecations

* flake8

* fixes

* add mps to runif

* fix tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* remove more

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* local import

* undo device stats :(

* fix import

* stupid typehints

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* more refactors :(

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix

* rename init_device to setup_device

* remove unused import

* make uppercase to differentiate from class

* trick test after moving import locally

* add base classes and registry

* reg

* registry

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* tests

* update to other branches

* resolve todo(lite)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add very basic unit tests

* fix name assignment

* Update src/lightning_lite/strategies/parallel.py

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>

* remove deprecated property

* remove pre- and post backward for now

* protecting the registry utility function

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* remove unused import

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
2022-09-14 09:15:21 -04:00
Ritik Nandwal 8e9780bd5b
fix mypy typing errors in pytorch_lightning.utilities.data.py (#13901)
Co-authored-by: otaj <ota@lightning.ai>
2022-09-14 11:21:57 +00:00
Pritam Soni 9b01a0fd32
fix: e2e with short form after signup (#14689)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2022-09-14 10:52:55 +00:00
Carlos Mocholí 71dadb5307
Fix TPU CI for non-forks (#14688) 2022-09-14 16:32:07 +09:00
Sherin Thomas d579733b08
Lightning cloud client call with key word arguments (#14685) 2022-09-14 08:44:59 +02:00
Krishna Kalyan 14b36f8109
Fix incorrect imports in lightning docs (#14678) 2022-09-14 00:23:31 +02:00
dependabot[bot] f3736f642a
Update ipython[all] requirement from <8.4.1 to <8.5.1 in /requirements (#14671)
Updates the requirements on [ipython[all]](https://github.com/ipython/ipython) to permit the latest version.
- [Release notes](https://github.com/ipython/ipython/releases)
- [Commits](https://github.com/ipython/ipython/compare/rel-0.8.4...8.5.0)

---
updated-dependencies:
- dependency-name: ipython[all]
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-13 22:22:58 +00:00
Jerome Anand bc9dd1fb2a
Break hpu graphs into two for better performance (#14656)
Signed-off-by: Jerome <janand@habana.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
2022-09-14 00:21:47 +02:00
Jirka Borovec fcd1a8d8c1
CI: install more OS (#14660) 2022-09-13 14:03:49 -04:00
Carlos Mocholí 313c338da1
Remove legacy examples from logging docs (#14686) 2022-09-13 13:47:51 -04:00
Krishna Kalyan f68c0909fd
Fix mypy errors attributed to `pytorch_lightning.profilers.pytorch` (#14405)
* remove toml ref
* fix conflicts
* small fix
* move assertion

Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
2022-09-13 16:11:45 +00:00
thomas chaton c81a71c908
Lightning App Fixes from Training Studio App dev (#14532)
* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update
2022-09-13 11:43:15 -04:00
Laverne Henderson b24f5f164a
Content for Lightning with iOS and Android (#14038)
* Content for Lightning with iOS and Android

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* make link clickable

* Update docs/source-app/glossary/ios_and_android.rst

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: awaelchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2022-09-13 11:04:50 -04:00
otaj 616304831a
Remove deprecated `BaseProfiler` and `AbstractProfiler` (#14404)
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
2022-09-13 14:52:09 +00:00
thomas chaton 96cc288f53
(hot fix) Resolve Boring App (#14684)
* resolve_boring_app

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update
2022-09-13 10:50:36 -04:00
Pritam Soni 16b4644e06
feat: LAI2-10296 check if user has sufficient credits to run an app from the cli (#14285) 2022-09-13 19:19:09 +05:30
Akihiro Nitta fd99cb27f2
Update CODEOWNER of CI/CD (#14676)
Update CODEOWNER
2022-09-13 09:38:14 -04:00
Adrian Wälchli 19a1274093
Better error message when dataloader and datamodule is None (V2) (#14637) 2022-09-13 12:26:03 +00:00
Adrian Wälchli 1ee3d1eb72
Avoid warning when cloning tensor in self.log (#14599)
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2022-09-13 16:23:46 +05:30
Kushashwa Ravi Shrimali bdec502f50
Requirements: try Traitlets >= 5.3.0 (#14679)
* Traitlets >= 5.3.0
* Apply suggestions from code review

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2022-09-13 09:29:03 +00:00
Jirka Borovec 4b77adba64
CI: run CLI after install (#14659) 2022-09-13 11:45:32 +09:00
Dmitry Frolov 6e21f46fe8
[CLI] Move storage from app prefix to project/app prefix (#14583)
* Move storage from app prefix to project/app prefix: checking and legacy support

* Changelog message

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2022-09-12 20:11:00 -04:00
Adrian Wälchli 4bd135a6f6
Remove deprecated `LoggerCollection` (#14283)
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2022-09-12 21:46:46 +00:00
dependabot[bot] f73b31bf3c
Update traitlets requirement from <5.2.0 as strict in /requirements (#14666)
* Update traitlets requirement from <5.2.0 as strict in /requirements

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2022-09-12 20:18:26 +00:00
Max Ehrlich e5998e6bf2
Make the SLURM Preemption/Timeout Signal Configurable (#14626)
* Add parameter to change the preemption signal
* Make the signal connector use the custom signal from SLURMEnvironment

Signed-off-by: Max Ehrlich <max.ehr@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2022-09-12 19:24:35 +00:00
Adrian Wälchli 925edbca07
Remove the deprecated `weights_save_path` Trainer argument (#14424)
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2022-09-12 19:02:38 +00:00
dependabot[bot] 36f1949d25
Bump tj-actions/changed-files from 29.0.3 to 29.0.4 (#14650)
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 29.0.3 to 29.0.4.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](https://github.com/tj-actions/changed-files/compare/v29.0.3...v29.0.4)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-12 19:01:49 +00:00
thomas chaton 80e2f097e0
(app): Add load_state_dict and state_dict (#14100)
Co-authored-by: manskx <ahmed.mansy156@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
2022-09-12 18:29:23 +00:00
Mauricio Villegas 1680a76819
Removed from_argparse_args tests in test_cli.py (#14597) 2022-09-12 18:25:29 +00:00
dependabot[bot] 3d540efe4f
Update psutil requirement from <=5.9.1 to <5.9.3 in /requirements (#14665)
Updates the requirements on [psutil](https://github.com/giampaolo/psutil) to permit the latest version.
- [Release notes](https://github.com/giampaolo/psutil/releases)
- [Changelog](https://github.com/giampaolo/psutil/blob/master/HISTORY.rst)
- [Commits](https://github.com/giampaolo/psutil/compare/release-0.1.0...release-5.9.2)

---
updated-dependencies:
- dependency-name: psutil
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-12 23:48:51 +05:30
dependabot[bot] a7f3837081
Update docutils requirement from <0.19,>=0.16 to >=0.16,<0.20 in /requirements (#14664)
Update docutils requirement in /requirements

Updates the requirements on [docutils](https://docutils.sourceforge.io/) to permit the latest version.

---
updated-dependencies:
- dependency-name: docutils
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-12 23:48:35 +05:30
Akihiro Nitta 92309c2153
Remove skipping logic in PL CI (#14565)
Drop skipping logic
2022-09-12 18:13:27 +00:00
Noha Alon 9769f57fc6
Removes timeout from streamlit e2e test (#14667)
* Removes timeout from streamlit e2e test
We have a timeout on the app view which waits for the button but it causes a refresh on the page which causes playwright to miss the button on each refresh.
we can remove the timeout altogether since we have a time limit on the test itself in the CI setup

Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2022-09-12 18:00:46 +00:00
Adrian Wälchli 4f3c47294e
Add troubleshooting section to MPS docs (#14642)
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
2022-09-12 17:35:18 +00:00
donlapark f49c2e3ab6
fixes mypy errors in trainer/supporters.py (#14633)
* fixes mypy errors in trainer/supporters.py
* Fxes mypy error when accessing "__init__" directly
* add an assertion in lr_finder.py
* Make init calls `reset` in `TensorRunningAccum`
* Fixes formatting
* Add `self.window_length` to `__init__`

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2022-09-12 19:13:58 +02:00
Mauricio Villegas cd671243ab
Fix mypy errors in pytorch_lightning/cli.py (#14653) 2022-09-12 19:10:34 +02:00
thomas chaton b679fc2922
(app) Resolve a bug where the state changes isn't detected properly (#14465)
Co-authored-by: Mansy <ahmed.mansy156@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2022-09-12 16:54:14 +00:00
Adrian Wälchli d013bcc5bf
Standalone Lite: Accelerators (#14578)
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2022-09-12 16:00:14 +00:00
Jirka Borovec 3b39c7eb9c
set next App dev (#14609) 2022-09-12 15:58:18 +00:00
Carlos Mocholí dfa570ef9f
Run CircleCI with the HEAD sha, not the base (#14625)
* Run CircleCI with the HEAD sha, not the base
* Different solution
2022-09-12 11:25:54 -04:00
Adrian Wälchli 85ada5191d
Standalone Lite: Precision Plugins (#14547)
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
2022-09-12 10:47:44 -04:00
thomas chaton 86fd5b22d4
(app) Make Logging DEBUG mode lazy (#14464) 2022-09-12 14:47:24 +00:00