Rooba
/
lightning
mirror of https://github.com/Lightning-AI/lightning.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
5,037 Commits 59 Branches 217 Tags 356 MiB
Commit Graph

5037 Commits

Author SHA1 Message Date
Jirka Borovec 15be986558
add logger to __all__ (#6854) 2021-06-09 13:07:02 +00:00
ananthsub 6fee9262ff
Deprecate `LightningDataModule` lifecycle properties (#7657) 
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
 2021-06-09 12:30:40 +00:00
Adrian Wälchli 764d2c775e
refactor CheckpointConnector.restore_weights (#7862) 2021-06-09 09:55:08 +00:00
Kaushik B 7f4ef6d135
Fix logs overwriting issue for remote fs (#7889) 
* Fix logs overwriting issue for remote fs

* Add test
 2021-06-09 11:05:01 +02:00
Carlos Mocholí c310ce661e
Logger connector re-design `_Metadata.reduce_fx` fixes. (#7890) 2021-06-09 01:21:01 -07:00
Carlos Mocholí b214442e74
New logger connector code (#7882) 
* New logger connector code

* Update CHANGELOG

* Update requirements

* Fix import path

* Add new suffix

* Tests

* Minor changes

* Rename and reorder

* Fix import

* Formatting

* Fix with seed_everything?

* Fix test?

* Fix test?

* Minor change

* Minor changes

* Minor changes

* Force float

* Fix minimal bug

* Fix minimal bug

* Update with latest changes

* Fix import

* bad merge

* update typing

Co-authored-by: tchaton <thomas@grid.ai>
 2021-06-08 20:20:17 +00:00
Carlos Mocholí b74f8ac149
Use `apply_to_collection` in `metrics_to_scalars` (#7888) 
* Use `apply_to_collection` in `metrics_to_scalars`

* Typing

* Update CHANGELOG

* Update pytorch_lightning/utilities/metrics.py

* Whitespace
 2021-06-08 12:54:32 -04:00
Jirka Borovec 0fda862274
Refactor notebooks (#7752) 
* drop notebooks

* add submodule

* copy notebooks

* docs include ipynb

* fix headers

* CI

* readthedocs

* manifest

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* req

* workdir

* pandoc

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* pandoc

* manifest

* Apply suggestions from code review

* fix versions

* checkout

* `git submodule update --init --recursive --remote`

* notebooks @docs

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
 2021-06-08 16:30:13 +00:00
Jirka Borovec 4f3af42f83
better use of void (#7809) 
* use void

* format
 2021-06-08 15:36:50 +00:00
Carlos Mocholí 5593b6f772
Merge pull request #7872 from PyTorchLightning/refactor/logger-poc-changes 
Random fixes for logger connector PoC
 2021-06-08 09:04:16 -04:00
Carlos Mocholí 9d315be4df
Only track dev debugger events if enabled (#7875) 2021-06-08 12:11:20 +00:00
Carlos Mocholí 8cc55ebdb0
Add `log_grad_norm` hook to `LightningModule` (#7873) 2021-06-08 12:09:06 +01:00
Luis Perez f9fccdfb39
Move `training_output` validation to after `train_step_end` (#7868) 
* move validation to after aggregation

* changelog

* add test for training_step_end

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
 2021-06-08 08:37:50 +00:00
Carlos Mocholí 3427cb728d
Stricter `FxValidator` and add hooks (#7874) 
* Stricter FxValidator and add hooks

* Update CHANGELOG
 2021-06-08 08:26:05 +01:00
Adrian Wälchli ce976769ef
update fsspec to 2021.06.0 (#7869) 2021-06-08 05:05:19 +05:30
Adrian Wälchli 20f37b85b6
add warning when Trainer(log_every_n_steps) not well chosen (#7734) 
* add warning

* update changelog

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* logger check

* add docstring for test

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
 2021-06-07 12:40:43 +00:00
Sean Naren 41be61c6f2
[IPU] Add hooks for IPU lifecycle 4/5 (#7864) 2021-06-07 12:06:41 +00:00
thomas chaton ea71cf4a5f
[Test] Add extra test for val_check_interval in distributed scenario (#7863) 
* add extra test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add computation

* Update docs/source/common/trainer.rst

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Update docs/source/common/trainer.rst

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Update tests/trainer/test_dataloaders.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* use tmpdir

* update on comments

* update

* Update tests/callbacks/test_progress_bar.py

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
 2021-06-07 10:37:32 +00:00
Sean Naren 6388c29e87
[IPU] Add reset dataloader hooks to training type plugin 3/n (#7861) 
* Add hooks

* Add tests for hooks

* Add changelog

* Test changes, add typing
 2021-06-07 10:37:09 +00:00
thomas chaton d1becce4c1
[bugfix] Resolve LearningRateMonitor + BackboneFinetuning (#7835) 
* add test + resolve bug

* update changelog

* resolve bug

* resolve bug

* Update pytorch_lightning/callbacks/lr_monitor.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Update pytorch_lightning/callbacks/lr_monitor.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* update on comments

* resolve comments

* update

* Update tests/callbacks/test_lr_monitor.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Update pytorch_lightning/callbacks/lr_monitor.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
 2021-06-07 10:17:11 +00:00
Adrian Wälchli 0be863e00e
make Trainer.resume_from_checkpoint a read-only property (#7857) 2021-06-07 09:57:59 +00:00
Adrian Wälchli 8c32bf2dd4
refactor on_gpu handling in checkpoint connector (#7860) 2021-06-07 11:30:22 +02:00
Adrian Wälchli acd38dd406
update docs example with sharded eval step (#7748) 
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
 2021-06-07 09:49:41 +01:00
Luis Perez 009e05d14f
[bugfix] Minor improvements to `apply_to_collection` and type signature of `log_dict` (#7851) 
* minor fixeS

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
 2021-06-07 09:31:36 +01:00
Adrian Wälchli cfd01d7f8d
move amp checkpoint state management to precision plugin (#7831) 2021-06-07 07:45:01 +00:00
Ruotian(RT) Luo dff1047851
Fix an incorrect CHANGELOG link (#7850) 2021-06-06 23:57:23 +00:00
Jirka Borovec 7b531ac7ac
Fix NVIDIA docker versions (#7834) 2021-06-06 23:56:27 +02:00
Guillaume Tauzin 1da1898d41
[docs] Fix truncated_bptt_steps docs (#7846) 2021-06-06 18:31:14 +00:00
Sean Naren 10839376e2
[IPU] Add special tests for IPUs 2/n (#7833) 
* Add special tests for IPUs, run nvprof only if cuda available

* Add missing min_gpu
 2021-06-04 23:23:09 +05:30
Sean Naren 7c7182d334
[IPU] Call accelerator hooks regardless if LM hook overridden 1/n (#7826) 
* Modify API to ensure hooks defined in the accelerator are called as expected

* handle step_end in dp

* Add changelog

* Update pytorch_lightning/trainer/trainer.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Add todo and explanation

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
 2021-06-04 16:19:08 +00:00
thomas chaton 51d370f4c2
[doc] Move each profiler to its own file + Add missing PyTorchProfiler to the doc (#7822) 2021-06-04 21:08:29 +05:30
Justus Schock 6a0d503693
Add warning to trainstep output (#7779) 
* Update training_loop.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update test_training_loop.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update test_training_loop.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update training_loop.py

* Update pytorch_lightning/trainer/training_loop.py

Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>

* Update test_training_loop.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update training_loop.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update pytorch_lightning/trainer/training_loop.py

Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>

* Update training_loop.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update test_training_loop.py

* Update training_loop.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* escape regex

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
 2021-06-04 08:34:39 -07:00
shuyingsunshine21 ca89a7f344
[sharded plugin] Fix check for fp16 precision (#7825) 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
 2021-06-04 08:34:39 +02:00
Mauricio Villegas f34584001c
Fix support for torch Module type hints in LightningCLI (#7807) 
* Fixed support for torch Module type hints in LightningCLI

* - Fix issue with serializing values when type hint is Any.
- Run unit test only on newer torchvision versions in which the base class is Module.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Minor change

* Update CHANGELOG.md

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
 2021-06-04 07:43:43 +02:00
Adrian Wälchli 36770b22fd
validate manual optimization and supported features before running training (#7788) 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
 2021-06-03 08:42:37 -07:00
Aniket Maurya 0bad2186c1
Added Vulture dead code checker (#5654) 
* integrated vulture CI

* added vulture in workflows

* added vulture in workflows

* vulture logs verbose set false

* Apply suggestions from code review

* ignore name list and args to underscore naming

* add ignore names

* deadcode whitelist

* deadcode whitelist

* Apply suggestions from code review

Co-authored-by: Rahul Jha <rahul722j@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update whitelist

* Sort

* Updates

* Updates

* Apply suggestions from code review

* Updates

Co-authored-by: Aniket Maurya <aniket.maurya@gdn-commerce.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Rahul Jha <rahul722j@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
 2021-06-02 16:19:10 +01:00
Sean Naren 0a72fd2284
Add FSDP docs (#7791) 
* Add FSDP docs

* Address reviews

* Add note about how FSDP can replace pipe parallelism

* Add import

* Remove sentence
 2021-06-02 09:52:48 +00:00
Kaushik B e4ba06c70f
Replace deprecated distributed_backend by acc in examples (#7795) 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
 2021-06-02 07:43:24 +02:00
Ethan Harris 03bb389b21
Fix double precision + ddp_spawn (#6924) 
* Initial fix

* Initial fix

* Initial fix

* Updates

* Updates

* Update typing and docs

* Undo accidental refactor

* Remove unused imports

* Add DDP double precision test

* Remove unused variable

* Update CHANGELOG.md

* Fix test

* Update tests

* Formatting

* Revert bad change

* Add back changes

* Correct wrapping order

* Improve unwrapping

* Correct wrapping order

* Fix... finally

* Respond to comments

* Drop ddp test

* Simplify ddp spawn test

* Simplify ddp spawn test

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2021-06-01 15:21:17 +00:00
Carlos Mocholí 195b24ba51
`apply_to_collection` improvements and add `apply_to_collections` (#7769) 
* `apply_to_collection` improvements and add `apply_to_collections`

* Update CHANGELOG

* Minor fix

* Minor fix

* Remove attr

* Swap is first is None

* None test

* OrderedDict support

* flake8

* Fix docstring
 2021-06-01 12:09:20 +00:00
Carlos Mocholí 1dd61e4e35
Extend support for logging a collection (#7771) 2021-06-01 12:51:50 +01:00
Jirka Borovec 9a001fea22
update NGC docker (#7787) 2021-06-01 12:11:29 +02:00
Jirka Borovec 0b6fd1da54
Update pre-commit and add new hooks (#7781) 
* update precommit

* Update .pre-commit-config.yaml

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
 2021-06-01 07:43:50 +02:00
Carlos Mocholí 0dd6d3a798
Avoid adding `None` loss values in `training_epoch_end` (#7772) 2021-05-31 19:28:28 +00:00
Adrian Wälchli 7e6010fc93
fix info message when max training time reached (#7780) 
* call time_elapsed

* elapsed formatting

* format

* update test

* changelog
 2021-05-31 14:50:16 +02:00
Carlos Mocholí d47173bb72
Use typing forward references (#7770) 
* Use typing forward references

* Update pytorch_lightning/core/lightning.py
 2021-05-31 09:54:28 +02:00
Carlos Mocholí a69beab499
Clean existing logging tests (#7760) 
* Remove dev debugger metric tracking

* Fix tests

* Fix test

* Import

* Clean logging tests

* flake8

* Docstring
 2021-05-30 16:36:52 +02:00
Carlos Mocholí fa8f0363ee
Some test updates (#7761) 
* Some test updates

* flake8
 2021-05-30 13:15:25 +02:00
Carlos Mocholí 5f0863e5e5
Organize trainer properties (#7758) 
* Organize trainer properties

* Single quote

* Double quote
 2021-05-30 13:09:01 +02:00
Carlos Mocholí bc3238be8c
Remove metric tracking from dev debugger (#7759) 
* Remove dev debugger metric tracking

* Fix tests

* Fix test

* Import

* Fix tests

* Fix test

* flake8

* Fix tests
 2021-05-30 12:03:42 +02:00