Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
pokecrystal/engine/events
History
SnorlaxMonster b9dce73573
Rename `MON_ID` to `MON_OT_ID` (#1114) 
* Rename MON_ID to MON_TRAINER_ID

The constant name MON_ID implies it relates to the ID number of the
Pokémon itself. However, it actually refers to the Trainer ID number of
the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it
substantially more clear what its purpose is.

The original definition of MON_ID is preserved in macros/legacy.asm

* Remove MON_ID from macros/legacy.asm

Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>

* Apply rename to missed file

* Rename to `MON_OT_ID`

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
 		2024-04-27 12:16:34 -05:00
..
battle_tower In labels, stick to Place for text without delay, and Print for text with letter delay (#1078) 2024-01-07 14:06:40 +01:00
bug_contest Improve some innacurate function names, labels, and comments (#1078) 2024-01-07 13:36:05 +01:00
pokerus Clean up some percentage values 2020-05-07 14:21:24 -04:00
basement_key.asm Rename some call/jump script commands to avoid confusion with jr/jp asm instructions 2019-03-10 16:39:31 -04:00
buena.asm Identify some wMenuJoypad-related button constants 2022-03-09 19:42:26 -05:00
buena_menu.asm Use labels instead of constants for HRAM 2018-08-25 14:28:22 -04:00
card_key.asm Rename some call/jump script commands to avoid confusion with jr/jp asm instructions 2019-03-10 16:39:31 -04:00
catch_tutorial.asm Use ~X instead of $ff ^ X 2021-11-23 20:37:18 -05:00
catch_tutorial_input.asm Remove all address comments 2018-06-24 16:13:22 +02:00
celebi.asm Rename wVramState to wStateFlags and use flag constants (#1078) 2024-01-07 14:27:22 +01:00
checkforhiddenitems.asm Rename GetFarHalfword to GetFarWord 2021-01-09 15:16:05 -05:00
checksave.asm Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM) 2020-06-17 17:03:38 -04:00
checktime.asm Remove all address comments 2018-06-24 16:13:22 +02:00
daycare.asm Rename `MON_ID` to `MON_OT_ID` (#1114) 2024-04-27 12:16:34 -05:00
diploma.asm Improve some innacurate function names, labels, and comments (#1078) 2024-01-07 13:36:05 +01:00
dratini.asm Remove even more address comments 2018-06-25 02:10:37 +02:00
elevator.asm Identify scrolling menu lists in WRAM 2021-03-08 09:41:55 -05:00
engine_flags.asm Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
field_moves.asm Rename wVramState to wStateFlags and use flag constants (#1078) 2024-01-07 14:27:22 +01:00
fish.asm Miscellaneous label and comment corrections 2019-11-03 14:47:06 -05:00
fishing_gfx.asm Use labels instead of constants for HRAM 2018-08-25 14:28:22 -04:00
forced_movement.asm Rename more script commands for consistency and predictability 2019-03-10 16:00:19 -04:00
fruit_trees.asm Clear however many bytes are needed for wFruitTreeFlags 2022-02-14 17:28:08 -05:00
haircut.asm Clean up bugs commented in the source code (#912) 2022-07-09 16:12:02 -05:00
halloffame.asm Rename `MON_ID` to `MON_OT_ID` (#1114) 2024-04-27 12:16:34 -05:00
happiness_egg.asm Rename some labels 2020-12-23 16:29:30 -05:00
heal_machine_anim.asm wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
hidden_item.asm Split up engine/events/misc_scripts_2.asm 2020-02-13 18:31:10 +01:00
itemfinder.asm more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap (#1078) 2024-01-07 14:37:46 +01:00
kurt.asm Rename some labels 2020-12-23 16:29:30 -05:00
kurt_selectquantity_interpretjoypad.asm Remove all address comments 2018-06-24 16:13:22 +02:00
lucky_number.asm Rename `MON_ID` to `MON_OT_ID` (#1114) 2024-04-27 12:16:34 -05:00
magikarp.asm Rename `MON_ID` to `MON_OT_ID` (#1114) 2024-04-27 12:16:34 -05:00
magnet_train.asm Sync sprite and battle anim consts/labels (#1055) 2023-09-17 13:09:28 -05:00
map_name_sign.asm Replace "¯" and "%" (breakable whitespace) with more meaningful charmap names (#1094) 2023-11-19 20:04:45 -05:00
misc_scripts.asm Rename some labels 2020-12-23 16:29:30 -05:00
mom.asm In labels, stick to Place for text without delay, and Print for text with letter delay (#1078) 2024-01-07 14:06:40 +01:00
mom_phone.asm Improve some innacurate function names, labels, and comments (#1078) 2024-01-07 13:36:28 +01:00
money.asm Fix triple newlines left over from removing address comments 2018-06-24 23:22:50 -04:00
move_deleter.asm Rename some labels 2020-12-23 16:29:30 -05:00
move_tutor.asm Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
name_rater.asm Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
npc_trade.asm Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
odd_egg.asm Some Mobile code labeling and removed magic numbers (#993) 2022-09-14 19:49:58 -05:00
overworld.asm Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission (#1078) 2024-01-07 14:51:27 +01:00
play_slow_cry.asm Remove all address comments 2018-06-24 16:13:22 +02:00
poisonstep.asm Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
poisonstep_pals.asm Resolve some "???" comments 2020-11-17 11:09:02 -05:00
poke_seer.asm Rename `MON_ID` to `MON_OT_ID` (#1114) 2024-04-27 12:16:34 -05:00
pokecenter_pc.asm Improve some innacurate function names, labels, and comments (#1078) 2024-01-07 13:36:05 +01:00
pokepic.asm Improve some innacurate function names, labels, and comments (#1078) 2024-01-07 13:36:05 +01:00
print_photo.asm #641 fixes and additions. (#646) 2019-10-20 18:24:17 -04:00
print_unown.asm Improve some innacurate function names, labels, and comments (#1078) 2024-01-07 13:36:05 +01:00
print_unown_2.asm Use rgbds 0.5.0 2021-04-19 16:31:37 -04:00
prof_oaks_pc.asm Identify the remaining (non-mobile) uses of another WRAM union 2020-10-29 14:51:41 -04:00
repel.asm Split up engine/events/misc_scripts_2.asm 2020-02-13 18:31:10 +01:00
sacred_ash.asm more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap (#1078) 2024-01-07 14:37:46 +01:00
shuckle.asm RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
specials.asm Rename some labels 2020-12-23 16:29:30 -05:00
squirtbottle.asm more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap (#1078) 2024-01-07 14:37:46 +01:00
std_collision.asm Create data/collision/ for tile collision-related data 2020-10-27 10:00:56 -04:00
std_scripts.asm Refer to "Rival", not "Silver" (#983) 2022-08-10 21:24:56 -04:00
sweet_scent.asm Address PR suggestions (#1078) 2024-01-28 21:19:32 +01:00
trainer_scripts.asm Rename some call/jump script commands to avoid confusion with jr/jp asm instructions 2019-03-10 16:39:31 -04:00
treemons.asm Identify more uses of wBuffer1-6 2020-11-03 19:53:07 -05:00
unown_walls.asm Standardize on lowercase Tilemap and Attrmap 2020-02-13 18:31:10 +01:00
whiteout.asm more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap (#1078) 2024-01-07 14:37:46 +01:00