Commit Graph

4209 Commits

Author SHA1 Message Date
mid-kid b92b91df17 Adapt `tmhm` for consistency
Using an underscore before macro variables avoids cluttering up the
global namespace. While this isn't much of a problem right now, it's
good practice that'll keep us from problems in the future.
2018-11-11 00:50:53 +01:00
mid-kid 056cd5e871 Clarify LEGACY support 2018-11-11 00:44:07 +01:00
mid-kid 814a720e9d Adapt macro based on suggestions 2018-11-11 00:32:05 +01:00
mid-kid 375963349a Finish new connection macro
Tried simplifying things a bit, although not nearly as much as I wanted.
Ideally, we'd either have one of two situations:
- A single set of calculations based on values depending on the
direction of the connection
- A bunch of "generic" calculations done before applying simple
modifiers to them in the final `if` block

Right now it's an icky mix of both and I'm not really sure what to make
of it.
2018-11-10 14:34:49 +01:00
mid-kid abb9454307 Make the `connection` macro simpler to use
It now only takes one numerical parameter, which is the offset of the
target map relative to the source map, much like in AdvancedMap. This
makes it easier to make connections and avoids having to calculate these
values by hand, and/or "mess with the values 'till it works", as many
have been doing thus far. It's just one, easy-to-understand value.

To convert from the old macro to the new macro, just take the fourth and
the fifth parameter, and calculate `<4th_param> - <5th_param>`. The
result is the value required for the new macro.
2018-11-06 21:19:07 +01:00
Rangi 0ce8dd75cd gfx/roofs/*.png filenames match ROOF_* constants 2018-10-31 17:46:18 -04:00
Rangi 45f70b24d1
Merge pull request #571 from Rangi42/master
Apply SPRITE_GFX_LIST_CAPACITY to wUsedSprites
2018-10-27 20:24:49 -04:00
Rangi 81b147609c Apply SPRITE_GFX_LIST_CAPACITY to wUsedSprites 2018-10-27 20:21:00 -04:00
Rangi 31ec3365e9 NUM_OBJECTS EQU $10 → 16 2018-10-23 18:29:14 -04:00
luckytyphlosion edf96c3754
Update Discord link. 2018-10-22 22:18:31 -04:00
Rangi f39a3dff9c
Merge pull request #569 from Rangi42/master
Identify BATTLEACTION_D and _E (thanks, ax6)
2018-10-21 00:58:16 -04:00
Rangi 3b20a18200 Identify BATTLEACTION_D and _E (thanks, ax6) 2018-10-21 00:52:10 -04:00
Rangi 12666e3c70
Merge pull request #568 from mid-kid/master
ゴロゴロ
2018-10-21 00:36:06 -04:00
mid-kid f52f20edb7 Rename CheckTrainerBattle
Renamed to be more in line with our current coding standards. Hopefully
this is slightly more readable.
2018-10-11 11:39:09 +02:00
mid-kid e68713d20e Stop using __enum__ + 3
Abuse __enumdir__ instead, for better readability.
2018-10-11 11:39:09 +02:00
mid-kid da14ba8041 Add more savegame stuff to gitignore 2018-10-11 11:39:09 +02:00
IIMarckus 603524b489 This event isn't Crystal-exclusive. 2018-10-03 00:53:04 -06:00
luckytyphlosion c323f9ddd1
Merge pull request #566 from luckytyphlosion/master
Refactor .gitattributes and .gitignore
2018-09-23 14:14:54 -04:00
luckytyphlosion 0e30519bd4 Lowercase *.md 2018-09-23 14:03:55 -04:00
luckytyphlosion 4ab1ee8920 Add make tidy and remove bitmask.asm and frames.asm in make clean 2018-09-23 13:44:23 -04:00
Rangi 3624d83d4c
Merge pull request #567 from Rangi42/master
Identifying more labels and constants
2018-09-23 12:02:22 -04:00
Rangi 2e7e5ca67b PREDEFPAL_4D -> PREDEFPAL_GAMEFREAK_LOGO_OB 2018-09-22 13:40:37 -04:00
Rangi 3d6c7a464b
Merge pull request #565 from Rangi42/master
Identify some Spaceworld beta content
2018-09-22 12:44:57 -04:00
Rangi 38bf21ae35 Naming screen constants 2018-09-22 12:39:17 -04:00
luckytyphlosion 850ef245f3 Fix toc.py line endings (for travis-ci) 2018-09-20 11:32:53 -04:00
luckytyphlosion d6c44f0ca4 Remove *.pal from gitignore, remove more build objects with make clean. 2018-09-20 11:17:05 -04:00
luckytyphlosion 0a2eabd59a Refactor .gitattributes and .gitignore 2018-09-19 21:49:10 -04:00
Rangi 60b09f291d Merge branch 'master' of https://github.com/pret/pokecrystal 2018-09-16 13:42:17 -04:00
Rangi 03cb8c53f1 Identify some Spaceworld beta content 2018-09-16 13:40:47 -04:00
Rangi 1564896060
Merge pull request #564 from mid-kid/master
abloobloobloobloobloo
2018-09-16 13:34:20 -04:00
mid-kid 42ff2bd21f This isn't actually PAL_BG_ROOF
My bad.
2018-09-16 03:00:25 +02:00
mid-kid 3540b2a2d6 wMonStatusFlags -> wDebugFlags 2018-09-16 02:15:55 +02:00
mid-kid 387107b29e Fix use of in LoadMansionPalette 2018-09-16 01:52:14 +02:00
Rangi 4d7e1bec40
Merge pull request #563 from Rangi42/master
Graphics-related edits
2018-09-09 18:29:38 -04:00
Rangi f9cf53ecba Use existing bigdw macro 2018-09-09 18:25:43 -04:00
Rangi 3241c9cfaa Use 0/1/2/3 for palettes, and rgbds opt feature for battle transition graphic 2018-09-09 18:15:54 -04:00
Rangi 8c435054a0
Merge pull request #562 from Rangi42/master
Curr → Cur
2018-09-09 17:41:58 -04:00
Rangi bb4a6e5f55 wCursorCurTile -> wCursorCurrentTile 2018-09-09 17:15:49 -04:00
Rangi 603bcfe2ae wPreviousLandmark → wPrevLandmark 2018-09-09 15:27:23 -04:00
Rangi 14a2ea835e Remove redundant comments 2018-09-09 15:15:33 -04:00
Rangi 9ee2b59208 hMultiplicand is four bytes internally, but the high byte is always 0 since allowing four-byte multiplicands could overflow hProduct. 2018-09-09 15:10:38 -04:00
Rangi ae022e1420 Curr -> Cur 2018-09-09 15:09:51 -04:00
Rangi 84cfbc70fa
Merge pull request #561 from Rangi42/master
Revise documentation
2018-09-08 12:42:17 -04:00
Rangi 741d22907e Empty rules are unnecessary (error messages are fine without them) 2018-09-08 12:33:52 -04:00
Rangi 140a065b7a Don't repeat the pokecrystal instructions 2018-09-01 23:53:39 -04:00
Rangi d67ef7efd5 Clarify about rgbds 0.3.7 compatibility 2018-09-01 23:02:24 -04:00
Rangi cd169aec3c Revise documentation
All the INSTALL.md sections have similar structure
2018-09-01 21:53:05 -04:00
Rangi 963026695d
Merge pull request #560 from Rangi42/master
Fix #537: Palettes generated from PNGs use .gbcpal directly.
2018-09-01 20:58:23 -04:00
Rangi 83b5aa356f
Merge pull request #559 from mid-kid/master
Clarify INSTALL.md
2018-09-01 20:58:06 -04:00
Rangi 075a3bcad0 Consistently use "rgbgfx += -h" 2018-09-01 20:30:42 -04:00