Commit Graph

1354 Commits

Author SHA1 Message Date
vulcandth a4d346cc8c
Improved Virtual Console patch identifiers (#907) 2022-06-06 17:22:48 -04:00
Konrad Borowski 6e3f2a47bd Remove Heavy Ball never happens comment
It's not correct as Snorlax weights more than 409.6 kg.
2022-05-26 19:56:07 +00:00
Idain dc121712fe
Fix misspelled label (#904) 2022-04-17 11:36:30 -04:00
vulcandth f9077c6db6
Additional vc_asserts (#906) 2022-04-16 20:42:06 -04:00
Idain b06cfe78fd Use NUM_BATTLE_STATS instead of raw numbers 2022-04-06 10:28:18 +00:00
mid-kid 1d97d41ea2 Tile constant makes more sense as negative 2022-04-05 21:22:46 +02:00
vulcandth af7d328d66 Cleanup Magic Numbers 2022-04-05 19:14:39 +00:00
Idain 9b4ebe9400
Replace magic numbers with constants (#894) 2022-03-20 19:58:18 -04:00
Rangi f33a041930 Allow alternate labels for patch names 2022-03-12 22:38:29 -05:00
vulcandth 31c3c94d64
Build the Virtual Console patch with `make crystal11_vc` (#882)
Fixes #813
2022-03-12 18:34:04 -05:00
Rangi 3a562f9896 Identify some wMenuJoypad-related button constants 2022-03-09 19:42:26 -05:00
Rangi 2910b9a6c2 Rename `GetPokedexEntryBank` to `HeavyBall_GetDexEntryBank` 2022-02-22 17:11:33 -05:00
Idain d0c8f63f25
Rename ENGINE_FISH_SWARM to ENGINE_QWILFISH_SWARM (#879) 2022-02-22 09:47:05 -05:00
mid-kid 418b73bc6d Use constants for PartyAttr in move_effects/thief.asm 2022-02-15 18:30:57 +01:00
Rangi e56a9f7962 Clear however many bytes are needed for wFruitTreeFlags 2022-02-14 17:28:08 -05:00
Idain e949477089
Document Return/Frustration bug and its fix (#872)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-01-24 20:48:21 -05:00
Rangi 20dc31115e Use `VRAM_End` in place of `sScratch` 2022-01-20 20:16:22 -05:00
Rangi 0ffdb65210 Better comments for enemy health percentage code 2022-01-10 21:25:43 -05:00
Idain 5ac4a51751
Use time constants more often (#867) 2022-01-10 20:57:40 -05:00
Idain 67207fab94
Identify why five of six enemy mon base stats are copied (#866)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-01-08 13:42:40 -05:00
Rangi 69185e1657 Identify some overworld movement data 2021-12-22 21:38:26 -05:00
Rangi e706b878d9 Use ~X instead of $ff ^ X 2021-11-23 20:37:18 -05:00
Rangi ab0f9c287a Use compound assignment operators 2021-11-23 20:18:08 -05:00
Rangi 39111486ab Fix #845: Liz gossips about a beautiful trainer, not Pokémon 2021-11-03 17:24:16 -04:00
Rangi 187b120007 Add assertions to some more tables 2021-10-24 18:28:54 -04:00
Rangi d4a6a1b2bc Add table assertions to slot machine data 2021-10-15 22:15:00 -04:00
Rangi bd45cfd5fd Add `assert PokemonPicPointers == UnownPicPointers` in `GetFrontpicPointer` 2021-10-06 17:44:34 -04:00
Rangi fb2a95afed `and 50 percent` -> `and %011111111` 2021-09-07 19:18:22 -04:00
IIMarckus a283f44954 More EFFECTIVEness. 2021-08-16 14:44:57 -06:00
IIMarckus 52290d8e03 Use EFFECTIVE constant for 1.0× battle damage. 2021-08-16 14:42:45 -06:00
Rangi d93c13c94c Identify more palettes in CBG layouts 2021-07-19 18:59:16 -04:00
Nescientist 80a3f7e1ba
Fixing comments in BattleCommand_Teleport 2021-06-20 10:56:11 -04:00
Rangi f59f1bdb88 Standardize capitalization of ".Jumptable" 2021-06-19 19:52:05 -04:00
TheFakeMateo 7a03fecc38 Fix incorrectly swapped Players PC menu constants 2021-06-09 19:31:54 -04:00
Rangi e4d82e92d0 Rename `prioritysjump` to `sdefer` 2021-06-08 20:35:04 -04:00
Rangi 1f9e688b76 MON_PKRUS -> MON_POKERUS 2021-06-07 20:00:21 -04:00
Rangi a41dac9a2f "ld [MON_LEVEL], a" in ComputeNPCTrademonStats should be "ld [wCurPartyLevel], a" 2021-06-07 19:36:03 -04:00
Rangi e140e88b7b Add more comments to tileset palette animation functions 2021-05-30 23:32:03 -04:00
Rangi ed0a0f7159 Move the dbbw, dbww, and dbwww macros to legacy 2021-05-30 15:51:49 -04:00
Rangi b1dbadbdd3 Require rgbds 0.5.1
Use some new features: \<10> macro args, SECTION UNION, SIZEOF/STARTOF, and CHARLEN/CHARSUB
2021-05-09 12:26:28 -04:00
Rangi efd1006917
Use {interpolation} to generate sequences of RAM labels
This makes the table_width/assert_table_length usages unnecessary, and also keeps the labels automatically up to date if the length constants change.
2021-04-27 12:11:39 -04:00
Rangi c5f9e25cc4 SPECIAL -> UNUSED_TYPES_END 2021-04-26 12:00:16 -04:00
Rangi 316fa4b695 Use rgbds 0.5.0 2021-04-19 16:31:37 -04:00
Rangi 2fe0cbbb19 Add some comments regarding 16-bit increment/decrement 2021-03-24 18:34:33 -04:00
Rangi dc18e188b2 Sync some files with pokegold 2021-03-24 10:24:52 -04:00
Rangi 8bf76af5a7 Consistent comments in the tileset animation engine 2021-03-23 20:47:32 -04:00
Rangi dbe2360ecd Miscellaneous cleanup 2021-03-22 16:41:17 -04:00
Rangi 8daf8fe19c The radio's "Places & People" does not comment on Mysticalman Eusine 2021-03-21 21:07:45 -04:00
Rangi 90ce126139 Use numeric constants in text strings with "{d:interpolation}" 2021-03-21 18:14:31 -04:00
Rangi 0506e5b1b9 Assert the sBox1-14 tables have NUM_BOXES entries 2021-03-21 17:47:53 -04:00