Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
5,050 Commits 2 Branches 0 Tags 170 MiB
Commit Graph

320 Commits

Author SHA1 Message Date
Andrew Cook 0f5540740b
Some Mobile code labeling and removed magic numbers (#993) 
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
 2022-09-14 19:49:58 -05:00
Rangi 41d5ea0482
Rename the `object_struct` field labels and constants (#1005) 
Fixes #990
 2022-09-12 09:15:44 -04:00
vulcandth 4c239a6f65
Rename `macros/wram.asm` to `macros/ram.asm` (#1003) 2022-09-11 01:05:07 -04:00
vulcandth 8ed7c392cd Fix order of parameters in dsprite macro 
The parameters of the legacy dsprite macros were in the wrong order.
Fixes #1002

Co-Authored-By: Idain <54337884+Idain@users.noreply.github.com>
Co-Authored-By: Fredrik Ljungdahl <fredde1994@gmail.com>
 2022-09-07 19:25:20 -05:00
Rangi 8826d97ee4
Define scene constants alongside scene_scripts (#979) 
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
 2022-07-29 17:43:10 -04:00
Rangi a2e8f078a4 Split "gfx anims" into "pic anims" and "sprite anims" 
Fixes #876
 2022-07-04 01:11:42 -04:00
vulcandth 3648afda16
RGBDS syntax updates (#905) 
New MACRO and DEF syntax
 2022-06-06 17:25:42 -04:00
Rangi 4d102dcb3f Allow `vc_const` to work with charmap characters (necessary for pokegold) 2022-03-13 23:21:27 -04:00
vulcandth 31c3c94d64
Build the Virtual Console patch with `make crystal11_vc` (#882) 
Fixes #813
 2022-03-12 18:34:04 -05:00
Rangi 418c70a8af Don't require a boolean trainer flag for `givepoke` 
Fixes #865
 2022-01-10 21:16:34 -05:00
Rangi ab0f9c287a Use compound assignment operators 2021-11-23 20:18:08 -05:00
Rangi 860585b0af Clarify documentation of maskbits 2021-10-29 17:33:52 -04:00
Rangi e4d82e92d0 Rename `prioritysjump` to `sdefer` 2021-06-08 20:35:04 -04:00
Rangi ed0a0f7159 Move the dbbw, dbww, and dbwww macros to legacy 2021-05-30 15:51:49 -04:00
Rangi b1dbadbdd3 Require rgbds 0.5.1 
Use some new features: \<10> macro args, SECTION UNION, SIZEOF/STARTOF, and CHARLEN/CHARSUB
 2021-05-09 12:26:28 -04:00
Rangi efd1006917
Use {interpolation} to generate sequences of RAM labels 
This makes the table_width/assert_table_length usages unnecessary, and also keeps the labels automatically up to date if the length constants change.
 2021-04-27 12:11:39 -04:00
Rangi 316fa4b695 Use rgbds 0.5.0 2021-04-19 16:31:37 -04:00
Rangi 94057c7726 Verify uneven list sizes with list_start, li, and assert_list_length macros 
This was discussed in #815
 2021-03-22 17:17:08 -04:00
Rangi dbe2360ecd Miscellaneous cleanup 2021-03-22 16:41:17 -04:00
Rangi 5037adc55f Clean up some macro definitions 2021-03-21 20:09:34 -04:00
Rangi 4522162d45 Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
Rangi d132a20b7a Verify script command table sizes 2021-03-11 16:28:52 -05:00
Rangi 98da09b3e9 Define more struct offset constants with rsreset instead of const_def 
This was discussed in #739
 2021-03-04 18:15:38 -05:00
Rangi ef20126fe5 Verify wild data sizes with def_grass/water_wildmons and end_grass/water_wildmons macros 2021-03-04 17:58:30 -05:00
Rangi 40902ffe24 Verify data table sizes with table_width and assert_table_length macros 
This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
 2021-03-04 00:15:03 -05:00
Rangi 99e66c2557 Rename some labels 
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"

Fixes #789
 2020-12-23 16:29:30 -05:00
Rangi e485280a8a Require rgbds 0.4.2 
This allows [\1] to work when \1 is hl, bc, or de

The object file format has changed along with the version number
 2020-12-09 12:21:46 -05:00
Rangi 03e149e559 Identify wBattleAnimTemp0-3 2020-11-09 15:05:14 -05:00
Rangi ba5bc304f9 Updates to more closely sync with pokegold 2020-10-29 23:23:57 -04:00
Rangi c85ba78b77 Use more assertions to ensure correct code and data 2020-10-26 22:24:38 -04:00
Rangi ae4fe08084 Identify some more labels (a few link-related) 2020-10-22 00:53:54 -04:00
mid-kid d39da49501 Modify macros/wram.asm to match recent renames 2020-08-27 13:59:33 +02:00
mid-kid 6f30d79620 TX_NUM -> TX_DECIMAL 2020-08-03 23:35:18 +02:00
Rangi dcb24bc724 Use def_* macros for automatic map event counts 
Resolves #742
 2020-07-24 09:57:16 -04:00
Rangi 11dc805de0 Revert "Factor out tables into data/overworld/" 
This reverts commit b5a7e7de3e.
 2020-07-22 20:21:26 -04:00
Rangi b5a7e7de3e Factor out tables into data/overworld/ 
Fixes #749
 2020-07-22 15:22:58 -04:00
Rangi 212846af57 Treat map setup commands like trade script commands 
Fixes #736
 2020-07-22 13:37:43 -04:00
Rangi de073374a6 Port pokered's more local system for trade animation scripts 
Also factor out trade tilemaps
 2020-07-17 16:53:22 -04:00
Rangi ef452ccbc7 return → endcallback, reloadandreturn → reloadend 2020-07-17 08:37:03 -04:00
Rangi eca33ef190 Define map setup commands as macros like other script commands 2020-07-13 20:44:16 -04:00
Rangi c086de0c98 Use const_skip and const_next macros for brevity 2020-07-10 20:03:46 -04:00
Rangi 6ca82e5c86 Eliminate enum: use const instead, with case-by-case parallel const implementations 2020-07-08 15:30:23 -04:00
Rangi b3bd682366 text_linkpromptbutton -> text_waitbutton 
Removes support for text_waitbutton as a legacy alias for text_promptbutton.
 2020-07-06 12:55:31 -04:00
Rangi 26d764de5d Use STRCMP, not ==, to compare multi-character strings 2020-07-02 11:46:30 -04:00
Rangi fce6243b43 Identify more labels, and use the jumptable macro when possible 2020-07-01 13:13:49 -04:00
Rangi f2efda1f68 Identify more unnamed labels 2020-06-29 12:25:58 -04:00
Rangi 98af69691d Remove some more raw addresses 2020-06-21 12:21:47 -04:00
Rangi cbd43001ce sound_duty became duty_cycle_pattern 2020-06-19 22:25:19 -04:00
Rangi c552390a15 Harmonize home/ with pokegold 2020-06-16 15:49:32 -04:00
Rangi b9f2b93c17 Harmonize some more symbols with pokegold 2020-06-16 11:28:52 -04:00