Commit Graph

4381 Commits

Author SHA1 Message Date
Rangi 4fe0d93d4c Fix some of the issues explained in #595 2019-01-27 14:00:21 -05:00
Rangi 9ecc991814
Merge pull request #593 from mid-kid/temp
More patches
2019-01-24 21:42:44 -05:00
Rangi 79ea091ff6 Use and define more WRAM constants 2019-01-24 21:41:14 -05:00
Rangi 68d4a53483 Use more constants 2019-01-24 21:15:30 -05:00
Rangi 84b6a084cb Keep "paragraphs" of related code together 2019-01-24 21:10:45 -05:00
Rangi a5c1d9572c Fix: Clair can give TM24 Dragonbreath twice 2019-01-19 19:27:45 -05:00
Rangi 53c92b4792 Bug: Clair can give TM24 Dragonbreath twice 2019-01-19 19:11:38 -05:00
mid-kid e288ef20d5 Fix map name frame calculation 2019-01-18 16:17:50 +01:00
mid-kid 0390728d44 Fix constants used with startbattle 2019-01-15 13:37:22 +01:00
mid-kid a21507f22a Document wSuicuneFrame
Also fixed inmediate in PlaceMapNameFrame.FillTopBottom to calculate the
amount of loops required. (It fills two tiles in the first iteration,
and four in the remaining, hence the `-2` and `+1` part).
2019-01-15 13:08:40 +01:00
mid-kid 5f60cc24cf Fix some constants
Glass ting SFX were added in crystal.
PicAnimations and UnownAnimations are expected to be in the same bank as
their pointers, because the pointers are not BANK()-referenced
separately.
2019-01-15 13:06:16 +01:00
Rangi 1853e3d127 Say "BANK(Foo) ; aka BANK(Bar)" to clarify that Foo and Bar share a bank 2019-01-12 15:17:20 -05:00
Rangi 07374f02cc Dif formatting typo 2019-01-07 19:36:56 -05:00
Rangi fe04acad7b Document bugfix: ScriptCall can overflow wScriptStack and crash 2019-01-07 18:28:47 -05:00
Rangi 1b1b0ac6ea Document a bugfix: AI makes a false assumption about CheckTypeMatchup 2019-01-07 18:12:00 -05:00
Rangi 26fc7e2521 Consistent formatting in Function_SetEnemyMonAndSendOutAnimation and BattleStartMessage 2019-01-06 22:11:57 -05:00
Rangi 5207615cdc Document a bugfix: 1/256 failure rate for 100% effect chance 2019-01-05 20:30:46 -05:00
Rangi 3650232398
Merge pull request #590 from Rangi42/master
Clean up some Odd Egg and Battle Tower code and data
2019-01-03 19:00:46 -05:00
Rangi 36ebcdd8fe MON_NAME_LENGTH -> NAME_LENGTH 2019-01-03 07:30:44 -05:00
Rangi b975f3e068 Clean up some Odd Egg and Battle Tower code and data
Fixes #589
2019-01-02 19:04:50 -05:00
mid-kid f04f31ea85 Add travis webhook for unnamed.py
(still requires setup)
2019-01-01 12:13:54 +01:00
mid-kid 9fde0912c3 unnamed.py: Add completion percentage
People love percentages. Gotta show our powerlevel.
2019-01-01 11:41:48 +01:00
Rangi 583838a39d Make tools/gfx.py executable 2018-12-31 18:55:35 -05:00
mid-kid 3b97a15ea3 Add tool to find unnamed symbols
This tool should help us identify which are the symbols that still need
proper names, and in which files they're located.
2019-01-01 00:28:51 +01:00
Rangi 9f82304186
Merge pull request #587 from Rangi42/master
Remove dependency on 'extras' submodule
2018-12-31 18:26:33 -05:00
Rangi cae3af3e3a Keep the most relevant data at the top of the Makefile (the built filenames) 2018-12-31 18:08:37 -05:00
Rangi 742df4fdb5 Remove the 'extras' submodule 2018-12-31 17:20:28 -05:00
Rangi e3bc378492 Keep gfx.py with other tools, and remove its dependency on the 'extras' submodule 2018-12-31 17:17:55 -05:00
Rangi 4259e7051e
Merge pull request #585 from Rangi42/master
Refactor engine/phone/
2018-12-31 16:35:13 -05:00
Rangi afbf1b3ffc *PhoneScript1 -> *PhoneCalleeScript, and *PhoneScript2 -> *PhoneCallerScript 2018-12-31 16:32:04 -05:00
Rangi f2785cdb71 Use battle menu flags 2018-12-31 14:25:53 -05:00
Rangi 8f60de5aba Fix a typo 2018-12-31 01:03:38 -05:00
Rangi 22657f6078 Split generic phone caller+callee text into individual NPCs 2018-12-30 19:20:45 -05:00
Rangi d3e0eda398 Distinguish "caller" and "called" phone scripts+text (NPCs call you automatically, you call them from the Pokégear) 2018-12-30 18:05:26 -05:00
Rangi 059e0df298 $56 is "<……>" 2018-12-30 17:57:56 -05:00
Rangi b921e9c9be Split engine/phone/phone_scripts.asm and phone_gossip.asm into individual files 2018-12-30 17:15:52 -05:00
Rangi 378667d9ec
Merge pull request #584 from mid-kid/master
Fix comments around BANK() statements
2018-12-30 11:07:50 -05:00
Rangi f7ce402d2a
Merge pull request #583 from melthelesbian/rgbds_environment_config
allow setting RGBASM/etc in environment vars
2018-12-30 11:07:40 -05:00
mid-kid 930d285fab Fix comments around BANK() statements
Found a couple BANK()s that reference multiple labels.
2018-12-26 21:58:13 +01:00
Melody 97e04cfa33 finish renaming RGBDS_DIR to RGBDS 2018-12-25 15:52:36 -05:00
Melody 2471f1ea71 rename RGBDS_DIR to RGBDS 2018-12-25 15:45:03 -05:00
Melody 7e4b956978 allow setting RGBDS_DIR 2018-12-25 15:13:57 -05:00
Melody 4eb935eb5a allow setting RGBASM in environment vars 2018-12-25 14:48:44 -05:00
Rangi 0ae5e9b398 Define RANDY_OT_ID 2018-12-23 14:02:07 -05:00
Rangi f6ecb681d5 Fix issue #581 (random stuff ax6 noticed) 2018-12-23 03:45:41 -05:00
Rangi 83ff516c82
Merge pull request #579 from Rangi42/master
Miscellaneous
2018-12-16 14:19:06 -05:00
Rangi e51339f01a Formatting and comments 2018-12-09 18:13:37 -05:00
Rangi 4b4c53c7ae Format music macros like movement macros 2018-12-09 17:56:13 -05:00
Rangi e025ab9db0
Merge pull request #578 from mid-kid/master
Fixes in the animation subsystem.
2018-12-09 17:44:09 -05:00
mid-kid fd1fa78ffe Update docs/battle_anim_commands.md 2018-11-26 00:12:23 +01:00