Commit Graph

244 Commits

Author SHA1 Message Date
Idain bc4fec0694
Fix AI_Smart_Rage comment (#988) 2022-08-21 22:39:08 -05:00
Rangi 07e8efee7e Fix some whitespace 2022-08-07 00:38:08 -04:00
Colton G. Rushton 145d8dd5c2
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
vulcandth ef9b9bb437
Clean up bugs commented in the source code (#912)
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-07-09 16:12:02 -05:00
vulcandth 5f0597e944
Rename `SLP` to `SLP_MASK` (#918)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:56 -04:00
vulcandth 73c020074e
Remove redundant comments referencing labels (#921) 2022-06-06 17:34:54 -04:00
vulcandth 3648afda16
RGBDS syntax updates (#905)
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
vulcandth a4d346cc8c
Improved Virtual Console patch identifiers (#907) 2022-06-06 17:22:48 -04:00
Idain b06cfe78fd Use NUM_BATTLE_STATS instead of raw numbers 2022-04-06 10:28:18 +00:00
vulcandth 31c3c94d64
Build the Virtual Console patch with `make crystal11_vc` (#882)
Fixes #813
2022-03-12 18:34:04 -05:00
mid-kid 418b73bc6d Use constants for PartyAttr in move_effects/thief.asm 2022-02-15 18:30:57 +01:00
Idain e949477089
Document Return/Frustration bug and its fix (#872)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-01-24 20:48:21 -05:00
Rangi 0ffdb65210 Better comments for enemy health percentage code 2022-01-10 21:25:43 -05:00
Idain 67207fab94
Identify why five of six enemy mon base stats are copied (#866)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-01-08 13:42:40 -05:00
Rangi e706b878d9 Use ~X instead of $ff ^ X 2021-11-23 20:37:18 -05:00
IIMarckus a283f44954 More EFFECTIVEness. 2021-08-16 14:44:57 -06:00
IIMarckus 52290d8e03 Use EFFECTIVE constant for 1.0× battle damage. 2021-08-16 14:42:45 -06:00
Nescientist 80a3f7e1ba
Fixing comments in BattleCommand_Teleport 2021-06-20 10:56:11 -04:00
Rangi 1f9e688b76 MON_PKRUS -> MON_POKERUS 2021-06-07 20:00:21 -04:00
Rangi efd1006917
Use {interpolation} to generate sequences of RAM labels
This makes the table_width/assert_table_length usages unnecessary, and also keeps the labels automatically up to date if the length constants change.
2021-04-27 12:11:39 -04:00
Rangi c5f9e25cc4 SPECIAL -> UNUSED_TYPES_END 2021-04-26 12:00:16 -04:00
Rangi dbe2360ecd Miscellaneous cleanup 2021-03-22 16:41:17 -04:00
Rangi 4522162d45 Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
Rangi ec1fe073a3 $11 = wTempMonStructEnd - wTempMonLevel 2021-03-15 15:40:48 -04:00
Rangi 40902ffe24 Verify data table sizes with table_width and assert_table_length macros
This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi 4264d53eb6 Identify some more labels 2021-02-05 12:44:21 -05:00
Rangi 7d3ea88611 Rename GetFarHalfword to GetFarWord
Fixes #796
2021-01-09 15:16:05 -05:00
Rangi 5db892782a Remove "Buffer" suffix from two HRAM labels 2020-12-23 16:54:28 -05:00
Rangi 99e66c2557 Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"

Fixes #789
2020-12-23 16:29:30 -05:00
Rangi 9fea403be2 grey -> gray 2020-12-08 14:34:54 -05:00
Rangi 4ef556cbc8 Document AI_Smart_Conversion2 bug (resolves #786) 2020-12-07 13:13:03 -05:00
Rangi 4613bcfadf Use STRING_BUFFER_LENGTH for the wStringBuffers 2020-11-24 20:11:17 -05:00
Rangi 9b3c45b14d Resolve some "???" comments 2020-11-17 11:09:02 -05:00
Rangi 6a5edc98e9 Terser damage calculation constants 2020-11-09 16:12:19 -05:00
Rangi 7254c10093 Identify remaining uses of wBuffer1-6 as general-purpose HP buffers or mobile 2020-11-03 23:25:22 -05:00
Rangi 9f62d7911b Identify some more uses of wBuffer1-6 2020-11-03 22:45:12 -05:00
Rangi c88c4a8340 Identify more uses of wBuffer1-6 2020-11-03 19:53:07 -05:00
Rangi 826e070f04 More syncing with pokegold 2020-11-03 10:13:06 -05:00
Rangi 6220200f0f Identify some more labels, and make some more consistent 2020-11-01 12:36:38 -05:00
Rangi ba5bc304f9 Updates to more closely sync with pokegold 2020-10-29 23:23:57 -04:00
Rangi bcc0d633e9 Identify the remaining (non-mobile) uses of another WRAM union 2020-10-29 14:51:41 -04:00
Rangi ea426a8879 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:34:38 -04:00
Rangi 6d333bed5f Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:10 -04:00
Rangi c85ba78b77 Use more assertions to ensure correct code and data 2020-10-26 22:24:38 -04:00
Rangi 9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
Rangi bd3f634049 Identify remaining map object labels 2020-10-22 21:30:21 -04:00
Rangi ae4fe08084 Identify some more labels (a few link-related) 2020-10-22 00:53:54 -04:00
Rangi 650686476c Identify remaining battle AI labels 2020-10-21 21:34:18 -04:00
Rangi 93dcc8b6eb Identify SwitchItemsInBag labels
Thanks to FIQ for having done so in Polished Crystal
2020-10-21 15:39:15 -04:00
Rangi 7b12060e6a Battle transition spin quadrants are like pokered's half circles 2020-10-19 20:27:19 -04:00