Rooba
/
lightning
mirror of https://github.com/Lightning-AI/lightning.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,959 Commits 55 Branches 212 Tags 384 MiB
Commit Graph

3959 Commits

Author SHA1 Message Date
Carlos Mocholí 0327f6b4c2
Do not warn when the name key is used in the lr_scheduler dict (#5057) 
* Do not warn when the name key is used

* Missing line

* Consistency

* Update pytorch_lightning/callbacks/lr_monitor.py

* Update docs

* Update pytorch_lightning/core/lightning.py

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* Update CHANGELOG

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
 2020-12-14 08:38:10 +01:00
tarepan 16feb5137b
Refactor load in checkpoint connector (#4593) 
* Refactor load step commentaries

* Refactor hpc ckpt suffix acquisition

* Refactor restore/hpc_load match

* Refactor hpc load trial

* Refactor checkpoint dir check

* Refactor unneeded function nest

* Refactor nested If

* Refactor duplicated cache clear

* Refactor attempt flow with if/elif

* Fix pip8

* Refactor hook commentary

Co-authored-by: chaton <thomas@grid.ai>

* Fix pep8

* Refactor hpc load checkpoint path acquisition

* Fix pip8

* Fix doc

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* Refactor None Union type with Optional

Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
 2020-12-14 00:13:50 +08:00
Carlos Mocholí 398f122a42
Improve some tests (#5049) 
* Improve some tests

* Add TrainerState asserts

Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
 2020-12-13 23:04:16 +08:00
Jirka Borovec a49291d98d
drop unused test with result api (#5058) 
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
 2020-12-12 21:51:19 +05:30
Jirka Borovec b50ad9ee95
split tests for deprecated api (#5071) 
* imports

* imports

* flake8

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
 2020-12-12 20:25:11 +05:30
Rohit Gupta 3100b7839a
Allow any input in to_onnx and to_torchscript (#4378) 
* branch merge

* sample

* update with valid input tensors

* pep

* pathlib

* Updated with BoringModel and added more input types

* try fix

* pep

* skip test with torch < 1.4

* fix test

* Apply suggestions from code review

* update tests

* Allow any input in to_onnx and to_torchscript

* Update tests/models/test_torchscript.py

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* no_grad

* try fix random failing test

* rm example_input_array

* rm example_input_array

Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
 2020-12-12 18:17:03 +08:00
Roger Shieh b5a2afd232
Remove beta arg from F1 class and functional (#5076) 
* remove beta from F1

* remove from functional

Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
 2020-12-12 15:14:17 +08:00
Roger Shieh 0de43d1cb6
Fix docs metrics formatting (#5077) 
* fix functional f1 fbeta formatting

* Update f_beta.py

* remove line breaks

* Update f_beta.py

add line breaks and pad

* pad linea breaks with 2 spaces instead of tab
 2020-12-12 14:23:55 +08:00
skhiuk d38e4d12af
fix: MNIST minor bug (#5075) 
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
 2020-12-12 13:00:32 +08:00
edenlightning 5f34f2b049
Update installation instructions for FairScale (#5099) 
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2020-12-12 02:42:04 +01:00
Jirka Borovec 63fb7f9510
CI: upload report only on failer (#5086) 
* CI: upload report only on failer

* Apply suggestions from code review

Co-authored-by: chaton <thomas@grid.ai>

* Apply suggestions from code review

Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
 2020-12-12 00:17:19 +01:00
Jirka Borovec 1e501f0f40
add back compatibility for deprecated metrics 2/n (#5068) 
* add back compatibility for deprecated metrics

* fix

* imports

* imports
 2020-12-11 22:56:19 +01:00
Jirka Borovec 4a3f9069cb
add back compatibility for deprecated metrics 1/n (#5067) 
* add back compatibility for metrics

* tests

* Add deprecated metric utility functions back to functional (#5062)

* add back *deprecated* metric utility functions to functional

* pep

* pep

* suggestions

* move

Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>

* more

* fix

* import

* docs

* tests

* fix

Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
 2020-12-11 22:11:21 +01:00
chaton ddc3757309
Pre release (#5098) 
* add rc release

* update changelog

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
 2020-12-11 15:21:25 -05:00
chaton 1a970b2d8d
[hotfix] Extend Optimizer + update doc (#5095) 
* resolve urgent bug

* update pr

* update doc

* update

* remove typo

* add defaults

* Update pytorch_lightning/__init__.py

* Update setup.py

* update doc

* Update docs/source/optimizers.rst

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* update

* resolve doc

* debug test

* update test

* Update docs/source/optimizers.rst

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* Update docs/source/optimizers.rst

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* Update docs/source/optimizers.rst

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* remove useless import

* Update docs/source/optimizers.rst

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
 2020-12-11 14:24:59 -05:00
Jirka Borovec 74171efadf
drop duplicate metrics (#5014) 
* drop duplicate metrics

* keep

* fix
 2020-12-11 18:42:53 +01:00
chaton 7755572b4f
Check if optimizer supports closure (#4981) 
* check if optimizer support closure

* cleanup test

* resolve tests

* resolve flake

* update test due to patch limit

* update

* update dep

* Update tests/core/test_lightning_optimizer.py

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* Update tests/core/test_lightning_optimizer.py

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* resolve bug

* update test

* resolve tests

* Update requirements/extra.txt

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* remove bolts dep

* remove bolts

* add missing bolts dep for tests

* remove need for bolts

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2020-12-11 14:51:45 +01:00
Rohit Gupta 4e6a871710
Added CHANGELOG section (#5065) 2020-12-11 15:07:32 +05:30
Alan Du 7e8673debd
Update DDP docs (#5046) 
* Fix flake8 error to fix CI

* Correct weights-loading to use correct callbacks

* Fix dangling links

Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2020-12-10 18:26:02 +01:00
chaton 2c3d43dcb5
Initialize trainer with None in DDPAccelerator (#4915) 
* Initialize trainer with None

* add typing to all accelerators

* resolve imports

* update

* add typing

* removed typo

* update

* Fix formatting and imports in accelerator

Co-authored-by: maxjeblick <maxjeblick@users.noreply.github.com>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
Co-authored-by: SeanNaren <sean@grid.ai>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
 2020-12-10 15:24:44 +01:00
Jirka Borovec d5fa02e798
simplify accelerator steps (#5015) 
* simplify accelerator steps

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
 2020-12-10 18:36:13 +05:30
Hemil Desai 820d5c7348
Add a notebook example to reach a quick baseline of ~94% accuracy on CIFAR (#4818) 
* Add a notebook example to reach a quick baseline of ~94% accuracy on CIFAR10 using Resnet in Lightning

* Remove outputs

* PR Feedback

* some changes

* some more changes

Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: rohitgr7 <rohitgr1998@gmail.com>
 2020-12-10 16:26:18 +05:30
Jirka Borovec 4ebce38478
update usage of deprecated automatic_optimization (#5011) 
* drop deprecated usage automatic_optimization

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
 2020-12-10 15:31:33 +05:30
Jirka Borovec 77fb425dd4
update usage of deprecated profiler (#5010) 
* drop deprecated profiler

* lut

Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
 2020-12-10 08:38:14 +01:00
Jirka Borovec cdbddbe99f
release 1.1.0 (#5048) 
* release 1.1.0

* pep8
 2020-12-10 00:52:39 +00:00
Jirka Borovec 05f25f3a54
update usage of deprecated checkpoint_callback (#5006) 
* drop usage of deprecated checkpoint_callback

* fix

* fix
 2020-12-09 14:14:34 -05:00
Jirka Borovec ce9179591d
ref: clean config [1/n] add intermediate setters (#4990) 
* add intermediate setters

* show inputs

* fix options

* move

* fix

* less talk

* fix

* talk less

* str

* cases

* rename

Co-authored-by: chaton <thomas@grid.ai>
 2020-12-09 14:13:57 -05:00
Francisco J. H. Heras 068502f07c
Loss format from .3f to .3g in the tqdm (#4972) 
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2020-12-09 14:13:13 -05:00
Rohit Gupta bcbba3b702
Simplify GPU and TPU accelerator (#5024) 2020-12-09 14:12:44 -05:00
Jirka Borovec 90d1d9fa73
drop deprecated reorder from AUC (#5004) 
* drop deprecated reorder from AUC

* chlog

* fix

* fix

* simple

* fix

* fix

* fix

Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
 2020-12-09 18:05:12 +00:00
chaton 20b806a945
[feat] 3/n pp (#5036) 
* add pp doc

* udpate doc

* update doc

* update doc

* Update docs

* update doc

* udpate

* update doc

* update doc

* Formatting, update sharded zip link

* Update docs/source/multi_gpu.rst

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Apply suggestions from code review

* Reference directly to section

Co-authored-by: SeanNaren <sean@grid.ai>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2020-12-09 16:31:18 +00:00
Carlos Mocholí 69725adb74
Add carmocca to core (#5038) 
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2020-12-09 16:48:46 +01:00
Jirka Borovec cff2489c6a
fix GH release badges (#5040) 
* fix GH release badges

* rtd
 2020-12-09 15:53:49 +01:00
chaton ef8ef12fd0
[feat] pp 2/n (#5026) 
* Added changes for RPC plugin

* Add missing kwargs

* Fix code format

* Loading refactors by introducing is_distributed var, fix optimizer step flow

* Add rpc guard

* Added docstrings and typing

* resolve comments

* Add additional rpc hook, refactor name of exit process hook for clarity

* remove annotation

* Modify behaviour to allow optional return, add test for rpc plugin

* resolve tests

* rename is_ddp_based

* update

* update for windows

* update

* resolve test

* code smell

* Added sequential plugin

* resolve bug

* update

* cleanup

* add Exception

* resolve docs

* Remove ddp support

* Revert distributed -> ddp

* Update pl_examples/basic_examples/conv_sequential_example.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Update pl_examples/basic_examples/conv_sequential_example.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Address code review points

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Add missing return

* Fix formatting, add datamodule args

* add small comment

* resolve comments

* resolve comments

* update source for fairscale

* update extras

* remove staticmethod

* resolve flake8

* Skip tests that are failing due to bug upstream with multiple optimizers and shard

* update

* update on comments

* clean test

* latest comments

* remove old comments

* add todo

* Update version

* update

* resolve bugs

* resolve bugs

* update test

* remove hanging test

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* resolve on comments

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* resolve on comments

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Update pytorch_lightning/plugins/ddp_sequential_plugin.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* remove ImportError

Co-authored-by: SeanNaren <sean@grid.ai>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
 2020-12-09 12:56:51 +00:00
Jirka Borovec 7d9784e951
adding missing changelogs (#5019) 
* adding missing changelogs

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
 2020-12-09 11:53:37 +00:00
Jirka Borovec 6a99d95d60
fix ci: release (#5037) 2020-12-09 11:53:22 +01:00
Jirka Borovec e2c404bad2
CI: update badges for release (#5002) 
* fix images

* not sleep

* a0

* path

* assets

* assets

* bitecode

* rls

* rls

* badges

* fix

* org

* drop

* clean

* codecov

* fix

* clean
 2020-12-09 10:59:44 +01:00
Jirka Borovec 53d7c9555c
drop usage of deprecated distributed_backend (#5009) 
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
 2020-12-09 09:18:23 +01:00
Jirka Borovec 2c11d96012
replace pyright by mypy (#5021) 
* drop pyright & add mypy

* detail

* name

* fix

* flake8

* ver

Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
 2020-12-09 10:57:11 +08:00
Ananya Harsh Jha 127454ade2
All gatherwith grads (#5012) 
* all_gather

* ddp

* horovod

* grad tests

* fixed ddp

* ddp fixed, removed tpu, horovod for now

* changelog

* windows fix

* windows fix

* removed batch from ctx

* all_gather

* ddp

* horovod

* grad tests

* fixed ddp

* ddp fixed, removed tpu, horovod for now

* changelog

* windows fix

* windows fix

* removed batch from ctx

* removed code duplication

* merge

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2020-12-08 23:20:01 +00:00
Sean Naren ee9b3fe574
[feat] pp 1/n (#5016) 
* Added changes for RPC plugin

* Add missing kwargs

* Fix code format

* Loading refactors by introducing is_distributed var, fix optimizer step flow

* Add rpc guard

* Added docstrings and typing

* resolve comments

* Add additional rpc hook, refactor name of exit process hook for clarity

* remove annotation

* Modify behaviour to allow optional return, add test for rpc plugin

* resolve tests

* rename is_ddp_based

* update

* update for windows

* update

* resolve test

* code smell

* Revert back to init_ddp_connection for backwards compat

* Swap to explicit name for property

* Add missing speed parity increase for CI variability, fix call counts for child process

Co-authored-by: tchaton <thomas@grid.ai>
 2020-12-08 22:02:10 +00:00
brett koonce ddd3eda26f
docs: minor spelling tweaks (#5022) 2020-12-08 16:27:43 -05:00
Rohit Gupta 6d2aeff26a
fast_dev_run can be int (#4629) 
* fast_dev_run can be int

* pep

* chlog

* add check and update docs

* logging with fdr

* update docs

* suggestions

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* fdr flush logs

* update trainer.fast_dev_run

* codefactor and pre-commit isort

* tmp

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
 2020-12-09 01:37:53 +05:30
maxjeblick 79ae66d026
Initialize trainer with None (#4847) 
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
 2020-12-08 22:49:55 +05:30
Cookie_thief aeaa6b2d4f
Add experiment_key argument to online mode example (#4997) 
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
 2020-12-08 16:08:04 +05:30
Rohit Gupta cb28f79c50
remove irrelevant docs in optimizer_step (#4964) 
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2020-12-08 14:27:14 +05:30
chaton 2393474350
[hotfix] ddp + manual_optimisation (#4976) 
* Rely on ddp plugin for blocking sync behaviour, and skip if we're using manual optimization

* debug

* Revert "debug"

This reverts commit ccca6b6b

* Expose manual reduce for automatic optimization

* Add input arguments

* Enable parity test

* clean imports

* Expose hook after to ensure we reset

* Fix naming

* add

* fix test

* resolve on comments

* typo

* Update tests/trainer/optimization/test_manual_optimization.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Update tests/trainer/optimization/test_manual_optimization.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* update on comments

* resolve comments

Co-authored-by: SeanNaren <sean@grid.ai>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2020-12-07 19:31:54 +00:00
Sean Naren 68ba4931f0
shard doc improvements (#4993) 
* Rewording

* Update fairscale install link to include bucket fix, add benchmark results

* Added percentage gain

* Address codereview

* Update docs/source/multi_gpu.rst

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Update multi_gpu.rst

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
 2020-12-07 18:01:59 +00:00
Tadej Svetina fedc0d1360
Classification metrics overhaul: input formatting standardization (1/n) (#4837) 
* Add stuff

* Change metrics documentation layout

* Change testing utils

* Replace len(*.shape) with *.ndim

* More descriptive error message for input formatting

* Replace movedim with permute

* Style changes in error messages

* More error message style improvements

* Fix typo in docs

* Add more descriptive variable names in utils

* Change internal var names

* Break down error checking for inputs into separate functions

* Remove the (N, ..., C) option in MD-MC

* Simplify select_topk

* Remove detach for inputs

* Fix typos

* Update pytorch_lightning/metrics/classification/utils.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Update docs/source/metrics.rst

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Minor error message changes

* Update pytorch_lightning/metrics/utils.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* Reuse case from validation in formatting

* Refactor code in _input_format_classification

* Small improvements

* PEP 8

* Update pytorch_lightning/metrics/classification/utils.py

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* Update pytorch_lightning/metrics/classification/utils.py

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* Update docs/source/metrics.rst

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* Update pytorch_lightning/metrics/classification/utils.py

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* Alphabetical reordering of regression metrics

* Change default value of top_k and add error checking

* Extract basic validation into separate function

* Update desciption of parameters in input formatting

* Apply suggestions from code review

Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>

* Check that probabilities in preds sum to 1 (for MC)

* Fix coverage

* Minor changes

* Fix edge case and simplify testing

Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
 2020-12-07 17:49:35 +01:00
chaton 02152c1729
Simplify optimization Logic (#4984) 
* Rely on ddp plugin for blocking sync behaviour, and skip if we're using manual optimization

* debug

* Revert "debug"

This reverts commit ccca6b6b

* Expose manual reduce for automatic optimization

* Add input arguments

* Enable parity test

* clean imports

* Expose hook after to ensure we reset

* Fix naming

* add

* fix test

* uniformize optimizer logic

* resolve test

* resovle flake8

* resolve amp bug

* update tests

* remove bug

* remove optimizer_step in accelerators

* typo

* update lightning optimizer

* set doesn't work with ddp_spawn

* resolve flake8

* update threshold

* ignore pyright

* correct codeFactor

* remove useless if

* remove zer_grad function

* simplify step

* remove typo

* resolve bug

* Apply suggestions from code review

* update on comments

* resolve bugs

* remove tests

* Update pytorch_lightning/trainer/configuration_validator.py

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* simplify testing

* add more tests

Co-authored-by: SeanNaren <sean@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
 2020-12-07 12:55:49 +00:00