Adrian Wälchli
c6b52ef3bd
Fix typing in `pl.overrides.distributed` ( #10797 )
...
* fix typing
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-11-30 21:22:05 +00:00
Carlos Mocholí
0061619e0a
Improve typing for loops ( #10780 )
2021-11-30 20:28:55 +00:00
Adrian Wälchli
fc86c301e7
Fix typing in `pl.callbacks.timer` ( #10798 )
2021-11-30 14:54:08 +01:00
Adrian Wälchli
24fc54f07b
Fix typing in `pl.overrides.fairscale` ( #10799 )
...
* update typing in fairscale
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-11-29 11:28:28 +00:00
Adrian Wälchli
bd3fb2e66e
Fix typing in `pl.core.mixins.hparams_mixin` ( #10800 )
...
* fix typing in hparams mixin
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* unused import
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-11-29 12:03:47 +01:00
Adrian Wälchli
97e52619ea
Fix typing in `pl.overrides.data_parallel` ( #10796 )
...
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-11-29 10:58:23 +01:00
Adrian Wälchli
038c151b6e
Improve typing for plugins ( #10742 )
...
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-11-26 20:14:58 +00:00
Adrian Wälchli
81a0a44d8f
Improve typing for Lite ( #10743 )
...
* improve typing in pytorch_lightning/lite
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* include lite again
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-11-26 20:14:11 +00:00
Carlos Mocholí
3089dc3829
Improve typing for loops ( #10749 )
...
* Improve typing for loops
* Free memory
2021-11-26 18:39:09 +00:00
Carlos Mocholí
78face65e8
Improve typing for logging ( #10748 )
...
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
2021-11-26 18:12:21 +00:00
Carlos Mocholí
b57feccbff
Be explicit with mypy ignores ( #10751 )
...
* Ignore mypy only for failing files
* Comment
2021-11-25 11:27:13 +01:00
Danielle Pintz
85d7c4dce4
Configure mypy to install dependencies in CI and update pyproject.toml ( #10682 )
...
* mypy install deps
* fix deps
* add examples
* fix type errors
* fix type error
* fix
* fix
* update pyproject.toml
2021-11-25 00:19:30 +00:00
Kaushik B
1284ead317
Remove metrics references from docs ( #10567 )
2021-11-22 14:29:06 +00:00
Carlos Mocholí
5788789f01
Move benchmarks into the test directory ( #10614 )
2021-11-19 03:07:33 +01:00
Adrian Wälchli
2a331dd842
add mypy ci check for Lite ( #10289 )
2021-11-01 14:57:58 +00:00
Kaushik B
45c45dc7b0
Deprecate `ProgressBar` and rename it to `TQDMProgressBar` ( #10134 )
...
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-11-01 11:42:21 +00:00
Rohit Gupta
6701526478
Add typing to callbacks ( #10001 )
...
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-10-20 10:22:03 +00:00
Carlos Mocholí
efc8727314
Add typing for `LightningOptimizer` ( #9990 )
2021-10-18 17:29:51 +02:00
Danielle Pintz
940b910d27
[2/4] Add DeviceStatsMonitor callback ( #9712 )
...
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Kaushik B <kaushikbokka@gmail.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
2021-10-13 18:29:36 +00:00
Kaushik B
f94faa9cd3
Enable auto parameters tying for TPUs ( #9525 )
...
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-10-06 10:16:44 +02:00
Adrian Wälchli
f74eb58493
remove `InternalDebugger` ( #9680 )
...
* wip
* reset _notebooks
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* reset _notebooks
* testing with mock
* update test with mock
* update test
* update tests
* update test
* remove track_load_dataloader_calls
* update last test
* remove unused imports
* remove InternalDebugger
* update changelog
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-09-27 09:33:45 -04:00
Daniel Stancl
568a1e0a68
Disallow invalid seed string values ( #8787 )
...
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-09-23 15:09:48 +00:00
thomas chaton
c7451b3ccf
[Feat] Add graceful detection of signal to exit + SignalConnector and merge SlurmConnector. ( #9566 )
...
Co-authored-by: Sean Naren <sean@grid.ai>
2021-09-17 19:13:59 +00:00
Kaushik B
2ec39e275e
Add `RichModelSummary` callback ( #9546 )
2021-09-17 10:54:16 +00:00
jjenniferdai
637f59f1d2
Type `trainer.connectors.checkpoint_connector` ( #9419 )
...
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
2021-09-15 03:02:19 +02:00
Adrian Wälchli
0cb550890c
fix mypy typing for model summary ( #9447 )
2021-09-13 11:41:27 +02:00
Carlos Mocholí
9eccb3148e
Loop and test restructuring ( #9383 )
2021-09-10 13:18:24 +00:00
Adrian Wälchli
ca679cd78f
Add `ManualOptimization` loop ( #9266 )
...
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
2021-09-08 02:26:39 +02:00
Adrian Wälchli
9a14f04322
Fix mypy typing errors in optimizer loop ( #9317 )
2021-09-06 13:54:07 +02:00
Carlos Mocholí
73fca23bed
Add typing for `ResultCollection` [3/3] ( #9271 )
2021-09-06 09:34:40 +00:00
Carlos Mocholí
49c0485d50
Avoid optional `Tracker` attributes and enable mypy ( #9320 )
2021-09-06 00:20:44 +00:00
jjenniferdai
e97c28a02b
Typing `tuner.auto_gpu_select` ( #9292 )
...
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
2021-09-03 15:49:58 +01:00
Carlos Mocholí
171d242a89
Add typing for `_FxValidator` [1/3] ( #9269 )
2021-09-03 13:41:05 +00:00
Carlos Mocholí
ddb4dc2659
Add typing for `LoggerConnector` [2/3] ( #9270 )
...
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-09-03 01:39:06 +02:00
Daniel Stancl
53885afc2e
Fix mypy typing for `utilities.apply_func` ( #8781 )
...
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-08-26 16:36:22 +00:00
Adrian Wälchli
6592d0e454
generalize closure api in Lightning ( #8642 )
...
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
2021-08-26 08:36:21 +00:00
Daniel Stancl
d063059d03
Fix mypy for `utilities.xla_device` ( #8755 )
...
* Fix mypy for utilities.xla_device
* Add explicit type hint for _XLA_AVAILABLE in utilities.imports
2021-08-06 17:01:21 +02:00
Daniel Stancl
0b7f6d9200
Fix mypy for `utilities.memory` ( #8744 )
...
* Fix the majority of mypy issues
* Apply @carmocca's suggestion
* Handle the exception when nvidia-smi not found
* Update get_gpu_memory_map's docstring
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-08-06 11:21:09 +02:00
Daniel Stancl
69cd927fc5
Fix mypy typing for `utilities.debugging` ( #8672 )
2021-08-05 13:47:58 +02:00
Daniel Stancl
aacd131414
Fix mypy in `utilities.distributed` ( #8201 )
2021-08-05 09:51:09 +00:00
Daniel Stancl
08ac079c2f
Fix mypy typing for `utilities.cloud_io.py` ( #8671 )
...
Co-authored-by: tchaton <thomas@grid.ai>
2021-08-03 11:56:28 +02:00
Jirka Borovec
661522e173
black: magic trailing comma ( #8560 )
2021-08-02 20:02:36 +02:00
Daniel Stancl
1f01db8b30
Fix mypy in utilities.argparse ( #8124 )
...
Co-authored-by: tchaton <thomas@grid.ai>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-07-30 16:36:55 +00:00
Carlos Mocholí
a64cc37394
Replace `yapf` with `black` ( #7783 )
...
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-07-26 13:37:35 +02:00
Carlos Mocholí
c5a120ed9d
Update to Mypy>0.9 ( #8386 )
2021-07-13 08:23:36 +02:00
Kaushik B
4f1e7be5ec
Remove Vulture ( #8381 )
2021-07-12 13:39:36 +00:00
Kaushik B
652eae684b
Exclude `lightning.py` for vulture ( #8379 )
2021-07-12 12:29:16 +00:00
Aniket Maurya
0bad2186c1
Added Vulture dead code checker ( #5654 )
...
* integrated vulture CI
* added vulture in workflows
* added vulture in workflows
* vulture logs verbose set false
* Apply suggestions from code review
* ignore name list and args to underscore naming
* add ignore names
* deadcode whitelist
* deadcode whitelist
* Apply suggestions from code review
Co-authored-by: Rahul Jha <rahul722j@gmail.com>
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update whitelist
* Sort
* Updates
* Updates
* Apply suggestions from code review
* Updates
Co-authored-by: Aniket Maurya <aniket.maurya@gdn-commerce.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Rahul Jha <rahul722j@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
2021-06-02 16:19:10 +01:00
Carlos Mocholí
414aa5d345
Delete unused autopep8 config ( #5904 )
2021-02-11 14:32:14 +00:00
Jirka Borovec
630a88addb
drop deprecated docs ( #5768 )
...
* drop deprecated docs
* notes
* .
2021-02-03 20:21:19 +00:00
Carlos Mocholí
aa03b73e60
Remove psf/black references ( #5739 )
...
* Update pyproject.toml
* Update setup.cfg
* Update test.txt
* Update CONTRIBUTING.md
* Update requirements/test.txt
2021-02-03 08:37:06 +00:00
Arnaud Gelas
8dfcc078c4
Fix isort failures in core ( #5526 )
...
Remove from skipped module in pyproject.toml and fix failures on:
- pytorch_lightning/core/*.py
2021-01-27 05:02:16 -05:00
Arnaud Gelas
a9d9f33a86
Fix isort failures in trainer ( #5529 )
...
Remove from skipped module in pyproject.toml and fix failures on:
- pytorch_lightning/trainer/*.py
2021-01-18 13:42:50 -05:00
Arnaud Gelas
61e1d8772d
Fix isort failures in metrics ( #5528 )
...
Remove from skipped module in pyproject.toml and fix failures on:
- pytorch_lightning/metrics/*.py
2021-01-18 07:10:53 -05:00
Arnaud Gelas
1ff6b18e8a
Fix pre-commit isort failure on pytorch_lightning/accelerators ( #5503 )
...
Remove from skipped module in pyproject.toml and fix failures on:
- pytorch_lightning/accelerators/*.py
2021-01-16 14:10:56 -05:00
Arnaud Gelas
6386b8d36b
Fix isort a few failures ( #5504 )
...
Remove from skipped module in pyproject.toml and fix failures on:
- pytorch_lightning/callbacks/*.py
- pytorch_lightning/cluster_environments/*.py
- pytorch_lightning/profiler/*.py
- pytorch_lightning/tuner/*.py
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
2021-01-15 17:44:27 -05:00
Arnaud Gelas
e4688ae754
Fix isort failures in utilities ( #5530 )
...
Remove from skipped module in pyproject.toml and fix failures on:
- pytorch_lightning/utilities/*.py
2021-01-15 13:57:40 -05:00
Arnaud Gelas
8629048659
Fix isort failures in loggers ( #5527 )
...
Remove from skipped module in pyproject.toml and fix failures on:
- pytorch_lightning/loggers/*.py
2021-01-15 22:53:56 +05:30
Arnaud Gelas
23c241d083
Fix pre-commit isort failure on tests/base/*.py ( #5429 )
...
* Remove tests.base from skipped module in pyproject.toml
* Fix pre-commit isort failure on tests/base/*.py
2021-01-15 03:01:57 -05:00
Arnaud Gelas
7523e6940f
Fix pre-commit isort failure on tests/backends/*.py ( #5430 )
...
* Fix pre-commit isort failure on tests/backends/*.py
* Remove tests.backends from skipped module in pyproject.toml
2021-01-14 19:32:41 -05:00
Arnaud Gelas
9515750548
Fix pre-commit isort failure on tests/loggers/*.py ( #5425 )
...
* Remove tests.loggers from skipped module in pyproject.toml
* Fix pre-commit isort failure on tests/loggers/*.py
2021-01-14 14:36:28 -05:00
Arnaud Gelas
6d83d4457d
Fix pre-commit isort failure on tests/callbacks/*.py ( #5428 )
...
* Remove tests.callbacks from skipped module in pyproject.toml
* Fix pre-commit isort failure on tests/callbacks/*.py
2021-01-14 13:15:34 -05:00
Jirka Borovec
16224781ed
anti-colision isort config ( #5511 )
2021-01-14 10:33:09 -05:00
Arnaud Gelas
ac531ec945
Fix pre-commit isort failure on tests/models/*.py ( #5423 )
...
* Remove tests.models from skipped module in pyproject.toml
* Fix pre-commit isort failure on tests/models/*.py
2021-01-14 09:42:01 -05:00
Arnaud Gelas
7fb0221934
Fix pre-commit isort failure on tests/trainer/*.py ( #5421 )
...
* Remove tests.trainer from skipped module in pyproject.toml
* Fix pre-commit isort failure on tests/trainer/*.py
2021-01-14 07:51:20 -05:00
Arnaud Gelas
d8a0c7d82a
Fix pre-commit isort failure on tests/metrics/*.py ( #5424 )
...
* Remove tests.metrics from skipped module in pyproject.toml
* Fix pre-commit isort failure on tests/metrics/*.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-01-14 06:05:28 -05:00
Arnaud Gelas
84d1040b32
Fix pre-commit isort failure on tests/plugins/*.py ( #5422 )
...
* Fix pre-commit isort failure on tests/plugins/*.py
* Remove tests.plugins from skipped module in pyproject.toml
* Update pyproject.toml
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-01-14 03:57:16 -05:00
Rohit Gupta
29bcf30984
[tests/core] Updated with BoringModel and added BoringDataModule ( #5432 )
...
* update with BoringModel and introduce BoringDataModule
* isort
* fix
* rm random_split
* fix test
* fix test
* update
* update test_results
* val_step
* update tests
* rebase
* rebase
2021-01-13 01:48:37 -05:00
Arnaud Gelas
2373858b33
Fix pre-commit isort failure on tests/checkpointing/*.py ( #5427 )
...
* Remove tests.checkpointing from skipped module in pyproject.toml
* Fix pre-commit isort failure on tests/checkpointing/*.py
2021-01-12 03:31:51 -05:00
Arnaud Gelas
b9530d291e
Fix pre-commit isort failure on tests/utilities/*.py ( #5420 )
...
* Remove tests.utilities from skipped module in pyproject.toml
* Fix pre-commit isort failure on tests/utilities/*.py
2021-01-11 14:00:39 -05:00
Jirka Borovec
53b0cb910b
update isort config ( #5335 )
...
* update isort config
* apply
(cherry picked from commit 724f1051f0
)
2021-01-06 12:49:23 +01:00
Akihiro Nitta
abc690d720
Apply isort to `pl_examples/` ( #5291 )
...
* Remove examples from isort ignore list
* Apply isort
(cherry picked from commit 0c7c9e8540
)
2021-01-06 12:47:53 +01:00
Akihiro Nitta
151d86e40b
Update isort config ( #5142 )
...
* Update isort config
* Apply isort with new config
* Fix typo in isort config
* fix rebase
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2021-01-05 09:57:37 +01:00
Akihiro Nitta
ece09f0c5f
Apply import formatting to files in the 2nd top level ( #4717 )
...
* Update pyproject.toml
* Apply isort to files in second level
Co-authored-by: chaton <thomas@grid.ai>
2020-11-18 00:29:09 +01:00
Nathan Painchaud
2d78d9b84a
CI: Added isort import check for the code on pull-request ( #4242 )
...
* added isort CI job and updated isort config
* changed CI check output from files to full diff
* added isort pre-commit hook
* Added missing first party and restricted files affected by isort
* Applied isort to root-level, docs and benchmarks
* Apply suggestions from code review
Co-authored-by: Nathan Painchaud <nathanpainchaud@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: chaton <thomas@grid.ai>
2020-11-13 22:57:46 +01:00
kumuji
fd7814d287
Added black formater for the code with code-checker on pull ( #1610 )
...
* black
Added throught black.toml other options are hard so far
No caching for black github action
Moved from black.toml to pyproject.toml
Exclude not only yml but also yaml
Update pyproject.toml
Co-authored-by: Thomas Johansen <thomasjo@gmail.com>
Update .github/workflows/code-formatting-check.yml
mergify
Remove formating check
E231 error ignoring because of black formating
Updated CONTRIBUTING to the master
* Update .github/workflows/code-formatting-check.yml
* Bump black to 19.10b0 version
* resolved incorrect merge of CONTRIBUTING,
Black skipping string normalization
* Minor fixes in CONTRIBUTING, two typos
* Update setup.cfg
* chlog
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka <jirka@pytorchlightning.ai>
2020-06-03 18:23:14 +02:00
Hadrien Mary
89d5772f55
Split callbacks ( #849 )
...
* add .vscode in .gitignore
* Split callbacks in individual files + add a property to Callback for easy trainer instance access
* formatting
* Add a conda env file for quick and easy env setup to develop on PL
* Adress comments
* add fix to kth_best_model
* add some typing to callbacks
* fix typo
* add autopep8 config to pyproject.toml
* format again
* format
* fix toml
* fix toml again
* consistent max line length in all config files
* remove conda env file
* Update pytorch_lightning/callbacks/early_stopping.py
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>
* Update pytorch_lightning/callbacks/model_checkpoint.py
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>
* docstring
* Update pytorch_lightning/callbacks/model_checkpoint.py
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>
* Update pytorch_lightning/callbacks/model_checkpoint.py
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>
* fix logic error
* format
* simplify if/else
* format
* fix linting issue in changelog
* edit changelog about new callback mechanism
* fix remaining formating issue on CHANGELOG
* remove lambda function because it's compatible with pickle (used during ddp)
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-02-22 21:45:34 -05:00
Shreyas Bapat
4809de8765
Fix pip install too
2019-04-03 22:47:55 +05:30