dylanaraps
/
neofetch
mirror of https://github.com/dylanaraps/neofetch.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Updated Shellcheck Exclusions (markdown)

Dylan Araps 2016-12-09 11:57:11 +11:00
parent 7eae45e47c
commit 00a592b2ab
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Shellcheck-Exclusions.md

@ -15,6 +15,13 @@ This error has been disabled since we're not sourcing the config file when runni
We were originally using `pgrep` until we found out that `pgrep` has some issues on macOS systems. We were originally using `pgrep` until we found out that `pgrep` has some issues on macOS systems.
### [SC2010](https://github.com/koalaman/shellcheck/wiki/SC2010)
> Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames.
This only affects a single line in the macOS section of the `get_packages()` function. I can't fix this unless I get access to a macOS machine.
### [SC2012](https://github.com/koalaman/shellcheck/wiki/SC2012) ### [SC2012](https://github.com/koalaman/shellcheck/wiki/SC2012)
> Use find instead of ls to better handle non-alphanumeric filenames. > Use find instead of ls to better handle non-alphanumeric filenames.