From 00a592b2abc5e549e533131ba44b879a5eb2c837 Mon Sep 17 00:00:00 2001 From: Dylan Araps Date: Fri, 9 Dec 2016 11:57:11 +1100 Subject: [PATCH] Updated Shellcheck Exclusions (markdown) --- Shellcheck-Exclusions.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Shellcheck-Exclusions.md b/Shellcheck-Exclusions.md index b5a5e47..e229a87 100644 --- a/Shellcheck-Exclusions.md +++ b/Shellcheck-Exclusions.md @@ -15,6 +15,13 @@ This error has been disabled since we're not sourcing the config file when runni We were originally using `pgrep` until we found out that `pgrep` has some issues on macOS systems. +### [SC2010](https://github.com/koalaman/shellcheck/wiki/SC2010) + +> Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames. + +This only affects a single line in the macOS section of the `get_packages()` function. I can't fix this unless I get access to a macOS machine. + + ### [SC2012](https://github.com/koalaman/shellcheck/wiki/SC2012) > Use find instead of ls to better handle non-alphanumeric filenames.