dylanaraps
/
neofetch
mirror of https://github.com/dylanaraps/neofetch.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
Page: Shellcheck Exclusions
Pages
Config File Custom Ascii art file format Customizing Info Dependencies Frequently Asked Questions Getting Started Home Image Backends Images in the terminal Installation Neofetch vs. Screenfetch Operating System Support Shellcheck Exclusions Terminal and Terminal Font detection What is Waifu Crop?
6 Shellcheck Exclusions
Dylan Araps edited this page 2016-12-13 13:46:15 +11:00
Table of Contents

This wiki page lists all of the shellcheck errors that we're ignoring when testing Neofetch.

SC1090

Can't follow non-constant source. Use a directive to specify location.

This error has been disabled since we're not sourcing the config file when running shellcheck.

SC2009

SC2009 Consider using pgrep instead of grepping ps output.

We were originally using pgrep until we found out that pgrep has some issues on macOS systems.

SC2010

Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames.

This only affects a single line in the macOS section of the get_packages() function. I can't fix this unless I get access to a macOS machine.

SC2012

Use find instead of ls to better handle non-alphanumeric filenames.

This is OK to ignore since we're only counting the number of files and directories.

SC2016

Expressions don't expand in single quotes, use double quotes for that.

This is intended, the expressions are sent to another shell. (zsh -c '${ZSH_VERSION}')

SC2034

foo appears unused. Verify it or export it.

This error has been disabled since we dynamically use the info variables. ($kernel)

SC2128

Expanding an array without an index only gives the first element.

Each info function in Neofetch is split into separate parts for each Operating System. One OS might need an array to get the info and the others may not. Shellcheck sees mixed usage of Arrays/Variables and that's what causes this error.

SC2153

Possible Misspelling: MYVARIABLE may not be assigned, but MY_VARIABLE is.

We use a lot of Environment Variables and this error comes up whenever we reassign an Environment Variable to a local variable. Totally harmless.

SC2154

var is referenced but not assigned.

This error has been disabled since the variables are in the config files which we don't source when testing with shellcheck.

SC2178

Variable was used as an array but is now assigned a string.

Each info function in Neofetch is split into separate parts for each Operating System. One OS might need an array to get the info and the others may not. Shellcheck sees mixed usage of Arrays/Variables and that's what causes this error.