Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
pokecrystal/engine/events
History
Andrew Cook 0f5540740b
Some Mobile code labeling and removed magic numbers (#993) 
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
 		2022-09-14 19:49:58 -05:00
..
battle_tower Some Mobile code labeling and removed magic numbers (#993) 2022-09-14 19:49:58 -05:00
bug_contest Use numeric constants in text strings with "{d:interpolation}" 2021-03-21 18:14:31 -04:00
pokerus Clean up some percentage values 2020-05-07 14:21:24 -04:00
basement_key.asm Rename some call/jump script commands to avoid confusion with jr/jp asm instructions 2019-03-10 16:39:31 -04:00
buena.asm Identify some wMenuJoypad-related button constants 2022-03-09 19:42:26 -05:00
buena_menu.asm Use labels instead of constants for HRAM 2018-08-25 14:28:22 -04:00
card_key.asm Rename some call/jump script commands to avoid confusion with jr/jp asm instructions 2019-03-10 16:39:31 -04:00
catch_tutorial.asm Use ~X instead of $ff ^ X 2021-11-23 20:37:18 -05:00
catch_tutorial_input.asm Remove all address comments 2018-06-24 16:13:22 +02:00
celebi.asm wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
checkforhiddenitems.asm Rename GetFarHalfword to GetFarWord 2021-01-09 15:16:05 -05:00
checksave.asm Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM) 2020-06-17 17:03:38 -04:00
checktime.asm Remove all address comments 2018-06-24 16:13:22 +02:00
daycare.asm Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
diploma.asm Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:10 -04:00
dratini.asm Remove even more address comments 2018-06-25 02:10:37 +02:00
elevator.asm Identify scrolling menu lists in WRAM 2021-03-08 09:41:55 -05:00
engine_flags.asm Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
field_moves.asm Rename the `object_struct` field labels and constants (#1005) 2022-09-12 09:15:44 -04:00
fish.asm Miscellaneous label and comment corrections 2019-11-03 14:47:06 -05:00
fishing_gfx.asm Use labels instead of constants for HRAM 2018-08-25 14:28:22 -04:00
forced_movement.asm Rename more script commands for consistency and predictability 2019-03-10 16:00:19 -04:00
fruit_trees.asm Clear however many bytes are needed for wFruitTreeFlags 2022-02-14 17:28:08 -05:00
haircut.asm Clean up bugs commented in the source code (#912) 2022-07-09 16:12:02 -05:00
halloffame.asm Clean up bugs commented in the source code (#912) 2022-07-09 16:12:02 -05:00
happiness_egg.asm Rename some labels 2020-12-23 16:29:30 -05:00
heal_machine_anim.asm wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
hidden_item.asm Split up engine/events/misc_scripts_2.asm 2020-02-13 18:31:10 +01:00
itemfinder.asm #641 fixes and additions. (#646) 2019-10-20 18:24:17 -04:00
kurt.asm Rename some labels 2020-12-23 16:29:30 -05:00
kurt_selectquantity_interpretjoypad.asm Remove all address comments 2018-06-24 16:13:22 +02:00
lucky_number.asm Use `for` loops to generate box pointer tables 2022-08-31 18:03:49 -04:00
magikarp.asm Clean up bugs commented in the source code (#912) 2022-07-09 16:12:02 -05:00
magnet_train.asm Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
map_name_sign.asm RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
misc_scripts.asm Rename some labels 2020-12-23 16:29:30 -05:00
mom.asm Identify more labels, and use the jumptable macro when possible 2020-07-01 13:13:49 -04:00
mom_phone.asm RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
money.asm Fix triple newlines left over from removing address comments 2018-06-24 23:22:50 -04:00
move_deleter.asm Rename some labels 2020-12-23 16:29:30 -05:00
move_tutor.asm Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
name_rater.asm Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
npc_trade.asm Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
odd_egg.asm Some Mobile code labeling and removed magic numbers (#993) 2022-09-14 19:49:58 -05:00
overworld.asm Rename the `object_struct` field labels and constants (#1005) 2022-09-12 09:15:44 -04:00
play_slow_cry.asm Remove all address comments 2018-06-24 16:13:22 +02:00
poisonstep.asm Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
poisonstep_pals.asm Resolve some "???" comments 2020-11-17 11:09:02 -05:00
poke_seer.asm Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
pokecenter_pc.asm Standardize capitalization of ".Jumptable" 2021-06-19 19:52:05 -04:00
pokepic.asm Use labels instead of constants for HRAM 2018-08-25 14:28:22 -04:00
print_photo.asm #641 fixes and additions. (#646) 2019-10-20 18:24:17 -04:00
print_unown.asm RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
print_unown_2.asm Use rgbds 0.5.0 2021-04-19 16:31:37 -04:00
prof_oaks_pc.asm Identify the remaining (non-mobile) uses of another WRAM union 2020-10-29 14:51:41 -04:00
repel.asm Split up engine/events/misc_scripts_2.asm 2020-02-13 18:31:10 +01:00
sacred_ash.asm #641 fixes and additions. (#646) 2019-10-20 18:24:17 -04:00
shuckle.asm RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
specials.asm Rename some labels 2020-12-23 16:29:30 -05:00
squirtbottle.asm #641 fixes and additions. (#646) 2019-10-20 18:24:17 -04:00
std_collision.asm Create data/collision/ for tile collision-related data 2020-10-27 10:00:56 -04:00
std_scripts.asm Refer to "Rival", not "Silver" (#983) 2022-08-10 21:24:56 -04:00
sweet_scent.asm Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
trainer_scripts.asm Rename some call/jump script commands to avoid confusion with jr/jp asm instructions 2019-03-10 16:39:31 -04:00
treemons.asm Identify more uses of wBuffer1-6 2020-11-03 19:53:07 -05:00
unown_walls.asm Standardize on lowercase Tilemap and Attrmap 2020-02-13 18:31:10 +01:00
whiteout.asm return → endcallback, reloadandreturn → reloadend 2020-07-17 08:37:03 -04:00