pokecrystal/engine
Andrew Cook 0f5540740b
Some Mobile code labeling and removed magic numbers (#993)
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
2022-09-14 19:49:58 -05:00
..
battle Fix AI_Smart_Rage comment (#988) 2022-08-21 22:39:08 -05:00
battle_anims Replace numbers with constants in PlayHitSound 2022-08-24 12:17:31 +02:00
debug Use `for` loops to generate box pointer tables 2022-08-31 18:03:49 -04:00
events Some Mobile code labeling and removed magic numbers (#993) 2022-09-14 19:49:58 -05:00
games Rename `macros/wram.asm` to `macros/ram.asm` (#1003) 2022-09-11 01:05:07 -04:00
gfx Move non-Pokémon graphics out of gfx/icons 2022-08-17 17:45:26 -04:00
items Clean up bugs commented in the source code (#912) 2022-07-09 16:12:02 -05:00
link wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
math RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
menus Some Mobile code labeling and removed magic numbers (#993) 2022-09-14 19:49:58 -05:00
movie wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
overworld Rename the `object_struct` field labels and constants (#1005) 2022-09-12 09:15:44 -04:00
phone Clean up bugs commented in the source code (#912) 2022-07-09 16:12:02 -05:00
pokedex wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
pokegear wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
pokemon Use `for` loops to generate box pointer tables 2022-08-31 18:03:49 -04:00
printer RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
rtc RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
tilesets Add more comments to tileset palette animation functions 2021-05-30 23:32:03 -04:00
predef.asm Rename some labels 2020-12-23 16:29:30 -05:00
smallflag.asm Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00