Commit Graph

3064 Commits

Author SHA1 Message Date
mid-kid fd14253796 Clean up labels in battle/moves/move_effects.asm
There were a lot of unused labels in there, and a few confusing
misnomers around move_effects_pointers.asm. They now match up exactly
with the names in battle_constants.asm.
Also renamed a few effects, to make their purpose clearer, and to match
up with their respective event script commands:
EFFECT_EXPLOSION    -> EFFECT_SELFDESCTRUCT
EFFECT_HAZE         -> EFFECT_RESET_STATS
EFFECT_WHIRLWIND    -> EFFECT_FORCE_SWITCH
EFFECT_BIND         -> EFFECT_TRAP_TARGET
EFFECT_TWINEEDLE    -> EFFECT_POISON_MULTI_HIT
EFFECT_STEEL_WING   -> EFFECT_DEFENSE_UP_HIT
EFFECT_METAL_CLAW   -> EFFECT_ATTACK_UP_HIT
EFFECT_ANCIENTPOWER -> EFFECT_ALL_UP_HIT
2017-11-15 16:36:13 +01:00
pfero 6bb7df7e29 Fix comments in tilesets/roofs.asm
Apparently the first entry in MapGroupRoofs is for the unused mapgroup 0.
Also added useful comments to tilesets/roof.pal.
2017-11-08 00:10:02 +01:00
pfero 999c804f6f Label some functions in gfx/load_pics.asm
A few projects I looked around in used these same labels for these
functions, and it looks like they describe these functions properly.
Also fixed usage of BANK() in a few places.
2017-11-03 01:12:16 +01:00
pfero 88f1b8165b Define GetWarpSFX
This function checks the current tile at the player's feet, and returns
an appropriate SFX that should be played when warping from it.
2017-10-29 11:14:59 +01:00
pfero 7c9a156133 Fix WATERTILE/WALLTILE constants
WATRTILE was wrongly defined as 15, and WALLTILE as 1. Those had to be
flipped around.
This has allowed for us to replace inmediate values with these constants
in several places to improve readability.

WATRTILE was renamed to WATERTILE in the name of readability.
2017-10-28 18:08:24 -04:00
yenatch 4e4e792474 whitelist shiny.pal 2017-10-25 00:43:40 -04:00
yenatch 021afb6831 rgbds variables in the makefile
this is for my own convenience but anyone using both rgbds 2 and 3 may find it useful
2017-10-22 02:12:13 -04:00
yenatch 1439887b49 rename pokecrystal.ld -> pokecrystal.link 2017-10-22 02:06:43 -04:00
yenatch dddf184b07 fix animated pic dumps 2017-10-22 02:04:06 -04:00
yenatch 6f72bfece1 condense japanese pokemon sort 2017-10-22 01:52:57 -04:00
yenatch 7c59c3577d Merge pull request #394 from surskitty/master
Adjusting Indigo League map labels
2017-10-21 21:45:59 -04:00
surskitty f204a11274 Typo fix. 2017-10-21 00:25:49 -04:00
surskitty 20e88485a5 Renaming labels for E4. 2017-10-21 00:10:00 -04:00
yenatch 77a98f2f44 Merge pull request #390 from yenatch/remove-contents
Remove contents.asm
2017-09-25 17:21:40 -04:00
yenatch 543d67b647 Build tools with -O3.
This improves build time by about 20%.
2017-09-24 15:08:44 -04:00
yenatch aa19af3822 Rebuild on changes to pokecrystal.ld 2017-09-24 03:30:47 -04:00
yenatch a950b020cd Align "Sprites" section to $100 bytes.
The code expects this section to be aligned.
2017-09-24 03:27:47 -04:00
yenatch afe67ba1b4 Remove contents.asm 2017-09-24 03:15:01 -04:00
yenatch 52cd3398bd fix rgbds version in install instructions 2017-09-24 01:34:44 -04:00
yenatch 01caa369ec Merge pull request #379 from yenatch/tools
Refactor scan_includes and add warnings for tools
2017-09-24 01:25:03 -04:00
yenatch 17448c51a5 Merge pull request #389 from yenatch/rgbds-3
rgbds 0.3.3
2017-09-24 01:23:34 -04:00
PikalaxALT 46bc3e4c88 Remove redundant org statements (ax6 will slaughter me) 2017-09-24 01:15:43 -04:00
PikalaxALT 63bc19e33d Make repository compatible with RGBDS 0.3.3 (breaks support for earlier versions of RGBDS) 2017-09-24 01:15:05 -04:00
yenatch 94577d9553 fix warnings in lzcomp and md5 2017-09-24 01:07:08 -04:00
yenatch 0aee932b5f Add warnings for tools 2017-09-24 01:07:05 -04:00
yenatch 59a27d5907 tools/gfx: Replace --width with --png 2017-09-24 01:07:02 -04:00
PikalaxALT 836fd48191 Update travis.yml 2017-09-23 23:04:20 -04:00
PikalaxALT 0e470bc785 Fix section linking
Create linker script and float all sections
2017-09-23 23:04:10 -04:00
yenatch 1de1bdbce7 Merge pull request #388 from surskitty/master
Moving a few images out of gfx/unknown
2017-09-17 17:07:22 -04:00
surskitty 7cd4ca1207 Updating Makefile for the unused GB + N64 image. 2017-09-10 00:30:52 -04:00
surskitty ee5241bcc5 Correcting gfx function name to standards. 2017-09-10 00:01:38 -04:00
surskitty 817525a811 Labelling kanji for the days of the week (calendar?) 2017-09-09 23:58:23 -04:00
surskitty 5476e2914b Renaming the image of the GB and the N64. 2017-09-09 23:53:05 -04:00
surskitty 4800861b6f Merge https://github.com/pret/pokecrystal 2017-09-09 23:44:31 -04:00
surskitty bc61a0ca05 Moving headbutt tree graphic. 2017-09-09 23:43:28 -04:00
luckytyphlosion 7c6932fbae Add Gen 3 disassemblies. 2017-09-04 19:41:13 -04:00
luckytyphlosion a497ca3c2e Add other Discord and disassembly links. 2017-09-04 19:25:37 -04:00
yenatch ff7c82c64c Merge pull request #382 from surskitty/master
Adding place names to the PokeMart list to match item constants.
2017-08-31 20:59:51 -04:00
yenatch cef86fed5f Merge pull request #384 from i0brendan0/i0brendan0-patch-3
Correct constant to remove a bug
2017-08-30 22:37:35 -04:00
i0brendan0 7b67e7296a Remove possibility of garbage characters
If the ds 2 that is behind OTClassName is deleted or decreased, the game will continue to display characters for trainer classes that are 12 or 13 characters long, including the @ terminator. The correct constant has been put in place and the ds 2 removed, but no one would have known it was wrong if they hadn't have removed the ds 2.
2017-08-30 20:56:11 -05:00
surskitty c1dc4246a3 Adding place names to the PokeMart list to match item constants. 2017-08-30 17:04:02 -04:00
yenatch 8182720979 Merge pull request #380 from i0brendan0/i0brendan0-patch-1
Fix unused Constant for Happiness
2017-08-24 18:39:48 -04:00
i0brendan0 0e33fd74f1 Fix unused Constant for Happiness
The HAPPINESS_TO_EVOLVE constant is what's supposed to be used to give the number for when a Pokemon should evolve by happiness. The constant was not put in place so it is never used, instead the original 220 was put.
2017-08-24 17:29:56 -05:00
yenatch 7ba068d45b Makefile formatting 2017-08-20 12:42:54 -04:00
yenatch 3064e84c5f Use $(filter) to check targets 2017-08-20 12:37:23 -04:00
yenatch 50d163895d Remove comma from png_dimensions usage 2017-08-20 12:33:36 -04:00
yenatch c719ff4f0b Fix unused variable warnings 2017-08-20 12:33:12 -04:00
yenatch 885af5e543 Refactor scan_includes 2017-08-20 12:32:15 -04:00
IIMarckus 80888726b9 Check some errors (not enough).
malloc can always fail. Check to avoid null dereference.

malloc(0) is well defined but leads to an eventual crash on some systems.
Check it too.
2017-06-29 22:45:30 -06:00
IIMarckus 2ebbe91fe8 Fix uninitialized value. 2017-06-29 22:14:12 -06:00