Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
5,145 Commits 2 Branches 0 Tags 193 MiB
Commit Graph

699 Commits

Author SHA1 Message Date
xCrystal e0c278a595 Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission (#1078) 2024-01-07 14:51:27 +01:00
xCrystal f72f078c0e Rename wVramState to wStateFlags and use flag constants (#1078) 2024-01-07 14:27:22 +01:00
xCrystal cd28c44ff3 Improve some innacurate function names, labels, and comments (#1078) 
[https://github.com/pret/pokecrystal/issues/1078#issuecomment-1872396250]
 2024-01-07 13:36:28 +01:00
xCrystal bd6ceec193 Improve some innacurate function names, labels, and comments (#1078) 
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
 2024-01-07 13:36:05 +01:00
Rangi dbf6044650
Update to RGBDS 0.7.0 (#1101) 2024-01-03 10:58:53 -05:00
SnorlaxMonster a82dfd81bb
Replace "¯" and "%" (breakable whitespace) with more meaningful charmap names (#1094) 2023-11-19 20:04:45 -05:00
vulcandth 05083d6fd2 Move charmap.asm to constants/ 
Resolves #1090
 2023-11-17 21:59:32 -06:00
vulcandth aba1f14044
Sync sprite and battle anim consts/labels (#1055) 
* Sync sprite and battle anim consts/labels

* Add `; 00` comments

* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
 2023-09-17 13:09:28 -05:00
Tiddlywinks b0ddb0758d 1) Fix DECOFLAG order. 2) The doll is Staryu, not Starmie (and the sprite can be either) 2023-09-13 08:08:27 +02:00
SoupPotato 6180be355e
Labeled framesets and related constants (#1063) 
* Labeled Framesets and Constants Related

* Feedback Implemented with PascalCase and Constant Renames

* Fix framset.asm comment spacing

* `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA`

* Feedback applied and labeled 1E & B2

* Fixed SpinningBone

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
 2023-08-21 19:09:23 -05:00
Rangi 9c0ef02d4b Verify that there aren't too many OAM constants 
Fixes #1062
 2023-08-15 19:45:33 -04:00
vulcandth e07a1e7773
Define relationship between map_object and object_events (#1054) 2023-08-14 09:19:25 -05:00
SatoMew 768b3bdec1
Improve mobile-related labels (#1061) 2023-07-26 19:59:00 -05:00
SnorlaxMonster c931b98a81
Rename BATTLETYPE_SHINY to BATTLETYPE_FORCESHINY (#1058) 
* Rename BATTLETYPE_SHINY to BATTLETYPE_FORCED_SHINY

The name BATTLETYPE_SHINY gave the impression that it applied to all
battles with Shiny Pokémon, rather than merely battles with forced
Shiny Pokémon (i.e. Red Gyarados only).

* Rename to BATTLETYPE_FORCESHINY

Align name of BATTLETYPE with BATTLETYPE_FORCEITEM

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
 2023-07-26 19:51:34 -05:00
vulcandth 438c48daad
Rename PAL_NPC_SILVER to PAL_NPC_EMOTE (#1053) 2023-06-01 07:47:53 -05:00
mid-kid 4c4fd7258c Define SERIAL_PATCH_PREAMBLE_LENGTH 2023-04-19 19:12:14 +02:00
mid-kid 08cfbbb1d9 Document link patch lists a little bit better 2023-04-19 19:12:14 +02:00
mid-kid a6ac67dea2 IsMailEuropean → ParseMailLanguage (and give it constants) 2023-04-19 19:12:14 +02:00
vulcandth c75d121c78 Missed `DEF` in `add_tm` 2023-03-16 21:25:33 -05:00
vulcandth c01409be5a
Relabel some `map_object` struct fields (#1029) 2023-01-03 22:16:08 -05:00
vulcandth cb8505e022
Define `InitDefaultEZChatMsgs` and `sEZChatMessages` (#1022) 2022-12-26 13:55:01 -05:00
vulcandth 25e12c9391
wUnlockedUnowns engine_flag constants (#1025) 2022-12-26 13:14:10 -05:00
Rangi 8fc3b8e6e3 Dance Theatre -> Dance Theater 
Fixes #1008
 2022-09-23 22:06:52 -04:00
Idain 553a272e52
TYPO: NUM_MOVE_EFECTS > NUM_MOVE_EFFECTS (#1009) 2022-09-21 22:01:39 -05:00
Rangi 711f5c87b3 Comment about the redundant event `const_next 1900` 
Fixes #1006
 2022-09-15 18:05:52 -04:00
Andrew Cook 0f5540740b
Some Mobile code labeling and removed magic numbers (#993) 
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
 2022-09-14 19:49:58 -05:00
Rangi 41d5ea0482
Rename the `object_struct` field labels and constants (#1005) 
Fixes #990
 2022-09-12 09:15:44 -04:00
vulcandth 4c239a6f65
Rename `macros/wram.asm` to `macros/ram.asm` (#1003) 2022-09-11 01:05:07 -04:00
Rangi 0d5cf5c8b9
Refer to "Rival", not "Silver" (#983) 
Fixes #982
 2022-08-10 21:24:56 -04:00
vulcandth c3331eb7b1
Rename scene and callback labels (#981) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-08-09 18:04:18 -04:00
Rangi 8826d97ee4
Define scene constants alongside scene_scripts (#979) 
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
 2022-07-29 17:43:10 -04:00
Colton G. Rushton 145d8dd5c2
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
Colton G. Rushton d3da137de8
Add object priority mode constant and remove unnecessary constants (#972) 
The rest of the unknown constants aren't even registers and can safely be removed without issue.
 2022-07-04 01:10:24 -04:00
Colton G. Rushton 4125138da7
Remove unused serial constants ported from pokered (#949) 2022-06-18 13:33:34 -04:00
Colton G. Rushton 6a9e929bf9
Remove rNR20/rNR40 and add rPCM12/rPCM34 (#947) 2022-06-17 22:29:09 -04:00
vulcandth 5f0597e944
Rename `SLP` to `SLP_MASK` (#918) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-06-17 22:25:56 -04:00
vulcandth 3648afda16
RGBDS syntax updates (#905) 
New MACRO and DEF syntax
 2022-06-06 17:25:42 -04:00
Idain d0c8f63f25
Rename ENGINE_FISH_SWARM to ENGINE_QWILFISH_SWARM (#879) 2022-02-22 09:47:05 -05:00
Rangi 13837b429c Define the `*_WILDDATA_LENGTH` equations to match their data representation 2022-02-12 10:01:12 -05:00
mid-kid 1dc88cb585 Enumerate MobileAPI function constants 2022-01-23 18:13:41 +00:00
Rangi 69185e1657 Identify some overworld movement data 2021-12-22 21:38:26 -05:00
Rangi 9042b8f83d Swimmer♀ Mary is unused 2021-11-28 11:39:46 -05:00
Rangi ab0f9c287a Use compound assignment operators 2021-11-23 20:18:08 -05:00
Rangi 645719e99b Comment unused trainers 
Fixes #819
 2021-11-03 19:33:54 -04:00
Rangi 187b120007 Add assertions to some more tables 2021-10-24 18:28:54 -04:00
Rangi f59f1bdb88 Standardize capitalization of ".Jumptable" 2021-06-19 19:52:05 -04:00
Rangi 1f9e688b76 MON_PKRUS -> MON_POKERUS 2021-06-07 20:00:21 -04:00
Rangi ed0a0f7159 Move the dbbw, dbww, and dbwww macros to legacy 2021-05-30 15:51:49 -04:00
Rangi efd1006917
Use {interpolation} to generate sequences of RAM labels 
This makes the table_width/assert_table_length usages unnecessary, and also keeps the labels automatically up to date if the length constants change.
 2021-04-27 12:11:39 -04:00
Rangi 316fa4b695 Use rgbds 0.5.0 2021-04-19 16:31:37 -04:00