Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
5,155 Commits 2 Branches 0 Tags 198 MiB
Commit Graph

5155 Commits

Author SHA1 Message Date
Rangi42 bb572c4c52 Document the Slowpoke Well graphical oversight 2024-06-12 14:15:49 -04:00
Rangi42 b26e023555 Move cosmetic bugs to the Graphics section 2024-06-12 13:49:50 -04:00
Rangi42 4f57e96f31 Consolidate the duplicate stat level data files 2024-06-12 13:13:58 -04:00
Sylvie 8819f7b117
Identify various "????"s (#1125) 2024-06-11 20:54:45 -04:00
Rangi42 23183bb9bb Rename wram_constants.asm to ram_constants.asm 2024-05-22 21:07:37 -04:00
Rangi42 de0d5c29e5 wPrinterQueueLength values are divisible by 2 2024-05-22 21:02:55 -04:00
Rangi42 b81e339f33 Use constants for VBlank handlers 2024-05-22 21:02:55 -04:00
Idain 4432df05cb
Add more assert cases in the codebase (#1115) 
* Add assert for FACING_GRASS_1 and FACING_GRASS_2

* Add more assert cases

* Add assert for HP bar colors

* Assert LINK_NULL == 0

* Fix assert syntax

* Add asserts for WILD_BATTLE == 1

* Add additional WILD assert

- I need to sleep more...

* Revert asserts for WILD_BATTLE and LINK_NULL

* Commit suggested changes

* Add more assert cases

* Fix syntax error
 2024-04-27 12:17:07 -05:00
SnorlaxMonster b9dce73573
Rename `MON_ID` to `MON_OT_ID` (#1114) 
* Rename MON_ID to MON_TRAINER_ID

The constant name MON_ID implies it relates to the ID number of the
Pokémon itself. However, it actually refers to the Trainer ID number of
the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it
substantially more clear what its purpose is.

The original definition of MON_ID is preserved in macros/legacy.asm

* Remove MON_ID from macros/legacy.asm

Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>

* Apply rename to missed file

* Rename to `MON_OT_ID`

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
 2024-04-27 12:16:34 -05:00
vulcandth b0b5ed2eb8
Fix/update sprite y-coord offscreen definitions (#1108) 2024-04-14 15:55:46 -05:00
mid-kid e8079e6d48 Use "pkg" in termux instructions instead of "apt" directly 2024-04-06 08:59:21 +02:00
Rangi42 c1da20e2f1 Disable LodePNG auto-encoding the bpp2png image 2024-03-04 10:29:38 -05:00
Damien Doury 9ea843b8a4
Fixed wrong text label (#1107) 2024-01-29 18:59:46 -05:00
Rangi42 fdae742766 Legacy support for `refreshscreen` and `reloadmappart` 2024-01-29 18:58:05 -05:00
xCrystal 17d3a1a8ae Address PR suggestions (#1078) 2024-01-28 21:19:32 +01:00
xCrystal e0c278a595 Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission (#1078) 2024-01-07 14:51:27 +01:00
xCrystal 7f3b87950a more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap (#1078) 2024-01-07 14:37:46 +01:00
xCrystal f72f078c0e Rename wVramState to wStateFlags and use flag constants (#1078) 2024-01-07 14:27:22 +01:00
xCrystal 5be9856f3a In labels, stick to Place for text without delay, and Print for text with letter delay (#1078) 2024-01-07 14:06:40 +01:00
xCrystal cd28c44ff3 Improve some innacurate function names, labels, and comments (#1078) 
[https://github.com/pret/pokecrystal/issues/1078#issuecomment-1872396250]
 2024-01-07 13:36:28 +01:00
xCrystal bd6ceec193 Improve some innacurate function names, labels, and comments (#1078) 
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
 2024-01-07 13:36:05 +01:00
Rangi dbf6044650
Update to RGBDS 0.7.0 (#1101) 2024-01-03 10:58:53 -05:00
vulcandth 30739842af Document Tackle is missing part of its hit animation 
Co-Authored-By: SoupPotato <22991349+SoupPotato@users.noreply.github.com>
 2024-01-03 15:41:28 +01:00
Idain bbfb4ab60e Fix magic numbers in Celebi event code 2024-01-03 15:34:29 +01:00
Rangi42 804fa846e0 Fix bug doc formatting 2024-01-01 21:47:57 -05:00
SoupPotato 184c53e8ca
Document `SFX_RUN` does not play correctly when a wild Pokemon flees from battle (#1099) 
Co-authored-by: SoupPotato <22991349+SoupPotato@users.noreply.github.com>
 2024-01-01 20:25:30 -06:00
mid-kid 9a917e3576 Clarify windows versions in INSTALL.md 2023-11-23 21:00:09 +01:00
Rangi42 04e23a8d56 Refactor tools/dupeframes.py 2023-11-23 00:14:10 -05:00
Rangi42 0fc938c746 charmap.asm should come first so other files can use them 2023-11-22 20:55:47 -05:00
Rotekoppen c99951b3d8 Update install instructions for Arch Linux 
RGBDS is now available in the official repos as community/rgbds
 2023-11-21 16:58:30 -06:00
SnorlaxMonster a82dfd81bb
Replace "¯" and "%" (breakable whitespace) with more meaningful charmap names (#1094) 2023-11-19 20:04:45 -05:00
vulcandth 05083d6fd2 Move charmap.asm to constants/ 
Resolves #1090
 2023-11-17 21:59:32 -06:00
AnonymousRandomPerson 9cbd6ca5e1
Replaced decomp list with pret.github.io link (#1081) 
* Replaced decomp list with pret.github.io link

* Added back Discord link
 2023-11-17 20:22:40 -06:00
Idain 2907d65a47
Improve use of palette macro and use PAL_* constants (#1087) 
* Improve use of palette macro and use PAL_* constants

* Use proper constant for battle stats (#1088)

* Add suggestions about function names and variables

* Add colors macro

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
 2023-11-17 12:24:09 -06:00
SnorlaxMonster 75f0ad3955
Correct macro for default Mystery Gift item (#1084) 
Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
 2023-11-17 12:18:49 -06:00
Idain 3866716980
Use proper constant for battle stats (#1088) 2023-10-23 14:06:04 -05:00
vulcandth aba1f14044
Sync sprite and battle anim consts/labels (#1055) 
* Sync sprite and battle anim consts/labels

* Add `; 00` comments

* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
 2023-09-17 13:09:28 -05:00
Tiddlywinks b0ddb0758d 1) Fix DECOFLAG order. 2) The doll is Staryu, not Starmie (and the sprite can be either) 2023-09-13 08:08:27 +02:00
vulcandth 0b91f5c656 CI copy `.map` files to symbols branch 2023-08-22 18:47:12 -05:00
SoupPotato 6180be355e
Labeled framesets and related constants (#1063) 
* Labeled Framesets and Constants Related

* Feedback Implemented with PascalCase and Constant Renames

* Fix framset.asm comment spacing

* `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA`

* Feedback applied and labeled 1E & B2

* Fixed SpinningBone

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
 2023-08-21 19:09:23 -05:00
Idain 5db85badf8
Replace hardcoded numbers for stats (#1073) 2023-08-21 10:53:32 -05:00
AnonymousRandomPerson fceffda367 Added newer decomp projects to readme 2023-08-19 13:30:32 +00:00
Rangi 0d899cbd3b
Define all unused type names with `rept` (#1071) 
Fixes #1070
 2023-08-16 10:22:35 -04:00
Rangi f3b31087e3 Use `MAP_CONNECTION_PADDING_WIDTH` in `MACRO connection` 
Fixes #1033
 2023-08-15 19:54:16 -04:00
Rangi 9c0ef02d4b Verify that there aren't too many OAM constants 
Fixes #1062
 2023-08-15 19:45:33 -04:00
Rangi df05357a4d Add dupeframes.py tool to find duplicate animated Pokémon frames 
Fixes #1067
 2023-08-15 19:34:16 -04:00
Rangi a5c36a72c4 Avoid `goto`, support '\r', and fix typo in scan_includes.c 2023-08-15 19:19:15 -04:00
Lorenzooone 8e71632536
Fix segfaults at EOF for scan_includes, and add token/newline checks (#1068) 2023-08-14 12:12:00 -04:00
vulcandth e07a1e7773
Define relationship between map_object and object_events (#1054) 2023-08-14 09:19:25 -05:00
Idain 6926900f0f
Document fix about AI item pointer overflowing (#1066) 2023-08-10 13:29:03 -04:00