Commit Graph

72 Commits

Author SHA1 Message Date
mid-kid fd14253796 Clean up labels in battle/moves/move_effects.asm
There were a lot of unused labels in there, and a few confusing
misnomers around move_effects_pointers.asm. They now match up exactly
with the names in battle_constants.asm.
Also renamed a few effects, to make their purpose clearer, and to match
up with their respective event script commands:
EFFECT_EXPLOSION    -> EFFECT_SELFDESCTRUCT
EFFECT_HAZE         -> EFFECT_RESET_STATS
EFFECT_WHIRLWIND    -> EFFECT_FORCE_SWITCH
EFFECT_BIND         -> EFFECT_TRAP_TARGET
EFFECT_TWINEEDLE    -> EFFECT_POISON_MULTI_HIT
EFFECT_STEEL_WING   -> EFFECT_DEFENSE_UP_HIT
EFFECT_METAL_CLAW   -> EFFECT_ATTACK_UP_HIT
EFFECT_ANCIENTPOWER -> EFFECT_ALL_UP_HIT
2017-11-15 16:36:13 +01:00
yenatch d0d61cb3ab Merge pull request #354 from FredrIQ/comments
Fix a reversed label mistake and reference a major bug
2017-06-24 17:43:48 -04:00
Ben10do e6ea1889fb
Replace ‘jp [hl]’ with ‘jp hl’
The former is arguably misleading (as you don’t access the memory location in hl to retrieve the jump location), and is consequently deprecated in newer versions of rgbds.

This fix silences these deprecation warnings.
2017-06-09 22:01:10 +01:00
Fredrik Ljungdahl f8455e9b4f Reverse the LastEnemyCounterMove and LastPlayerCounterMove labels
They were swapped
2017-01-08 01:26:48 +01:00
PikalaxALT 050a0162b8 Rename the variable at D264 2016-08-07 18:14:20 -04:00
pikalaxalt 12396874cf HP bar animation addresses and AI switch 2016-05-16 09:36:24 -04:00
pikalaxalt ae36ef2c7f Labeled every function in ROM0 that's referenced in the source 2016-05-10 12:31:49 -04:00
pikalaxalt 3713b71d9e More splitting of main.asm; remove unneeded rept 2 2016-05-04 11:46:23 -04:00
pikalaxalt 6be4cd4da9 Local labels starting with lowercase letters are no longer decorated with a trailing colon 2016-04-10 15:01:49 -04:00
pikalaxalt bf73772a56 Local labels starting with capital letters are now decorated with a trailing colon; remove trailing whitespace; globally correct line endings to UNIX style 2016-04-10 14:42:14 -04:00
PikalaxALT 599e6e8d16 Battle animation annotations 2016-03-01 22:31:21 -05:00
PikalaxALT 2ed6c357af More WRAM tidying 2016-01-12 12:46:18 -05:00
PikalaxALT 2bd45ca574 Move effects; no more reloadmapmusic, returnafterbattle 2015-12-26 19:22:27 -05:00
PikalaxALT 3d36f1a837 Events and some WRAM cleanup 2015-12-18 20:07:09 -05:00
PikalaxALT acd92eee94 Pack 2015-12-13 14:15:16 -05:00
PikalaxALT 8612a4a531 Renaming sections, further dissolving main.asm 2015-11-28 15:13:40 -05:00
PikalaxALT 8fb01de917 No more DefaultFlypoint 2015-11-10 19:51:13 -05:00
PikalaxALT d13fb46d40 enum macros/move_anim.asm, resolve battle/anims.asm function labels 2015-11-10 16:53:37 -05:00
PikalaxALT 59d67a44be Attempting to decode AI switching 2015-11-08 19:09:36 -05:00
PikalaxALT ac824f62fc More battle core labels 2015-11-08 13:27:26 -05:00
PikalaxALT c34264ddd8 AI and player items, withdraw/deposit 2015-11-08 10:59:28 -05:00
PikalaxALT 6a570ebb8e more battle core labels 2015-11-07 21:04:54 -05:00
PikalaxALT 2cbb1acc6e Pokemon animations 2015-11-07 09:48:32 -05:00
PikalaxALT e044580669 battle/ai/switch.asm and more battle/effect_commands.asm 2015-11-07 08:05:57 -05:00
PikalaxALT d8aa438644 More battle command labels 2015-11-06 20:55:16 -05:00
PikalaxALT 46e66077a5 BattleCommand labels copied from macros 2015-11-06 14:45:10 -05:00
PikalaxALT f0830f084f BATTLEACTION constants 2015-11-06 09:04:27 -05:00
PikalaxALT 5eed48f05d Some battle labels 2015-11-05 19:13:09 -05:00
PikalaxALT 739bb3c136 Replace party struct relative values with EQUS constants 2015-11-04 11:31:00 -05:00
JimB16 9a9cb38e39 merge with newest update 2015-10-26 03:26:53 +01:00
JimB16 3b9a3cc3be merge conflicts resolved 2015-10-19 16:25:15 +02:00
PikalaxALT 0a244e043c Move battle start animation functions to its own file 2015-10-19 10:23:58 -04:00
JimB16 4b722eb530 changed name of some labels 2015-10-10 13:45:39 +02:00
PikalaxALT 96b0e448c4 Labeling of AI item and wild encounter functions 2015-10-07 21:27:32 -04:00
PikalaxALT edf42a54d5 More labels, including fns responsible for partymon generation 2015-10-07 13:19:41 -04:00
JimB16 0001c688d3 found functions that determine next OTPkmn 2015-09-12 04:21:00 +02:00
JimB16 a7cb2a5e9b changed more labels 2015-09-10 01:27:07 +02:00
JimB16 c76a3c6ecd changed more labels 2015-09-04 22:30:40 +02:00
JimB16 706f289c70 change more labelss 2015-08-25 01:56:30 +02:00
PikalaxALT 471492b775 Reverted ld_hl_pointer macro 2015-07-20 22:18:18 -04:00
PikalaxALT 60cd04b023 Trainer data structure and field move functions
Trainer data in map scripts is now a macro-defined structure.

Field move functions in main.asm are now nearly completely annotated, with local references.

Trailing white space deleted.
2015-07-18 23:45:39 -04:00
IIMarckus 4d532beee6 Remove trailing newlines. 2015-06-23 12:24:51 -06:00
yenatch 8e03321069 Blindly use wram labels for everything except mobile, part 1.
Wram banks and mobile make this tough, since any address can secretly be a ghost.

As usual, mobile completely disregards 99% of the codebase. It's been ignored in kind.
2015-02-10 00:53:03 -08:00
yenatch 81e2a3f0cf Merge remote-tracking branch 'xcrystal/master' into master
Conflicts:
	battle/ai/scoring.asm
	main.asm
2014-10-23 02:41:52 -04:00
xCrystal dd8653fe6f More AI commentary/labels 2014-10-22 23:08:51 +02:00
xCrystal bb9818e3c3 More AI commentary/labels 2014-10-22 17:36:42 +02:00
xCrystal bf60a6b690 evasionup, accdown, whirlwind, haze 2014-10-22 14:47:33 +02:00
xCrystal 7cbec0d52a More AI commentary/labels 2014-10-22 00:28:51 +02:00
xCrystal 96a89ffad7 More AI commentary 2014-10-21 20:44:42 +02:00
xCrystal 44377acb2a Rename labels and add more commentary to AI stuff 2014-10-21 19:21:13 +02:00