Commit Graph

4621 Commits

Author SHA1 Message Date
Rangi 10909e6b43 hStackBank -> hTempBank 2020-04-06 13:02:23 -04:00
Rangi 1ec60810b8 hBuffer -> hStackBank and hFarByte 2020-04-06 12:52:46 -04:00
Rangi 9076d63d62
Merge pull request #705 from Rangi42/master
Upgrade to rgbds 0.4.0, and do miscellaneous fixes
2020-04-06 12:41:44 -04:00
Rangi 3144b54bd1 Enable rgbds warnings and remove CFLAGS=-O2 (default is now -O3) 2020-04-06 12:41:07 -04:00
mid-kid e225d296b7 Bump tools/unnamed.py to RGBDS object version 13 2020-04-06 14:58:49 +02:00
Rangi 95e48ef992 Add an FAQ about sharing code 2020-04-04 16:25:58 -04:00
Rangi 0ef004a4db `dsprite y, ypx, x, xpx, off, attr` -> `dbsprite x, y, xpx, ypx, off, attr` 2020-04-04 16:00:30 -04:00
Rangi 79184bc718 Miscellaneous fixes:
- `hSecondsBackup` -> `hUnusedBackup`
- `ld bc, hBGMapAddress + 1` -> `bccoord -1, -2, 0`
- Identify some `.asm_XXX` labels
2020-04-04 15:43:10 -04:00
Rangi 3cdfac7994 Move, comment, and simplify some macro definitions 2020-04-04 15:32:18 -04:00
Rangi 0ee9d7a48b Upgrade to rgbds 0.4.0
- fail for rgbds < 0.4.0
- `rst <Label>`
- `ds <count>, <byte>`
- `shift <N>`
- ASCII "\r"
- Sorted .sym file
2020-04-04 15:15:02 -04:00
mid-kid a325db0f14
Merge pull request #704 from LIJI32/gfx_bugfix
(gfx.c) Fix several out-of-bound reads in; fix a memory leak
2020-04-02 21:19:09 +02:00
Lior Halphon 2af6c63253 Fix bad round, memset VLA 2020-04-02 22:02:20 +03:00
Lior Halphon 79f3f3f4d5 Indentation conventions, use C99 variable length arrays 2020-04-02 21:10:20 +03:00
Lior Halphon 7878dd6d4b Fix several out-of-bound reads; fix a memory leak 2020-04-02 20:59:19 +03:00
Andrew Cook 5d97f15f80
Assorted labels in mobile related code (#702)
Rename assorted labels in mobile-related code
2020-03-31 21:26:59 -04:00
Rangi 63798d56d0
Merge pull request #699 from Rangi42/master
Resolve some miscellaneous issues
2020-03-23 21:05:39 -04:00
Rangi 0345e4fb0e Add suffixes to some constants to avoid ambiguity
- `PSYCHIC` → `PSYCHIC_TYPE` (not the trainer `PSYCHIC_T` or the move `PSYCHIC_M`)
- `BLACKBELT` → `BLACKBELT_I` (not the trainer `BLACKBELT_T`)
- `CURSE_T` → `CURSE_TYPE` (not the move `CURSE`)
- `TOWN_MAP_D` → `TOWN_MAP_POSTER` (not the item `TOWN_MAP`)

This also uncovered a misidentified event: `EVENT_DECO_PLANT_4` → `EVENT_DECO_POSTER_1`. (There are three plants and four posters.)
2020-03-21 17:59:26 -04:00
Rangi adbe7f995c Remove some redundant comments superseded by labels (see #693) 2020-03-21 14:14:48 -04:00
Rangi 7558b98a81 Revert the broken CheckTypeMatchup bugfix simplification from 5728d01417 2020-03-21 14:03:38 -04:00
Rangi 6a6ba10315 rgbds supports 'X - 1' instead of 'X + -1' 2020-03-21 14:01:05 -04:00
Rangi 5a5f5ececd Miscellaneous fixes from #694 2020-03-21 13:07:18 -04:00
Rangi 624864307e Combine Celebi frames into one PNG 2020-03-16 08:58:28 -04:00
Rangi 66b902f900
Merge pull request #696 from Rangi42/master
Rename LANDMARK_* constants, and refactor flypoints
2020-03-15 19:53:14 -04:00
Rangi ad50e94b50 Add a `LANDMARK_` prefix to landmark constants
Resolves #697
2020-03-15 19:50:39 -04:00
Rangi 65f22544e0 Refactor flypoints to separate const definition from data usage 2020-03-15 14:10:53 -04:00
Rangi c87f8512a4 Add tools/used_space.py to visualize the ROM based on the .map file 2020-03-11 17:10:06 -04:00
Rangi 8eba39dd52 Add tools/used_space.py to visualize the ROM based on the .map file 2020-03-11 15:06:34 -04:00
mid-kid 1d122c86cf
Merge pull request #692 from Rangi42/master
Change how some PNG graphics are formatted
2020-03-01 23:39:53 +01:00
Rangi f09b68d945 Change how some PNG graphics are formatted 2020-03-01 17:00:57 -05:00
Rangi 9bec0e0f78
Merge pull request #691 from Rangi42/master
Identify remaining gfx/unknown files, and document a Teleport bug
2020-02-28 11:58:18 -05:00
Rangi 1d4c1aeef4 'and BANK' -> 'aka BANK' 2020-02-28 11:51:42 -05:00
Rangi 0cce00cb73 Document a bug where Teleport cannot fail for wild Pokémon 2020-02-28 11:17:58 -05:00
Rangi 447da80615 Identify remaining gfx/unknown files 2020-02-28 09:23:41 -05:00
Rangi 81eaf83cd7 Identify gfx/unknown/4985a.asm as gfx/tilesets/forest-tree/unused.png 2020-02-26 15:41:22 -05:00
Rangi 75a537ed1e Fix some comments and whitespace 2020-02-26 08:41:12 -05:00
Rangi 754268c691
Merge pull request #690 from Rangi42/master
Identify some labels and constants for Battle Tower
2020-02-25 19:44:07 -05:00
Rangi a73ced3b69 unused_dark_cave -> unused_johto (goes with the beta Johto town+city maps) 2020-02-25 19:18:24 -05:00
Rangi ee622d6ba1 Identify some labels and constants for Battle Tower 2020-02-25 18:13:50 -05:00
Rangi 4ab60eb2d2
Merge pull request #689 from mid-kid/master
Fix Mac OSX install instructions
2020-02-25 16:27:57 -05:00
mid-kid e799515931 Fix SRAM references in Function140ae 2020-02-25 19:38:24 +01:00
mid-kid c5f22b782b Fix Mac OSX install instructions 2020-02-25 19:38:01 +01:00
mid-kid 25794633f1
Merge pull request #688 from Rangi42/master
Edit some comments about bad code
2020-02-24 00:58:44 +01:00
Rangi c3f389d615 Replace some "idiotic", "wtf", "stupid interns" comments with more common "useless", "pointless", "could have done X instead" 2020-02-23 18:51:32 -05:00
Rangi 62fccbbd99 Remove empty .gitmodules 2020-02-23 15:15:07 -05:00
Rangi 2238f52197 Fix build with rgbds 0.3.9 release 2020-02-23 14:28:35 -05:00
Rangi ef1c4c5a81
Merge pull request #687 from mid-kid/master
Small home/ reorganization
2020-02-23 14:16:26 -05:00
mid-kid 813d0aa73a Fix the sections in home/header.asm
They're fixed anyway, and this allows us to make some expressions
constant.
2020-02-23 20:11:54 +01:00
mid-kid c0b6e5bc21 JoypadInt -> Joypad
This matches all other interrupts. The old Joypad was renamed to
UpdateJoypad.
2020-02-23 14:33:53 +01:00
mid-kid 44128c5d98 Create home/header.asm
Contains what was previously in:
- home/rst.asm
- home/interrupts.asm
- home.asm

All of this should be in a static location in the ROM so it kinda makes
sense together.
2020-02-23 14:28:21 +01:00
mid-kid 7bd8d56ff9 Implement suggestions in PR #687
Merge mon_stats.asm, cry.asm, print_level.asm, and mon_data.asm into pokemon.asm
Merge mon_party.asm into battle.asm
Merge menu.asm, menu_window.asm, and menu2.asm into menu.asm
2020-02-22 12:52:13 +01:00