Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
4,765 Commits 2 Branches 0 Tags 183 MiB
Commit Graph

437 Commits

Author SHA1 Message Date
Rangi ff2d850219 Identify some more unnamed labels 2020-10-05 12:02:56 -04:00
Rangi 306c85750e Identify some more unnamed labels 2020-10-04 20:10:39 -04:00
Rangi 0b31d12dac
Merge pull request #756 from mid-kid/master 
Rub a dub dub, thanks for the grub
 2020-08-18 16:35:15 -04:00
ISSOtm e0b783bb7b Enable compatibility with upcoming RGBASM version 
This is additionally required, because an `elif`'s condition is evaluated even
when it's about to be skipped over, and this `"\2"` will become an error
 2020-08-18 13:41:59 +02:00
Rangi 9d6ac04c9d "<NULL>" -> 0, for 'and a' 2020-08-17 16:29:08 -04:00
Rangi 328a6737db Use ISCONST for future rgbds lexer compatibility 2020-08-17 13:02:49 -04:00
mid-kid b6055b1944 Use TRUE for hCGBPalUpdate 2020-08-05 16:02:48 +02:00
mid-kid 6f30d79620 TX_NUM -> TX_DECIMAL 2020-08-03 23:35:18 +02:00
mid-kid 79bb2784e9 Better label 2D menu data 2020-08-03 22:56:49 +02:00
Rangi e239aa4aba Disassemble the final English debug ROM 2020-07-13 15:18:28 -04:00
Rangi b3bd682366 text_linkpromptbutton -> text_waitbutton 
Removes support for text_waitbutton as a legacy alias for text_promptbutton.
 2020-07-06 12:55:31 -04:00
Rangi f5ac9b0eb7 SCGB_PARTY_MENU_HP_PALS -> SCGB_PARTY_MENU_HP_BARS, and SCGB_RAM -> SCGB_DEFAULT 2020-07-04 16:18:16 -04:00
Rangi fce6243b43 Identify more labels, and use the jumptable macro when possible 2020-07-01 13:13:49 -04:00
Rangi e171c84c29 Identify more labels and constants 2020-06-29 19:35:47 -04:00
Rangi 61847b3596 Identify some more labels 2020-06-22 16:30:13 -04:00
Rangi e0d07fba3f Sync PokeFluteTerminator with pokegold 2020-06-21 19:01:54 -04:00
Rangi c3c18dd196 Comment more ROM labels as unreferenced 
(Some unreferenced labels are above code which is still used via fallthrough!)
 2020-06-21 18:33:31 -04:00
Rangi 91774f206e Replace "Unreferenced" labels with "; unreferenced" comments 2020-06-21 16:27:43 -04:00
Rangi cc460a17b0 Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM) 
To do: engine/{menus, overworld}
 2020-06-17 17:03:38 -04:00
Rangi f2550fc3c2 ReplaceKrisSprite -> UpdatePlayerSprite 2020-06-16 19:38:00 -04:00
Rangi c552390a15 Harmonize home/ with pokegold 2020-06-16 15:49:32 -04:00
Rangi b9f2b93c17 Harmonize some more symbols with pokegold 2020-06-16 11:28:52 -04:00
Rangi f1513ae8ad Add some comments to UpdateBGMap 2020-05-19 20:00:58 -04:00
Rangi 156f2cc3ef Update some routine labels, including unreferenced ones 2020-05-18 11:59:48 -04:00
Rangi e32cf1bfd1 Miscellaneous cleanup noted in #709 2020-05-17 20:59:15 -04:00
Rangi 395ebd8386 Format all CopyTilemapAtOnce variations the same way 2020-05-16 22:25:52 -04:00
Rangi b69526a908 Miscellaneous fixes 
Addresses the haircut brothers' probability comments in #709
 2020-05-05 10:17:02 -04:00
Rangi 576cbf5b3e Miscellaneous fixes, including one for the Pokédex design flaw by ax6 2020-04-18 17:31:51 -04:00
Rangi 58b377f25b Fix #709 miscellaneous issues 2020-04-16 09:30:50 -04:00
Rangi a40ddc4668 Ensure that the cartridge header is patched over all $00s, and comment on the entry point format 2020-04-06 14:44:07 -04:00
Rangi 10909e6b43 hStackBank -> hTempBank 2020-04-06 13:02:23 -04:00
Rangi 1ec60810b8 hBuffer -> hStackBank and hFarByte 2020-04-06 12:52:46 -04:00
Rangi 79184bc718 Miscellaneous fixes: 
- `hSecondsBackup` -> `hUnusedBackup`
- `ld bc, hBGMapAddress + 1` -> `bccoord -1, -2, 0`
- Identify some `.asm_XXX` labels
 2020-04-04 15:43:10 -04:00
Rangi 0ee9d7a48b Upgrade to rgbds 0.4.0 
- fail for rgbds < 0.4.0
- `rst <Label>`
- `ds <count>, <byte>`
- `shift <N>`
- ASCII "\r"
- Sorted .sym file
 2020-04-04 15:15:02 -04:00
Rangi 6a6ba10315 rgbds supports 'X - 1' instead of 'X + -1' 2020-03-21 14:01:05 -04:00
Rangi ad50e94b50 Add a `LANDMARK_` prefix to landmark constants 
Resolves #697
 2020-03-15 19:50:39 -04:00
Rangi 447da80615 Identify remaining gfx/unknown files 2020-02-28 09:23:41 -05:00
Rangi 75a537ed1e Fix some comments and whitespace 2020-02-26 08:41:12 -05:00
Rangi c3f389d615 Replace some "idiotic", "wtf", "stupid interns" comments with more common "useless", "pointless", "could have done X instead" 2020-02-23 18:51:32 -05:00
Rangi 2238f52197 Fix build with rgbds 0.3.9 release 2020-02-23 14:28:35 -05:00
mid-kid 813d0aa73a Fix the sections in home/header.asm 
They're fixed anyway, and this allows us to make some expressions
constant.
 2020-02-23 20:11:54 +01:00
mid-kid c0b6e5bc21 JoypadInt -> Joypad 
This matches all other interrupts. The old Joypad was renamed to
UpdateJoypad.
 2020-02-23 14:33:53 +01:00
mid-kid 44128c5d98 Create home/header.asm 
Contains what was previously in:
- home/rst.asm
- home/interrupts.asm
- home.asm

All of this should be in a static location in the ROM so it kinda makes
sense together.
 2020-02-23 14:28:21 +01:00
mid-kid 7bd8d56ff9 Implement suggestions in PR #687 
Merge mon_stats.asm, cry.asm, print_level.asm, and mon_data.asm into pokemon.asm
Merge mon_party.asm into battle.asm
Merge menu.asm, menu_window.asm, and menu2.asm into menu.asm
 2020-02-22 12:52:13 +01:00
mid-kid 43eff93861 Small home/ reorganization 
Time to move everything out of home.asm:
- InexplicablyEmptyFunction was moved to home/map.asm
- The wDebugFlags functions and xor_a brothers were moved to
  home/flag.asm because they're all flag-related.
- ret_2f3e was moved into home/region.asm
- The register alias sisters were moved to a new file called home/call_regs.asm
- IsInArray and SkipNames were joined by AddNTimes from home/math.asm
  into home/array.asm, as they're all used to index arrays.
- CallPointerAt was moved into home/print_text.asm because given the
  contents of that file it doesn't feel very out of place (that file
  isn't very aptly named...)
- CountSetBits was moved into home/pokedex_flags.asm because it's unique
  use is counting the amount of seen/caught mon in the podedex. GetWeekday
  was pulled into this by proximity.

Other changes were also made:
- PushLYOverrides was moved from home/sprite_anims.asm to
  home/battle.asm, because it's almost exclusively used for battle
  animations, with the lone exception being the Magnet Train.
- home/copy.asm was renamed to home/gfx.asm, as it's all gfx-related
- home/copy2.asm was renamed to home/copy.asm, now it's the only file
  called copy.
- SetHPPal and GetHPPal were moved from home/hp_pals.asm to
  home/tilemap.asm, as they're attrmap related, like many functions in
  that file are.
- home/rtc.asm was renamed to home/time_palettes.asm, as it had very
  little to do with the RTC at all, all RTC functions being in home/time.asm
- home/handshake.asm was renamed to home/printer.asm.
- home/mon_data_2.asm was renamed to home/mon_party.asm.
 2020-02-22 00:23:47 +01:00
mid-kid 9a927c1b3e
Merge pull request #685 from mid-kid/master 
Moshi moshi? minoru enhansumentsu desu
 2020-02-21 21:11:36 +01:00
mid-kid 345b585a78 Document GetTMHMName locals 
This was documented in pokegold apparently
 2020-02-21 21:10:43 +01:00
mid-kid c22e268083 RTC -> UpdateTimeAndPals 
Rename clear misnomer.
Most of the related functions in that file aren't really aptly named but
I don't know good names right now.
 2020-02-21 18:21:29 +01:00
mid-kid 75a6bb5df6 PanicResetClock -> ClearClock 
Funky name that only exists based on what it's used for, not so much
what it is.
 2020-02-16 12:20:20 +01:00
Rangi 88bbdb6a2f Define TileCollisionTable as a standard 'db' series 2020-02-13 19:07:19 -05:00