Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
4,821 Commits 2 Branches 0 Tags 183 MiB
Commit Graph

4821 Commits

Author SHA1 Message Date
aljohnston112 7b9d8767d4
Identified two magic numbers and cleaned up some comments (#783) 
Improve the audio engine's comments and replace some magic numbers with constants
 2020-12-07 12:44:16 -05:00
Rangi 5e9d43e39b text "<PARA>..." → text_start and para "..." 2020-12-04 22:28:31 -05:00
Rangi ad6effee82 Don't hardcode CRCs within Crystal base data 2020-11-30 11:32:19 -05:00
Rangi 4613bcfadf Use STRING_BUFFER_LENGTH for the wStringBuffers 2020-11-24 20:11:17 -05:00
Rangi 4ca9f45db7 Fix tools/free_space.py 2020-11-21 21:14:32 -05:00
Rangi 145e752266 Use assert to ensure correct base data size 2020-11-17 16:14:45 -05:00
Rangi 97e981985b Correct some filename comments 2020-11-17 11:12:21 -05:00
Rangi 9b3c45b14d Resolve some "???" comments 2020-11-17 11:09:02 -05:00
Rangi cd3fb2ca72 sRTCStatusFlags is one byte 2020-11-09 16:38:21 -05:00
Rangi fa3712ea34 Remove "XXX" comments (various "???+" still mark unclear code) 2020-11-09 16:38:11 -05:00
Rangi 6a5edc98e9 Terser damage calculation constants 2020-11-09 16:12:19 -05:00
Rangi 17894e5f39 Replace $0 with 0 for "ld l, a / ld h, 0" idiom 2020-11-09 15:20:40 -05:00
Rangi 03e149e559 Identify wBattleAnimTemp0-3 2020-11-09 15:05:14 -05:00
Rangi 62b756c46e Rename "dummy game" to "memory game" 2020-11-08 19:32:57 -05:00
Rangi 7254c10093 Identify remaining uses of wBuffer1-6 as general-purpose HP buffers or mobile 2020-11-03 23:25:22 -05:00
Rangi a831b34e5c Identify some uses of wBuffer1-6 in new Crystal code 2020-11-03 22:52:50 -05:00
Rangi 9f62d7911b Identify some more uses of wBuffer1-6 2020-11-03 22:45:12 -05:00
Rangi c88c4a8340 Identify more uses of wBuffer1-6 2020-11-03 19:53:07 -05:00
Rangi 826e070f04 More syncing with pokegold 2020-11-03 10:13:06 -05:00
Rangi 01d6e6c758 Group some link.asm code into "paragraphs" 2020-11-02 19:32:14 -05:00
Rangi 1756a553f7 Group link-related WRAM labels together 2020-11-02 10:33:49 -05:00
Rangi 9ab9088a9f Identify wLinkBattleRNPreamble 2020-11-01 13:42:12 -05:00
Rangi 6220200f0f Identify some more labels, and make some more consistent 2020-11-01 12:36:38 -05:00
Rangi 4a323cf591 UnusedSpriteAnimGFX was to sprite anims as AnimObjGFX is to battle anims 2020-10-30 17:41:03 -04:00
Rangi 9b0002161b Extract more RGB data to .pal files 2020-10-30 16:12:25 -04:00
Rangi fe1a58deea Identify wSpriteAnimDict key constants 2020-10-30 15:39:08 -04:00
Rangi 7a42f1790a
Merge pull request #776 from Rangi42/unreferenced 
Comment, remove, or revise many unreferenced labels
 2020-10-30 12:26:03 -04:00
Rangi 1092983bde Refer to rgbds' own install instructions 2020-10-30 11:28:48 -04:00
Rangi 1237156948 Identify mobile Name Card exchange labels 2020-10-30 10:45:31 -04:00
Rangi ba5bc304f9 Updates to more closely sync with pokegold 2020-10-29 23:23:57 -04:00
Rangi 7883e8f431 Define SERIAL_LINK_BYTE_TIMEOUT 2020-10-29 16:43:28 -04:00
Rangi a51b1a2f13 Port more pokegold link engine symbols, and name an unused WRAM byte 2020-10-29 15:15:14 -04:00
Rangi bcc0d633e9 Identify the remaining (non-mobile) uses of another WRAM union 2020-10-29 14:51:41 -04:00
Rangi ea426a8879 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:34:38 -04:00
Rangi 6d333bed5f Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:10 -04:00
Rangi 446f1846b1 Identify remaining Mystery Gift labels and constants 
Source: https://projectpokemon.org/home/forums/topic/43930-mystery-gift-reverse-engineering-of-ir-protocol/
 2020-10-27 23:09:06 -04:00
Rangi 2738858985 Create data/collision/ for tile collision-related data 2020-10-27 10:00:56 -04:00
Rangi 66ddeeff6c Update the style guide with new conventions and rgbasm possibilities 2020-10-26 22:35:40 -04:00
Rangi c85ba78b77 Use more assertions to ensure correct code and data 2020-10-26 22:24:38 -04:00
Rangi 9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
Rangi a2b6befd7d Identify some more labels, mostly WRAM 2020-10-23 16:04:15 -04:00
Rangi 7991db972b Identify some more link.asm labels (syncing to pokegold) 2020-10-23 13:36:54 -04:00
Rangi 8a73bb9ab2 Identify remaining debug color picker labels 2020-10-23 12:38:07 -04:00
Rangi bd3f634049 Identify remaining map object labels 2020-10-22 21:30:21 -04:00
Rangi d8310c166d Identify some more map object labels and constants 2020-10-22 17:41:48 -04:00
Rangi 15f6a0af43 Identify a few more labels and data 2020-10-22 12:55:46 -04:00
Rangi b9a74ff777 Identify more sprite graphics and map object labels, and have consistent anonymous jumptable labels 2020-10-22 10:54:53 -04:00
Rangi ae4fe08084 Identify some more labels (a few link-related) 2020-10-22 00:53:54 -04:00
Rangi 3a2932cec1 Identify remaining two battle anim BG effect functions 2020-10-21 22:51:24 -04:00
Rangi f954c61668 Remove incomplete fix for the save corruption bug 2020-10-21 21:54:44 -04:00