Commit Graph

328 Commits

Author SHA1 Message Date
Rangi 4613bcfadf Use STRING_BUFFER_LENGTH for the wStringBuffers 2020-11-24 20:11:17 -05:00
Rangi a831b34e5c Identify some uses of wBuffer1-6 in new Crystal code 2020-11-03 22:52:50 -05:00
Rangi bcc0d633e9 Identify the remaining (non-mobile) uses of another WRAM union 2020-10-29 14:51:41 -04:00
Rangi f954c61668 Remove incomplete fix for the save corruption bug 2020-10-21 21:54:44 -04:00
Rangi 034729bdfe Note that the map connection Surf bug fix will change the movement speed 2020-09-27 12:46:42 -04:00
Rangi 1357e0d674 Fix #769: document the Heavy Ball weight bank bug 2020-09-27 12:39:27 -04:00
Rangi e9767dcfa8 More optimal fix for the experience underflow bug 2020-09-27 12:31:59 -04:00
Rangi cf37abd3ec Remove wKickCounter and wPresentPower aliases for wBattleAnimParam 2020-08-29 20:35:49 -04:00
Rangi 622eeb5439 Group bugs and glitches by category 2020-08-29 19:54:57 -04:00
Rangi 5ccae8a69c Fix #767: Clarify battle moves menu bug behavior 2020-08-29 12:52:12 -04:00
Rangi 77d97a04d5 Note possibly intentional "bugs" 2020-08-28 21:38:46 -04:00
Rangi cab4cd10b0 Close #763 and #764: document two more bugs/oversights 2020-08-28 14:31:49 -04:00
Rangi 7233c19f57 Add a template for maps/*.asm 2020-08-13 14:46:35 -04:00
Rangi 8003084cd5 HappinessData_DaisysGrooming uses percent macro 2020-08-03 18:56:56 -04:00
Rangi dcb24bc724 Use def_* macros for automatic map event counts
Resolves #742
2020-07-24 09:57:16 -04:00
Rangi 11dc805de0 Revert "Factor out tables into data/overworld/"
This reverts commit b5a7e7de3e.
2020-07-22 20:21:26 -04:00
Rangi b5a7e7de3e Factor out tables into data/overworld/
Fixes #749
2020-07-22 15:22:58 -04:00
Rangi ef452ccbc7 return → endcallback, reloadandreturn → reloadend 2020-07-17 08:37:03 -04:00
Rangi eca33ef190 Define map setup commands as macros like other script commands 2020-07-13 20:44:16 -04:00
Rangi b3bd682366 text_linkpromptbutton -> text_waitbutton
Removes support for text_waitbutton as a legacy alias for text_promptbutton.
2020-07-06 12:55:31 -04:00
Rangi 9433b5a752 Remove RAM address comments 2020-06-20 23:03:40 -04:00
Rangi cc460a17b0 Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM)
To do: engine/{menus, overworld}
2020-06-17 17:03:38 -04:00
Rangi f2550fc3c2 ReplaceKrisSprite -> UpdatePlayerSprite 2020-06-16 19:38:00 -04:00
Rangi b50dd57cbb Miscellaneous updates and corrections 2020-04-23 16:14:50 -04:00
Rangi 576cbf5b3e Miscellaneous fixes, including one for the Pokédex design flaw by ax6 2020-04-18 17:31:51 -04:00
Rangi 164e1b89af Rename pokecrystal.link to layout.link
This is independent of the project name, and clearly applies to pokecrystal11, pokecrystal-au, etc.
2020-04-17 11:02:29 -04:00
Rangi 7558b98a81 Revert the broken CheckTypeMatchup bugfix simplification from 5728d01417 2020-03-21 14:03:38 -04:00
Rangi 6a6ba10315 rgbds supports 'X - 1' instead of 'X + -1' 2020-03-21 14:01:05 -04:00
Rangi 0cce00cb73 Document a bug where Teleport cannot fail for wild Pokémon 2020-02-28 11:17:58 -05:00
dannye cbf14612ea Update docs/music_commands.md
to clarify a few caveats about some macro parameters
2020-02-04 20:03:22 -06:00
mid-kid 44b361c1bb Merge branch 'master' into audio-macros 2020-02-04 16:03:01 +01:00
Colton G. Rushton dd6812c06a Optimize the Perish Song+Spikes glitch fix 2020-01-27 19:26:11 +01:00
Colton G. Rushton f369003a6e Add Dude full box glitch fix
Added a minor fix for the Dude full box glitch that was proposed by ISSOtm.
2020-01-23 17:57:19 +01:00
dannye e7be25948d Merge branch 'master' into audio-macros 2020-01-06 22:07:33 -06:00
dannye 99d16d616d Update docs/music_commands.md
and remove the pokered compatibility macros
2020-01-05 15:41:55 -06:00
Rangi 9aeb0ab522 Revise bugs_and_glitches.md 2020-01-04 17:10:26 -05:00
Colton G. Rushton 5728d01417 Add and simplify bugfixes in bugs_and_glitches.md (#664)
Add extra fixes for bugs covered on Bulbapedia (and simplify others)
2020-01-04 16:52:08 -05:00
Rangi 0e311ad709 Fix miscellaneous points made in #658 2019-11-23 20:56:22 -05:00
Eldred Habert 2c6690d10d Update bug fix for AI CheckTypeMatchup assumption (#656)
The bug fix caused all player moves to have Normal-type effectiveness
2019-11-06 22:25:31 +00:00
Rangi 2cf6dc1e0c Fix the fix for the Pokédex footprint design flaw 2019-11-03 14:09:01 -05:00
Rangi 4aeab6b879 Rename buttonsound to promptbutton 2019-11-03 12:48:54 -05:00
bbbbbbbbba 0d48d829d4 Document Special Defense badge boost glitch (#651)
Document Special Defense badge boost glitch
2019-10-20 18:25:34 -04:00
mid-kid e3e0bcd653 #641 fixes and additions. (#646)
Name a lot of text labels according to our conventions
2019-10-20 18:24:17 -04:00
mid-kid 7e84f72403 `end` -> `return` in clair bugfix 2019-06-17 08:05:29 +02:00
mid-kid ad299b1635 Apply suggested changes 2019-06-10 01:52:46 +02:00
mid-kid c048b24d25 Create constants for ScrollingMenu item formats
...I should've done this quite a while ago.
2019-06-09 02:31:24 +02:00
mid-kid 54b87ecea8 Document in-battle move selection menu scrolling glitch
What a mouthful...
2019-06-09 00:17:35 +02:00
Rangi fbc2c55cdb Dark theme colors for @media (prefers-color-scheme: dark) 2019-05-26 11:54:13 -04:00
mid-kid 476f9ba40d Define appropriate constants as EQU
These constants are defined only once and shouldn't be redefined anyway.
2019-05-25 17:59:50 +02:00
Rangi cca2afe827 More fixes for fixes 2019-04-23 19:07:41 -04:00
mid-kid 9281233fc8 Fix Dragon Fang fix 2019-04-23 12:53:49 +02:00
Rangi 745339014c "object_const_def" instead of "const_def 2" 2019-04-21 17:42:25 -04:00
Rangi 45e3f6aca9 Identify some more WRAM labels 2019-04-19 11:35:27 -04:00
Rangi 52651b0afb Use the same GFM Markdown parser for GitHub and GitHub Pages
By default GitHub uses GFM but GitHub Pages uses kramdown, which among other differences, does not support starting ordered lists at specific values.
2019-04-14 13:28:26 -04:00
mid-kid 3e78e5b2b6 TextBox -> Textbox
Homogenizing names.
2019-04-09 16:09:18 +02:00
Rangi 2184b60a0c Identify and eliminate wEngineBuffer1-5 2019-04-08 19:42:55 -04:00
Rangi 179dc85ba1
Merge pull request #616 from Rangi42/master
Minor code+docs fixes
2019-03-14 18:56:39 -04:00
Rangi 2ffbde764e Minor code+docs fixes 2019-03-12 22:55:40 -04:00
DeeDeeG f4c0806eb8
bugs_and_glitches.md: Fix embedded image links 2019-03-12 14:37:24 -04:00
DeeDeeG 67ff4b0c94
bugs_and_glitches.md: Minor formatting fix
Moves newline to correct spot so diff can apply cleanly.
2019-03-10 23:40:21 -04:00
Rangi 2deb46b3f3 Relative links actually work here for github.com and pret.github.io 2019-03-10 23:08:05 -04:00
Rangi a8c0b64afa Fix index.md Pages links 2019-03-10 23:04:07 -04:00
Rangi 2d3c5cfd6a Fix wiki link 2019-03-10 23:01:24 -04:00
Rangi 6289232447 Second try at fixing doc links 2019-03-10 23:00:01 -04:00
Rangi 70ef2f3432 Fix documentation links to work with GitHub Pages 2019-03-10 22:43:57 -04:00
Rangi 388e5a2a78 Add an index.md home page for GitHub Pages 2019-03-10 22:14:27 -04:00
Rangi 8e2f5f00aa Set theme jekyll-theme-hacker 2019-03-10 19:44:57 -04:00
Rangi f5c9958aea Rename some call/jump script commands to avoid confusion with jr/jp asm instructions
Fixes #580
2019-03-10 16:39:31 -04:00
Rangi e002b536af Rename more script commands for consistency and predictability
Fixes #540
2019-03-10 16:00:19 -04:00
Rangi 6393ecb7e5 More consistent formatting 2019-03-03 19:55:28 -05:00
Rangi 9e9f43bce7
Merge pull request #610 from ISSOtm/pursuit_fix
Fix Confusion and Pursuit bugs in #603
2019-03-03 19:31:47 -05:00
ISSOtm f6e94dfd79 Fix spaces 2019-03-04 00:21:30 +01:00
ISSOtm d79fca8c6e Add Pursuit-switching fainting no-status-clearing fix
Ridiculously long and stupid name for a bug that took a ridiculous and stupid amount of time to track. :')
2019-03-04 00:01:55 +01:00
ISSOtm bc9d073501 Add confusion + items/selfdestruct fix 2019-03-03 21:49:52 +01:00
Eldred Habert 6b8abd1af1
Correct compatibility claims 2019-03-03 20:35:29 +01:00
Eldred Habert 64d8a2b8fe
Correct Thick Club overflow fix
Would, similarly as previous commit, cap incorrectly.
2019-03-03 18:48:24 +01:00
Eldred Habert ce7e955d10
Correct Metal Powder fix
The cap would be applied when it shouldn't - if the high byte was below `HIGH(MAX_STAT_VALUE)` (and thus the value below the cap) but the low byte above `LOW(MAX_STAT_VALUE)`
2019-03-03 18:36:42 +01:00
Eldred Habert c170810ad4
Correct indentation
Add spaces before unchanged lines
2019-03-03 18:10:03 +01:00
Eldred Habert add58fb00d
Fix "100% secondary effect" fix, add compatibility
The original fix was bugged (example: erroneous `pop hl` if `.failed` was jumped to).
Replaced with a less invasive fix, keeping all side effects from the original function; it's less intuitive, but more performant - and the tricky bit has been commented.
Also the new fix is more friendly to the compatibility patch I also added, by request of ShinyDragonHunter.
2019-03-03 17:27:35 +01:00
Rangi d342bf9b45 Bitter Berry → `BITTER_BERRY` 2019-02-17 13:43:40 -05:00
Rangi a7c655eb67 asm -> diff 2019-02-17 13:39:12 -05:00
Rangi 47495e7d66 Avoid more redundant code and diffs 2019-02-17 13:38:30 -05:00
Rangi fcca48f2a6 Avoid redundant code and diffs 2019-02-17 13:35:38 -05:00
Rangi a999787cb8 Update documentation:
- Apply more edits from #595
- Move music ID behavior from the wiki to docs
- Move assembly programming links from docs to the wiki
- Describe why the TM item gaps exist
2019-02-17 13:18:38 -05:00
Rangi 8e359978d6 passtoengine -> autoinput 2019-02-16 16:06:11 -05:00
Rangi 1dad1b48d4 Fix indentation 2019-02-16 16:00:13 -05:00
Rangi 417f3c7c72 Bug fix: allow Surfing across map connections 2019-02-16 15:45:55 -05:00
Rangi 4ee7e027be Fix link 2019-02-16 14:12:07 -05:00
Rangi 96bcf72d96 Document the BattleAnimCmd_ClearObjs bug 2019-02-16 13:31:23 -05:00
mid-kid 80ece33e3e Document wBattleAnimFlags
`anim_clearsprites` was misnamed, so I renamed it to `anim_keepsprites`,
and documented it in docs/battle_anim_commands.md
2019-02-16 12:55:40 +01:00
Rangi 4fe0d93d4c Fix some of the issues explained in #595 2019-01-27 14:00:21 -05:00
Rangi a5c1d9572c Fix: Clair can give TM24 Dragonbreath twice 2019-01-19 19:27:45 -05:00
Rangi 53c92b4792 Bug: Clair can give TM24 Dragonbreath twice 2019-01-19 19:11:38 -05:00
Rangi 07374f02cc Dif formatting typo 2019-01-07 19:36:56 -05:00
Rangi fe04acad7b Document bugfix: ScriptCall can overflow wScriptStack and crash 2019-01-07 18:28:47 -05:00
Rangi 1b1b0ac6ea Document a bugfix: AI makes a false assumption about CheckTypeMatchup 2019-01-07 18:12:00 -05:00
Rangi 5207615cdc Document a bugfix: 1/256 failure rate for 100% effect chance 2019-01-05 20:30:46 -05:00
Rangi 8f60de5aba Fix a typo 2018-12-31 01:03:38 -05:00
Rangi e025ab9db0
Merge pull request #578 from mid-kid/master
Fixes in the animation subsystem.
2018-12-09 17:44:09 -05:00
mid-kid fd1fa78ffe Update docs/battle_anim_commands.md 2018-11-26 00:12:23 +01:00