Commit Graph

233 Commits

Author SHA1 Message Date
Andrew Cook 0f5540740b
Some Mobile code labeling and removed magic numbers (#993)
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
2022-09-14 19:49:58 -05:00
mid-kid cff8aec3a7 mobile/mobile_45.asm -> lib/mobile/mail.asm
This file is part of the official mobile adapter SDK, although unlike
lib/mobile/main.asm, this file was included as source code the
developers could modify.
2022-09-08 12:55:14 +02:00
Rangi 4883950318 Use `for` loops to generate box pointer tables
Fixes #996
2022-08-31 18:03:49 -04:00
Rangi 07e8efee7e Fix some whitespace 2022-08-07 00:38:08 -04:00
Colton G. Rushton 145d8dd5c2
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
vulcandth 66d84ff021
`MobileCheckOwnMonAnywhere` & `CheckOwnMonAnywhere` Label, comments, formatting (#927)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 23:21:08 -04:00
vulcandth 73c020074e
Remove redundant comments referencing labels (#921) 2022-06-06 17:34:54 -04:00
vulcandth 3648afda16
RGBDS syntax updates (#905)
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
vulcandth a4d346cc8c
Improved Virtual Console patch identifiers (#907) 2022-06-06 17:22:48 -04:00
vulcandth d226ccab0a
Prune trailing whitespace (#913) 2022-05-06 13:09:51 -04:00
vulcandth 31c3c94d64
Build the Virtual Console patch with `make crystal11_vc` (#882)
Fixes #813
2022-03-12 18:34:04 -05:00
Rangi 3a562f9896 Identify some wMenuJoypad-related button constants 2022-03-09 19:42:26 -05:00
mid-kid 1dc88cb585 Enumerate MobileAPI function constants 2022-01-23 18:13:41 +00:00
Idain 5ac4a51751
Use time constants more often (#867) 2022-01-10 20:57:40 -05:00
Rangi e706b878d9 Use ~X instead of $ff ^ X 2021-11-23 20:37:18 -05:00
Rangi ab0f9c287a Use compound assignment operators 2021-11-23 20:18:08 -05:00
Rangi ed0a0f7159 Move the dbbw, dbww, and dbwww macros to legacy 2021-05-30 15:51:49 -04:00
Rangi 316fa4b695 Use rgbds 0.5.0 2021-04-19 16:31:37 -04:00
Rangi 0506e5b1b9 Assert the sBox1-14 tables have NUM_BOXES entries 2021-03-21 17:47:53 -04:00
Rangi 4522162d45 Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
Rangi 97a11c623e Sync some files with pokegold 2021-03-11 17:43:20 -05:00
Rangi 4264d53eb6 Identify some more labels 2021-02-05 12:44:21 -05:00
Rangi 7d3ea88611 Rename GetFarHalfword to GetFarWord
Fixes #796
2021-01-09 15:16:05 -05:00
Rangi 5db892782a Remove "Buffer" suffix from two HRAM labels 2020-12-23 16:54:28 -05:00
Rangi 99e66c2557 Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"

Fixes #789
2020-12-23 16:29:30 -05:00
Rangi fa3712ea34 Remove "XXX" comments (various "???+" still mark unclear code) 2020-11-09 16:38:11 -05:00
Rangi 17894e5f39 Replace $0 with 0 for "ld l, a / ld h, 0" idiom 2020-11-09 15:20:40 -05:00
Rangi 7254c10093 Identify remaining uses of wBuffer1-6 as general-purpose HP buffers or mobile 2020-11-03 23:25:22 -05:00
Rangi a831b34e5c Identify some uses of wBuffer1-6 in new Crystal code 2020-11-03 22:52:50 -05:00
Rangi 6220200f0f Identify some more labels, and make some more consistent 2020-11-01 12:36:38 -05:00
Rangi fe1a58deea Identify wSpriteAnimDict key constants 2020-10-30 15:39:08 -04:00
Rangi 1237156948 Identify mobile Name Card exchange labels 2020-10-30 10:45:31 -04:00
Rangi ea426a8879 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:34:38 -04:00
Rangi 9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
Rangi 7991db972b Identify some more link.asm labels (syncing to pokegold) 2020-10-23 13:36:54 -04:00
Rangi 15f6a0af43 Identify a few more labels and data 2020-10-22 12:55:46 -04:00
Rangi 306c85750e Identify some more unnamed labels 2020-10-04 20:10:39 -04:00
mid-kid 13c4a93cea Fix some constants surrounding sprite animations
Also commented the use of the field surrounding the struct
initialization functions.

SPRITEANIMSTRUCT_0C -> SPRITEANIMSTRUCT_VAR1
SPRITEANIMSTRUCT_0D -> SPRITEANIMSTRUCT_VAR2
SPRITEANIMSTRUCT_0E -> SPRITEANIMSTRUCT_VAR3
SPRITEANIMSTRUCT_0F -> SPRITEANIMSTRUCT_VAR4

BATTLEANIMSTRUCT_01 -> BATTLEANIMSTRUCT_OAMFLAGS
BATTLEANIMSTRUCT_ANON_JT_INDEX -> BATTLEANIMSTRUCT_JUMPTABLE_INDEX
BATTLEANIMSTRUCT_0F -> BATTLEANIMSTRUCT_VAR1
BATTLEANIMSTRUCT_10 -> BATTLEANIMSTRUCT_VAR2
2020-08-27 13:59:33 +02:00
mid-kid b6055b1944 Use TRUE for hCGBPalUpdate 2020-08-05 16:02:48 +02:00
mid-kid 2d2a7dec7d Label some mobile battle screen functions 2020-08-03 23:35:18 +02:00
mid-kid 79bb2784e9 Better label 2D menu data 2020-08-03 22:56:49 +02:00
Rangi 2c5055f610 Generate the Stadium 2 checksum data with pfero's tool instead of raw INCBINs 2020-07-23 23:49:17 -04:00
Rangi de073374a6 Port pokered's more local system for trade animation scripts
Also factor out trade tilemaps
2020-07-17 16:53:22 -04:00
Rangi e239aa4aba Disassemble the final English debug ROM 2020-07-13 15:18:28 -04:00
Rangi fce6243b43 Identify more labels, and use the jumptable macro when possible 2020-07-01 13:13:49 -04:00
Rangi c3c18dd196 Comment more ROM labels as unreferenced
(Some unreferenced labels are above code which is still used via fallthrough!)
2020-06-21 18:33:31 -04:00
Rangi 91774f206e Replace "Unreferenced" labels with "; unreferenced" comments 2020-06-21 16:27:43 -04:00
Rangi 98af69691d Remove some more raw addresses 2020-06-21 12:21:47 -04:00
Rangi cc460a17b0 Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM)
To do: engine/{menus, overworld}
2020-06-17 17:03:38 -04:00
Rangi b9f2b93c17 Harmonize some more symbols with pokegold 2020-06-16 11:28:52 -04:00