Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
5,052 Commits 2 Branches 0 Tags 183 MiB
Commit Graph

5052 Commits

Author SHA1 Message Date
Idain 553a272e52
TYPO: NUM_MOVE_EFECTS > NUM_MOVE_EFFECTS (#1009) 2022-09-21 22:01:39 -05:00
Rangi 29fada7d8c Don't use removeprefix in tools/unnamed.py (it worked locally...) 2022-09-18 23:56:11 -04:00
Rangi 55ca2da25a Fix tools/unnamed.py and add tools/consts.py 2022-09-18 23:41:45 -04:00
Rangi 6c26e2617c Update and add more tool scripts 2022-09-18 23:08:56 -04:00
Rangi 711f5c87b3 Comment about the redundant event `const_next 1900` 
Fixes #1006
 2022-09-15 18:05:52 -04:00
Andrew Cook 0f5540740b
Some Mobile code labeling and removed magic numbers (#993) 
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
 2022-09-14 19:49:58 -05:00
Rangi 41d5ea0482
Rename the `object_struct` field labels and constants (#1005) 
Fixes #990
 2022-09-12 09:15:44 -04:00
vulcandth 4c239a6f65
Rename `macros/wram.asm` to `macros/ram.asm` (#1003) 2022-09-11 01:05:07 -04:00
Rangi 53e1c48092 Link to the symbols branch 2022-09-10 13:53:53 -04:00
vulcandth 57a23299fb
Use DEF for constants in Music IDs design flaw doc 2022-09-09 10:26:05 -05:00
vulcandth ae79200b1d
Remove duplicate BUG comment in bug doc diff 2022-09-08 20:33:56 -05:00
mid-kid cff8aec3a7 mobile/mobile_45.asm -> lib/mobile/mail.asm 
This file is part of the official mobile adapter SDK, although unlike
lib/mobile/main.asm, this file was included as source code the
developers could modify.
 2022-09-08 12:55:14 +02:00
vulcandth 8ed7c392cd Fix order of parameters in dsprite macro 
The parameters of the legacy dsprite macros were in the wrong order.
Fixes #1002

Co-Authored-By: Idain <54337884+Idain@users.noreply.github.com>
Co-Authored-By: Fredrik Ljungdahl <fredde1994@gmail.com>
 2022-09-07 19:25:20 -05:00
vulcandth 39ba36cb92 Use RS Group offset constants for `slot_reel` 
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-09-05 10:17:40 +00:00
Rangi 5d629f9b31 Fix diff 2022-08-31 19:14:20 -04:00
Idain 01dffba788
Document fish bug properly (#995) 2022-08-31 18:13:10 -05:00
Rangi 4883950318 Use `for` loops to generate box pointer tables 
Fixes #996
 2022-08-31 18:03:49 -04:00
Rangi c7dee19a48 Match bug docs with source code 
Fixes #997
 2022-08-31 17:56:00 -04:00
vulcandth 9801b93906 Add Bug comment for fishing/surfing on NPCs 
Also this re-orders `FishFunction:` and `SurfFunction:` in the bug doc, since `SurfFunction:` is encountered in the file first.
 2022-08-31 00:43:12 -05:00
Rangi b764a3a84d Document fix for fishing and Surfing on top of NPCs 
Fixes #994
 2022-08-30 17:06:12 -04:00
Fredrik Ljungdahl 40c899162b Replace numbers with constants in PlayHitSound 2022-08-24 12:17:31 +02:00
Idain bc4fec0694
Fix AI_Smart_Rage comment (#988) 2022-08-21 22:39:08 -05:00
Rangi 7ef31d9889 Move non-Pokémon graphics out of gfx/icons 
Fixes #987
 2022-08-17 17:45:26 -04:00
The Void 38cd2155df
Bug Doc: Options menu fails to clear joypad state on initialization (#984) 2022-08-11 23:28:35 -05:00
Rangi 0d5cf5c8b9
Refer to "Rival", not "Silver" (#983) 
Fixes #982
 2022-08-10 21:24:56 -04:00
Rangi 367a104203 PP must be 40 or less 2022-08-10 21:20:53 -04:00
vulcandth c3331eb7b1
Rename scene and callback labels (#981) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-08-09 18:04:18 -04:00
vulcandth 134f45b71d
Fix Bug doc Ruins of Alpha Heading Size 2022-08-08 14:28:36 -05:00
Rangi 07e8efee7e Fix some whitespace 2022-08-07 00:38:08 -04:00
Rangi 7cac5b787b Assert that there are NUM_FRAMES textbox frames 2022-08-06 12:24:40 -04:00
Rangi 8826d97ee4
Define scene constants alongside scene_scripts (#979) 
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
 2022-07-29 17:43:10 -04:00
Rangi 51bfd31ea8 Use '$' for hex, not '0x' 2022-07-21 19:59:10 -04:00
Colton G. Rushton 78d93a6246
urlencode special characters like 'é' in documentation link anchors (#976) 2022-07-21 18:48:28 -05:00
vulcandth d9dbc13701
Basic Issue Template with Discord Link (#974) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-07-19 19:16:35 -05:00
Rangi 974bb7bf33 Only use "; BUG:" comments for documented bugs 2022-07-17 14:08:56 -04:00
Colton G. Rushton 145d8dd5c2
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
vulcandth ef9b9bb437
Clean up bugs commented in the source code (#912) 
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
 2022-07-09 16:12:02 -05:00
Colton G. Rushton bd27c0d8dc
Add documentation for the caught level design flaw (#933) 
Co-authored-by: vulcandth <vulcandth@gmail.com>
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-07-09 14:39:07 -04:00
Rangi 4ee4bf0351 Remove SRAM address comment 2022-07-05 18:11:09 -04:00
Rangi f159654054 `spriteanimoam` macro corresponds to `battleanimoam` 2022-07-04 01:11:42 -04:00
Rangi a2e8f078a4 Split "gfx anims" into "pic anims" and "sprite anims" 
Fixes #876
 2022-07-04 01:11:42 -04:00
Colton G. Rushton d3da137de8
Add object priority mode constant and remove unnecessary constants (#972) 
The rest of the unknown constants aren't even registers and can safely be removed without issue.
 2022-07-04 01:10:24 -04:00
Rangi f74ec1053e Use backwards-compatible EQU syntax for rgbdscheck.asm 
Fixes #966
 2022-06-30 21:29:51 -04:00
Colton G. Rushton 39f2e3b685 Fix INSTALL.md's dead links 
Fixes #967
 2022-06-24 20:04:02 +02:00
Colton G. Rushton 2adcca003f Fix ending colon of TruncateHL_BC 
As spotted by @Rangi42 in #746
 2022-06-21 14:12:29 +02:00
vulcandth 1853f70add VC ExchangeBytes Aliases 
Co-Authored-By: aaaaaa123456789 <aaaaaa123456789@acidch.at>
 2022-06-21 11:16:15 +02:00
Colton G. Rushton 4125138da7
Remove unused serial constants ported from pokered (#949) 2022-06-18 13:33:34 -04:00
Rangi a1498e63e2 Rename search.asm and search2.asm 2022-06-17 23:27:53 -04:00
vulcandth 66d84ff021
`MobileCheckOwnMonAnywhere` & `CheckOwnMonAnywhere` Label, comments, formatting (#927) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-06-17 23:21:08 -04:00
Rangi 4db344db89 Add a subdirectory for RAM files 
Fixes #920
 2022-06-17 22:54:52 -04:00