Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,337 Commits 2 Branches 0 Tags 183 MiB
Commit Graph

158 Commits

Author SHA1 Message Date
Remy Oukaour 29b41068cb LOW(MAX_LEVEL + 1) would still fail for MAX_LEVEL = 255, so don't try supporting it here 2017-12-25 16:21:31 -05:00
Remy Oukaour 2e200ce85e More support for MAX_LEVEL = 255 
(ValidateOTTrademon and Function102bdc have `cp MAX_LEVEL + 1` operations that would still fail with such a correction, so there isn't perfect support.)
 2017-12-25 15:52:03 -05:00
Remy Oukaour e34e68095d Resolve #428: Use `HIGH(X)` and `LOW(X)` instead of `X / $100` and `X % $100` or `X >> 8` and `X & $ff` 2017-12-25 14:23:16 -05:00
Remy Oukaour 148fd299f9 Add more constants for some maximum values 2017-12-24 19:49:57 -05:00
Remy Oukaour b805d343f3 Merge branch 'master' of https://github.com/pret/pokecrystal 2017-12-24 17:30:29 -05:00
Remy Oukaour 9973e43d5a Fix issue #345: 
- GetMonFrontpic → GetEnemyMonFrontpic
- GetMonBackpic → GetBattleMonBackpic
- FrontpicPredef → GetAnimatedFrontpicPredef
- GetFrontpic → GetMonFrontpic
- GetBackpic → GetMonBackpic
- CutAndPasteMap → PadMapForHDMATransfer
 2017-12-24 15:03:20 -05:00
Remy Oukaour c66d195089 callba/callab → farcall/callfar 2017-12-24 12:47:30 -05:00
mid-kid cbec3771e2 Misc fixes for the usage of constants 
Several improvements that will make it easier to edit some data
structures for everyone.
 2017-12-24 14:42:13 +01:00
mid-kid 21607bdd1f HELD_TRADE_EVOLVE -> HELD_FLINCH 
This item effect effectively causes the target to flinch (sometimes).
It's not exclusive to trade evolve items in later generations either.
 2017-12-24 14:42:05 +01:00
Remy Oukaour 2fa1e97aeb Document two more bugs 2017-12-19 19:04:56 -05:00
Remy Oukaour c5d482df20 Document two more bugs found by Crystal_ 2017-12-14 16:28:16 -05:00
Remy Oukaour 7350c3708f Replace two numbers with constants (found by pfero) 2017-12-14 12:19:26 -05:00
Remy Oukaour 93c32e3580 Document bugs and glitches 2017-12-12 20:15:07 -05:00
Remy Oukaour 41acb0667a Document macros/map.asm 
Rename MORN/DAY/NITE to MORN_F/DAY_F/NITE_F; use MORN/DAY/NITE for shifted values (cleaner for person_events)
Prefix FLOOR to the `elevfloor` constants
 2017-12-11 01:02:28 -05:00
Remy Oukaour cd2a748128 More WRAM cleanup 2017-12-09 22:00:36 -05:00
Remy Oukaour 5a5df2ab87 More WRAM organization 2017-12-09 14:47:32 -05:00
mid-kid 1bf12455e4 SelfDestruct -> Selfdestruct 
Just keeping things consistent. Nobody's going to write SELF_DESTRUCT.
Kind of subjective, and we could do it the other way around, if anybody
really cares.
 2017-11-18 17:28:12 +01:00
mid-kid fd14253796 Clean up labels in battle/moves/move_effects.asm 
There were a lot of unused labels in there, and a few confusing
misnomers around move_effects_pointers.asm. They now match up exactly
with the names in battle_constants.asm.
Also renamed a few effects, to make their purpose clearer, and to match
up with their respective event script commands:
EFFECT_EXPLOSION    -> EFFECT_SELFDESCTRUCT
EFFECT_HAZE         -> EFFECT_RESET_STATS
EFFECT_WHIRLWIND    -> EFFECT_FORCE_SWITCH
EFFECT_BIND         -> EFFECT_TRAP_TARGET
EFFECT_TWINEEDLE    -> EFFECT_POISON_MULTI_HIT
EFFECT_STEEL_WING   -> EFFECT_DEFENSE_UP_HIT
EFFECT_METAL_CLAW   -> EFFECT_ATTACK_UP_HIT
EFFECT_ANCIENTPOWER -> EFFECT_ALL_UP_HIT
 2017-11-15 16:36:13 +01:00
yenatch d0d61cb3ab Merge pull request #354 from FredrIQ/comments 
Fix a reversed label mistake and reference a major bug
 2017-06-24 17:43:48 -04:00
Ben10do e6ea1889fb
Replace ‘jp [hl]’ with ‘jp hl’ 
The former is arguably misleading (as you don’t access the memory location in hl to retrieve the jump location), and is consequently deprecated in newer versions of rgbds.

This fix silences these deprecation warnings.
 2017-06-09 22:01:10 +01:00
hatschky f0209d6ed6 Labels for Trainer Rankings stat tracking functions 2017-01-16 21:11:34 +00:00
Fredrik Ljungdahl 0e76127da8 Fix an overlooked replace 
The build should match now...
 2017-01-08 01:54:43 +01:00
Fredrik Ljungdahl 9b8f57a730 Explain a major AI-related bug with type matchup checks 2017-01-08 01:33:38 +01:00
Fredrik Ljungdahl 146d12d6e5 Point out a bug with enemy usage of Teleport 
Also point out a redundancy in ThunderAccuracy
 2016-10-29 02:09:56 +02:00
pikalaxalt 87b733994b SPRITE_ANIM_FRAME_IDX constants 2016-05-15 22:00:17 -04:00
pikalaxalt ae36ef2c7f Labeled every function in ROM0 that's referenced in the source 2016-05-10 12:31:49 -04:00
pikalaxalt 82f1534925 Copycat labels; macro for the Crystal-only Unown chamber unlock words 2016-04-30 21:20:12 -04:00
pikalaxalt 6be4cd4da9 Local labels starting with lowercase letters are no longer decorated with a trailing colon 2016-04-10 15:01:49 -04:00
pikalaxalt bf73772a56 Local labels starting with capital letters are now decorated with a trailing colon; remove trailing whitespace; globally correct line endings to UNIX style 2016-04-10 14:42:14 -04:00
pikalaxalt 93e12d2003 Split up banks 1-3 of main.asm 2016-03-27 12:47:28 -04:00
pikalaxalt f2fa5349d5 More annotations of HP bar animations, including an oversight by GameFreak resulting in super-slow HP bars for Pokemon with over 48 HP 2016-03-08 19:54:06 -05:00
PikalaxALT 8bf255b9f8 Prepare to merge 2016-01-18 00:39:01 -05:00
PikalaxALT 2ed6c357af More WRAM tidying 2016-01-12 12:46:18 -05:00
PikalaxALT f7ee74c3b8 Finish labels in engine/namingscreen.asm 2016-01-09 19:34:14 -05:00
PikalaxALT 6d1b7f28c8 Split base stats 2016-01-09 16:52:34 -05:00
PikalaxALT 9bbb65166e More movement stuff 2015-12-29 13:15:58 -05:00
PikalaxALT 57d4cb0edf trainer card 2015-12-28 10:57:04 -05:00
PikalaxALT f030315b1f jumptable macro repurposed 2015-12-26 21:59:03 -05:00
PikalaxALT 2bd45ca574 Move effects; no more reloadmapmusic, returnafterbattle 2015-12-26 19:22:27 -05:00
PikalaxALT a5e928eb98 writebackup --> closewindow; game corner prize vendors; others 2015-12-24 22:58:42 -05:00
PikalaxALT d7a5ea998d More battle anims and bg effects 2015-12-23 20:46:23 -05:00
PikalaxALT 3893feb835 Battle Anim Object struct constants 2015-12-23 14:00:29 -05:00
PikalaxALT 987ed1fafb More work on slots; WRAM cleanup, Move Deleter 2015-12-19 14:48:30 -05:00
PikalaxALT fe4ef4e595 Elevator 2015-12-17 17:51:32 -05:00
PikalaxALT 8612a4a531 Renaming sections, further dissolving main.asm 2015-11-28 15:13:40 -05:00
PikalaxALT d972564175 link and seer labels 2015-11-23 16:04:53 -05:00
PikalaxALT 435b0cf686 Options menu, some mobile fns 2015-11-16 16:46:32 -05:00
PikalaxALT 91068077f0 Further split bank 4 2015-11-11 16:15:06 -05:00
PikalaxALT 8fb01de917 No more DefaultFlypoint 2015-11-10 19:51:13 -05:00
PikalaxALT d13fb46d40 enum macros/move_anim.asm, resolve battle/anims.asm function labels 2015-11-10 16:53:37 -05:00