Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
4,133 Commits 2 Branches 0 Tags 170 MiB
Commit Graph

4133 Commits

Author SHA1 Message Date
Rangi 376c64468b
Merge pull request #554 from Rangi42/master 
[RTM] Miscellaneous fixes
 2018-08-23 10:13:36 -04:00
Rangi 33ff8f2aed asm → diff 2018-08-23 10:07:05 -04:00
Rangi 8cbdd6cbce Merge branch 'master' of https://github.com/Rangi42/pokecrystal 2018-08-20 20:25:18 -04:00
Rangi a09cfc0c36 Label some Unknown map text 2018-08-20 20:24:55 -04:00
Rangi 5574ec64ca Label some Unknown map text 2018-08-19 13:56:41 -04:00
Rangi 39faa7a9f6 Update file paths in comments 2018-08-19 13:33:35 -04:00
Rangi edb624c20c
Merge pull request #550 from mid-kid/master 
Misc things
 2018-08-19 13:09:16 -04:00
Rangi 094fe56cb6
Merge pull request #553 from Rangi42/master 
Avoid warnings from gcc for lzcomp
 2018-08-19 13:08:59 -04:00
mid-kid 0e0f43747d Fix docs 2018-08-19 12:17:54 +02:00
Rangi ca08ffce6e Avoid warnings from gcc without having to silence them all 2018-08-18 22:42:46 -04:00
Rangi 6a6ce484d9
Merge pull request #549 from aaaaaa123456789/master 
Update lzcomp to the newest version
 2018-08-18 22:15:57 -04:00
mid-kid 50da83cb23 CheckDestinyBond -> CheckFaint 
Its main function is fainting the opponent and ending the move effect.
Updated the comment accordingly.
 2018-08-17 20:16:37 +02:00
mid-kid 79cf90ab5e Fix some StatUp-related labels 2018-08-17 17:48:41 +02:00
mid-kid 2e147d1128 GetDamageStatsCritical -> CheckDamageStatsCritical 
Clarified its usage, as the comments surrounding it were factually
wrong.
 2018-08-16 16:11:28 +02:00
IIMarckus cf69876ae5 Better labels/constants for Move Tutor. 2018-08-16 08:05:21 -06:00
mid-kid f5cd6341ff Consistency with order of constant comments 2018-08-07 20:53:14 +02:00
mid-kid 3cf49b7245 Fix more uses of EFFECTIVE 2018-08-07 14:38:41 +02:00
mid-kid fb52b2fdc9 Fix INSTALL.md 2018-08-07 09:46:21 +02:00
mid-kid bc0595564e Fix constants in BattleCommand_MirrorCoat 2018-08-07 09:46:21 +02:00
mid-kid f98a95b8ee wWeeklyFlags -> wDailyFlags2 
These are by far not always checked each week, and as such shouldn't be
called that.
Since they're almost always used through the `bit` instruction, it's
very inconvenient to just make wDailyFlags a `dw` instead.
 2018-08-07 09:46:21 +02:00
mid-kid 23cdf06e5e RestorePPofDepositedPokemon -> RestorePPOfDepositedPokemon 2018-08-07 09:46:21 +02:00
mid-kid 86c1b05fbc Split print_move_description and mon_menu 2018-08-07 09:46:21 +02:00
aaaaaa123456789 5a55d629e1 Update lzcomp to the latest version and fix Makefiles accordingly 2018-08-04 23:43:59 -03:00
Rangi 98e670f363
Merge pull request #548 from Rangi42/master 
Add meaningful aliases for wd265
 2018-07-29 19:56:54 -04:00
Rangi e346cc7b41 Every diff line starts with +, -, or space 2018-07-29 19:52:30 -04:00
Rangi 366330e981 Pokedex_PutScrollbarOAM data values 2018-07-29 16:15:06 -04:00
Rangi 1d96a79a37 No wCurMove alias for wCurSpecies 2018-07-29 16:04:38 -04:00
Rangi b5a9e83a94 Fix reviewed issues. 
Pokedex_PrintListing has a comment noting how it depends on wCurSpecies == wNamedObjectIndexBuffer; an assert would be more convenient, but is not possible since WRAM label addresses are not defined yet here.
 2018-07-29 16:00:11 -04:00
Rangi c9cb67141b Make reviewed fixes; standardize on " + " 2018-07-29 01:40:23 -04:00
Rangi 8498394701 wSwitchMon 2018-07-29 01:27:33 -04:00
Rangi 8aa08addba wLuckyNumberDigitsBuffer 2018-07-29 01:13:25 -04:00
Rangi 0c746447e7 Improve wTrainerHUDTiles usage 2018-07-29 01:09:12 -04:00
Rangi 5145d69506 ; entries correspond to PLAYEREVENT_* constants 2018-07-29 00:57:28 -04:00
Rangi 8935e6f1ca wDeciramBuffer → wBreedingCompatibility in UnknownText_0x1bd0d8 2018-07-29 00:48:03 -04:00
Rangi 20ffc8bd8b Reformat some bugfix diffs 2018-07-29 00:27:13 -04:00
Rangi 9dec80b07e Add meaningful aliases for wd265 
Introduce MONICON_* constants
Introduce BATTLEPLAYERACTION_* constants
 2018-07-29 00:25:52 -04:00
Rangi 2ec900d96c
Merge pull request #535 from ketsuban/fix-battle-transition 
Add fix for battle transition bug
 2018-07-28 19:11:57 -04:00
Rangi a9bc3e4932
Merge pull request #547 from mid-kid/master 
anim_ret_command is an index in a table after all
 2018-07-28 19:11:24 -04:00
Thomas Winwood 533fdd8b4c Add fix for battle transition bug 2018-07-28 19:01:02 +01:00
mid-kid 595127ba65 anim_ret_command is an index in a table after all 
For some reason I thought BattleAnim_Ret was never used, due to how the
battle anim loop would be exited early from. It seems I was wrong.
Removing commands before anim_ret without it being part of the `enum`
seems to break things.
 2018-07-28 12:14:04 +02:00
Rangi ee8479f05e
Merge pull request #546 from Rangi42/master 
Reword bug docs now that they use diffs
 2018-07-28 01:06:54 -04:00
Rangi cdfdfed17b Crystal fixed TruncateHL_BC in single player 2018-07-27 21:32:14 -04:00
Rangi a2f63043d4 Separate Beat Up bugs 2018-07-27 17:53:26 -04:00
Rangi b58f82e12f Reword bug docs now that they use diffs 2018-07-27 13:11:30 -04:00
Rangi 54d507cf61 Merge branch 'master' of https://github.com/pret/pokecrystal 2018-07-27 12:07:10 -04:00
Rangi 7641ce9bab
Merge pull request #545 from mid-kid/master 
bugs_and_glitches fixes
 2018-07-27 12:06:46 -04:00
mid-kid 0aac0f9cfc "Explain" diff format in bugs_and_glitches 2018-07-27 11:25:29 +02:00
mid-kid 9aa6b55d7b Merge branch 'master' of https://github.com/pret/pokecrystal 2018-07-27 11:24:59 +02:00
yenatch 748d424980
Merge pull request #544 from Rangi42/master 
Various fixes found while writing tutorials
 2018-07-26 21:25:12 -04:00
mid-kid a91b59ab5d Remove a documented bug that's not really a bug 
I mean, technically, being able to read beyond a data table's size is
bad practice, but there's so many cases of this that it's not worth
mentioning.

For most of these cases, at least, it's safe to assume the index won't
ever get high enough to surpass such a table's length, because it's
either hardcoded or decided by the game without the use of
uncontrollable data. As such, they don't expose any actual bugs.
 2018-07-26 23:34:05 +02:00