mid-kid
26b8bf003e
Standardize on lowercase Tilemap and Attrmap
...
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
2020-02-13 18:31:10 +01:00
mid-kid
34ceaac71d
Call_LoadTempTileMapToTileMap → SafeLoadTempTileMapToTileMap
...
Stupid name is stupid smh tbh fam.
2020-02-13 18:31:10 +01:00
mid-kid
a241f049df
Remove FarCall prefix from SwapTextboxPalettes and ScrollBGMapPalettes
...
No prefix for the farcall, prefix with an underscore for the farcalled.
This matches what is done for pretty much every other home function.
2020-02-13 18:31:10 +01:00
mid-kid
991d207d86
OWFlash -> FlashFunction
...
Match the other overworld move functions
2020-02-13 18:31:10 +01:00
mid-kid
a094c58f1e
Split up engine/events/misc_scripts_2.asm
...
New files are:
- engine/events/hidden_item.asm
- engine/events/repel.asm
2020-02-13 18:31:10 +01:00
mid-kid
0d81f1c470
InitSpriteAnimStruct <-> _InitSpriteAnimStruct
...
These were the wrong way around, as the function in home should not be
prefixed
2020-02-13 18:31:10 +01:00
Rangi
ceadab8cd1
PnP_HiddenPlaces -> PnP_Places
...
The "Places & People" radio station does not avoid these maps; it only describes these maps.
2020-02-06 11:07:42 -05:00
Rangi
fb9cbe7d1e
Merge pull request #650 from pret/audio-macros
...
Update audio macros and arguments
2020-02-05 18:51:20 -05:00
Rangi
24a23b1922
Use CMDQUEUE constants
2020-02-04 11:11:43 -05:00
mid-kid
44b361c1bb
Merge branch 'master' into audio-macros
2020-02-04 16:03:01 +01:00
Rangi
80cf859cd3
PHONE_DISPLAY_HEIGHT is 4, the number of visible phone entries
2020-01-19 14:10:10 -05:00
dannye
e7be25948d
Merge branch 'master' into audio-macros
2020-01-06 22:07:33 -06:00
Rangi
94ebdab6d3
Merge pull request #660 from mid-kid/master
...
Make the map setup commands match the actual function names better
2020-01-04 20:08:43 -05:00
Colton G. Rushton
5728d01417
Add and simplify bugfixes in bugs_and_glitches.md ( #664 )
...
Add extra fixes for bugs covered on Bulbapedia (and simplify others)
2020-01-04 16:52:08 -05:00
Rangi
fa7261a8ee
Update some labels
2019-12-03 09:17:21 -05:00
Rangi
0e311ad709
Fix miscellaneous points made in #658
2019-11-23 20:56:22 -05:00
mid-kid
739a60b33c
Make the map setup commands match the actual function names better
...
These functions used as map setup commands are used in other places,
too, so I can't prefix them under the same. The names should match
except I won't repeat "map" in a map setup command name.
2019-11-18 18:21:57 +01:00
mid-kid
77803f571f
Fix some constants around wLinkMode
2019-11-18 18:21:57 +01:00
Rangi
d076159745
Don't use colons for local labels in LoadSpecialMapPalette
2019-11-04 17:43:37 -05:00
Rangi
51720e1e3c
Fix #645 : Use English labels for European mail handling functions
2019-11-03 20:34:02 -05:00
Rangi
4d32035d4f
Bit 6 of PrintNum left-aligns numbers
2019-11-03 20:17:04 -05:00
Rangi
0c7b309f7f
Suggested formatting changes
2019-11-03 20:07:25 -05:00
Rangi
fbe2494dc2
Miscellaneous label and comment corrections
2019-11-03 14:47:06 -05:00
Rangi
717cf3f458
Identify PLAYERMOVEMENT_* constants
2019-11-03 14:30:33 -05:00
Rangi
d5e1b5a628
The $C9 byte in page2.tilemap is a ret opcode
2019-11-03 14:18:23 -05:00
Rangi
4211886921
Use constants for quantities when copying SGB border tiles and palettes
2019-11-03 14:15:20 -05:00
Rangi
f511713c86
Identify some move screen functions
2019-11-03 13:46:00 -05:00
Rangi
3e7c7d5fff
Identify intro tilemaps and attrmaps
2019-11-03 13:38:40 -05:00
Rangi
4aeab6b879
Rename buttonsound to promptbutton
2019-11-03 12:48:54 -05:00
Rangi
5134266b9a
Rename OBJECT_LENGTH to MAPOBJECT_LENGTH and OBJECT_STRUCT_LENGTH to OBJECT_LENGTH
2019-11-03 12:26:38 -05:00
Rangi
01f68fcc6a
Rename TILESET_BATTLE_TOWER to TILESET_BATTLE_TOWER_INSIDE
2019-11-03 12:03:37 -05:00
mid-kid
86061d37d2
More mobile SDK documentation
...
Labelled WRAM addresses, added constants for mobile commands, fixed some
mobile lib function names, documented most of the functions for specific
commands.
2019-10-21 00:42:36 +02:00
mid-kid
f4907040c9
Label some more WRAM/SRAM things
...
This should be all of the memory locations that are actually used, and
some more.
Removal of all addresses when?
2019-10-21 00:42:36 +02:00
mid-kid
7111ae8e58
Fix some mobile script and map sign things
2019-10-21 00:42:36 +02:00
mid-kid
1f172badc4
Misc fixes
2019-10-21 00:31:50 +02:00
bbbbbbbbba
0d48d829d4
Document Special Defense badge boost glitch ( #651 )
...
Document Special Defense badge boost glitch
2019-10-20 18:25:34 -04:00
mid-kid
e3e0bcd653
#641 fixes and additions. ( #646 )
...
Name a lot of text labels according to our conventions
2019-10-20 18:24:17 -04:00
Ryan Tandy
3fc2ba41f7
Clarify naming of SFX_GET_EGG_* pointers
...
In game, one receives eggs from the Aide and the Day-care Man, not the
Day-care Lady. SFX `0x96` is used for both. Rename it to reflect it is
not unique to the Day-care.
SFX `0x95` is an alias of the same sound and appears to be unused.
Rename the pointer to clarify that.
2019-09-23 10:03:19 -07:00
dannye
fc051f2130
Update audio macros and arguments
...
and update related labels/constants/comments
this fixes a lot of mistakes and maximizes compatibility with red
2019-09-02 03:41:25 -05:00
Rangi
6962d843a3
Store Magnet Train tilemaps in their own files
2019-08-11 18:48:26 -04:00
Rangi
01618d3cc4
Define constants for both battle transition tiles
2019-06-30 14:20:25 -04:00
mid-kid
ad299b1635
Apply suggested changes
2019-06-10 01:52:46 +02:00
mid-kid
d6db010429
Document high nybble of PrintNum `c` register
2019-06-09 17:46:06 +02:00
mid-kid
c048b24d25
Create constants for ScrollingMenu item formats
...
...I should've done this quite a while ago.
2019-06-09 02:31:24 +02:00
mid-kid
c7fdf5f9ec
Fix overworld scrolling function names
2019-06-09 00:17:35 +02:00
mid-kid
b6277408a0
Misc fixes
2019-06-04 13:31:22 +02:00
mid-kid
309079524b
Fix menu_coords for pokecenter pc
2019-06-04 13:11:29 +02:00
mid-kid
649c8d38da
Get rid of _CRYSTAL
...
Having this here is completely redundant and useless, and doesn't even
work since it should use `if DEF(_CRYSTAL)` instead.
2019-05-25 17:59:50 +02:00
mid-kid
13cfe356d6
Fix usage of rIE and rSC constants
2019-05-25 17:59:50 +02:00
mid-kid
40766b9a76
Magnet train fixes
...
Should make the code slightly easier to read, at least
2019-05-25 17:59:50 +02:00