Commit Graph

4170 Commits

Author SHA1 Message Date
Rangi 14a2ea835e Remove redundant comments 2018-09-09 15:15:33 -04:00
Rangi 9ee2b59208 hMultiplicand is four bytes internally, but the high byte is always 0 since allowing four-byte multiplicands could overflow hProduct. 2018-09-09 15:10:38 -04:00
Rangi ae022e1420 Curr -> Cur 2018-09-09 15:09:51 -04:00
Rangi 84cfbc70fa
Merge pull request #561 from Rangi42/master
Revise documentation
2018-09-08 12:42:17 -04:00
Rangi 741d22907e Empty rules are unnecessary (error messages are fine without them) 2018-09-08 12:33:52 -04:00
Rangi 140a065b7a Don't repeat the pokecrystal instructions 2018-09-01 23:53:39 -04:00
Rangi d67ef7efd5 Clarify about rgbds 0.3.7 compatibility 2018-09-01 23:02:24 -04:00
Rangi cd169aec3c Revise documentation
All the INSTALL.md sections have similar structure
2018-09-01 21:53:05 -04:00
Rangi 963026695d
Merge pull request #560 from Rangi42/master
Fix #537: Palettes generated from PNGs use .gbcpal directly.
2018-09-01 20:58:23 -04:00
Rangi 83b5aa356f
Merge pull request #559 from mid-kid/master
Clarify INSTALL.md
2018-09-01 20:58:06 -04:00
Rangi 075a3bcad0 Consistently use "rgbgfx += -h" 2018-09-01 20:30:42 -04:00
Rangi cac641a5ed normal.gbcpal → front.gbcpal
Eliminate redundant Makefile rules
Keep Makefile's Pokemon-specific hack rules next to the misc file-specific graphics rules
2018-09-01 20:18:55 -04:00
mid-kid 1070115087 Update documentation
Added windows 10 (WSL) installation instructions and expanded linux instructions.
Clarified things in FAQ.md.
2018-09-02 01:36:44 +02:00
Rangi 36b21b39d8 Fix #537: Palettes generated from PNGs use .gbcpal directly.
This avoids overwriting a .pal file from a .png with the same name.
It also prevents people from trying to edit generated .pal files.
2018-08-31 21:39:17 -04:00
Rangi a71b28e5b7
Merge pull request #557 from Rangi42/master
Miscellaneous changes
2018-08-26 22:54:11 -04:00
Rangi b42ba692c4 ; fallthrough 2018-08-26 22:34:59 -04:00
Rangi f71d614241 HRAM style 2018-08-26 17:52:19 -04:00
Rangi 0e1445b796 spaces->tab, and remove redundant comment 2018-08-26 16:15:43 -04:00
Rangi f8bebd4d27 Nested union for the Multiply+Divide inputs+results 2018-08-26 14:37:42 -04:00
Rangi 557ce82073 hQuotient is a four-byte buffer (fixes #558) 2018-08-26 13:49:38 -04:00
Rangi cb32c895e4 Explain wCreditsBlankFrame2bpp 2018-08-26 13:23:40 -04:00
Rangi d2053c12c2 wCreditsFaux2bpp -> wCreditsBlankFrame2bpp, with the right buffer size
Remove some unused WRAM labels
2018-08-26 13:08:01 -04:00
Rangi 296402bd31 _Divide results go in hQuotient and hRemainder, not in hDividend and hDivisor
Note that the result quotient is four bytes, but hQuotient is a three-byte buffer. This is because no Divide caller ever needed a four-byte quotient, so the buffer didn't include the high byte.
2018-08-25 22:58:26 -04:00
Rangi 4c8c5c10a8 Use rgbasm's GameBoy graphics literal for initializing wCreditsFaux2bpp
In the 2BPP format, two bytes %ABCDEFGH %abcdefgh define eight pixels %Aa %Bb %Cc %Dd %Ee %Ff %Gg %Hh.
Four valid colors: %00 = 0 = white, %01 = 1 = dark, %10 = 2 = light, %11 = 3 = black.
Thus `22222222 = pixels %10 %10 %10 %10 %10 %10 %10 %10 = bytes %11111111 %00000000 = $ff00.
2018-08-25 22:38:57 -04:00
Rangi 3eacab563d
Merge pull request #555 from Rangi42/ldh
Use real labels for HRAM instead of constants, and the ldh instruction
2018-08-25 22:23:45 -04:00
Rangi 89681d2316
Merge pull request #541 from igidrau/patch-2
Labeled everything
2018-08-25 22:23:25 -04:00
Rangi b2adcd6d6f Reorganize math-related HRAM union (ffb3) 2018-08-25 21:49:26 -04:00
igidrau f2ac3b96fa
Changed some labels according to Rangi's comments 2018-08-25 21:44:30 +02:00
Rangi 919ed1d4f5 Avoid a nested union 2018-08-25 15:09:57 -04:00
Rangi a71901020b These are signed offsets, not addresses (thanks, PikalaxALT) 2018-08-25 14:43:02 -04:00
Rangi 7aa1c1f388 Remove HRAM label address comments 2018-08-25 14:39:24 -04:00
Rangi 1c0fff7668 hLabel - $ff00 -> LOW(hLabel) 2018-08-25 14:34:25 -04:00
Rangi eb1e3636bb Use labels instead of constants for HRAM
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 14:28:22 -04:00
Rangi 376c64468b
Merge pull request #554 from Rangi42/master
[RTM] Miscellaneous fixes
2018-08-23 10:13:36 -04:00
Rangi 33ff8f2aed asm → diff 2018-08-23 10:07:05 -04:00
Rangi 8cbdd6cbce Merge branch 'master' of https://github.com/Rangi42/pokecrystal 2018-08-20 20:25:18 -04:00
Rangi a09cfc0c36 Label some Unknown map text 2018-08-20 20:24:55 -04:00
Rangi 5574ec64ca Label some Unknown map text 2018-08-19 13:56:41 -04:00
Rangi 39faa7a9f6 Update file paths in comments 2018-08-19 13:33:35 -04:00
Rangi edb624c20c
Merge pull request #550 from mid-kid/master
Misc things
2018-08-19 13:09:16 -04:00
Rangi 094fe56cb6
Merge pull request #553 from Rangi42/master
Avoid warnings from gcc for lzcomp
2018-08-19 13:08:59 -04:00
mid-kid 0e0f43747d Fix docs 2018-08-19 12:17:54 +02:00
Rangi ca08ffce6e Avoid warnings from gcc without having to silence them all 2018-08-18 22:42:46 -04:00
Rangi 6a6ce484d9
Merge pull request #549 from aaaaaa123456789/master
Update lzcomp to the newest version
2018-08-18 22:15:57 -04:00
mid-kid 50da83cb23 CheckDestinyBond -> CheckFaint
Its main function is fainting the opponent and ending the move effect.
Updated the comment accordingly.
2018-08-17 20:16:37 +02:00
mid-kid 79cf90ab5e Fix some StatUp-related labels 2018-08-17 17:48:41 +02:00
mid-kid 2e147d1128 GetDamageStatsCritical -> CheckDamageStatsCritical
Clarified its usage, as the comments surrounding it were factually
wrong.
2018-08-16 16:11:28 +02:00
IIMarckus cf69876ae5 Better labels/constants for Move Tutor. 2018-08-16 08:05:21 -06:00
igidrau 4aed8ea922
There was an error in the previous commit 2018-08-08 10:56:14 +02:00
igidrau 88a563e6e7
Changed the labels accordingly to the standard style 2018-08-08 10:47:07 +02:00