Sylvie
2265e53d24
Rename `dt` and `dd` to `bigdt` and `bigdd` ( #1141 )
...
This makes their big-endianness obvious and matches `bigdw`
2024-10-17 14:52:47 -04:00
Sylvie
e59624d1f5
Generate Unown sprite palette based on all front+back sprites ( #1146 )
2024-10-17 13:39:33 -04:00
Sylvie
5a53e297cf
Sort Pokemon and trainer sprite palettes, with Makefile-specified exceptions ( #1137 )
...
This avoids the need to define their order via indexed PNG palettes
It also avoids the need to use gb-asm-tools' palfix.py on custom sprites
Fixes #1136
2024-10-16 10:48:00 -04:00
Sylvie
017bffaef9
Put front and back pics on a single line ( #1139 )
2024-09-26 00:20:04 -04:00
Sylvie
fed587fc37
Refactor the Unown wall word data ( #1131 )
2024-07-24 10:56:46 -04:00
Rangi42
4f57e96f31
Consolidate the duplicate stat level data files
2024-06-12 13:13:58 -04:00
Sylvie
8819f7b117
Identify various "????"s ( #1125 )
2024-06-11 20:54:45 -04:00
xCrystal
e0c278a595
Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission ( #1078 )
2024-01-07 14:51:27 +01:00
xCrystal
bd6ceec193
Improve some innacurate function names, labels, and comments ( #1078 )
...
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371 ]
2024-01-07 13:36:05 +01:00
Rangi
dbf6044650
Update to RGBDS 0.7.0 ( #1101 )
2024-01-03 10:58:53 -05:00
vulcandth
30739842af
Document Tackle is missing part of its hit animation
...
Co-Authored-By: SoupPotato <22991349+SoupPotato@users.noreply.github.com>
2024-01-03 15:41:28 +01:00
SnorlaxMonster
a82dfd81bb
Replace "¯" and "%" (breakable whitespace) with more meaningful charmap names ( #1094 )
2023-11-19 20:04:45 -05:00
vulcandth
aba1f14044
Sync sprite and battle anim consts/labels ( #1055 )
...
* Sync sprite and battle anim consts/labels
* Add `; 00` comments
* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
2023-09-17 13:09:28 -05:00
Tiddlywinks
b0ddb0758d
1) Fix DECOFLAG order. 2) The doll is Staryu, not Starmie (and the sprite can be either)
2023-09-13 08:08:27 +02:00
SoupPotato
6180be355e
Labeled framesets and related constants ( #1063 )
...
* Labeled Framesets and Constants Related
* Feedback Implemented with PascalCase and Constant Renames
* Fix framset.asm comment spacing
* `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA`
* Feedback applied and labeled 1E & B2
* Fixed SpinningBone
---------
Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-08-21 19:09:23 -05:00
Rangi
0d899cbd3b
Define all unused type names with `rept` ( #1071 )
...
Fixes #1070
2023-08-16 10:22:35 -04:00
Rangi
f3b31087e3
Use `MAP_CONNECTION_PADDING_WIDTH` in `MACRO connection`
...
Fixes #1033
2023-08-15 19:54:16 -04:00
SatoMew
768b3bdec1
Improve mobile-related labels ( #1061 )
2023-07-26 19:59:00 -05:00
vulcandth
31c55dc74d
Use BattleAnim_Dummy in data/moves/animations.asm ( #1052 )
2023-06-22 16:15:43 -04:00
vulcandth
438c48daad
Rename PAL_NPC_SILVER to PAL_NPC_EMOTE ( #1053 )
2023-06-01 07:47:53 -05:00
mid-kid
cfd432f468
Minor battle tower fixes
2023-03-08 13:52:47 +01:00
vulcandth
25e12c9391
wUnlockedUnowns engine_flag constants ( #1025 )
2022-12-26 13:14:10 -05:00
Rangi
8e135931a6
Require rgbds 0.6.0
2022-10-02 22:03:53 -04:00
Rangi
8fc3b8e6e3
Dance Theatre -> Dance Theater
...
Fixes #1008
2022-09-23 22:06:52 -04:00
Idain
553a272e52
TYPO: NUM_MOVE_EFECTS > NUM_MOVE_EFFECTS ( #1009 )
2022-09-21 22:01:39 -05:00
Andrew Cook
0f5540740b
Some Mobile code labeling and removed magic numbers ( #993 )
...
* Macro loop for EmptyAllSRAMBanks
* Many things labeled and magic numbers removed
* Conform to the style guide
* Rename URLs in mobile_46
* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS
* Update engine/menus/empty_sram.asm
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
* Update ram/wram.asm
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
* Update mobile/mobile_46.asm
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
* Update mobile/mobile_46.asm
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
* Remove underscore from Set*DownloadURL symbols
* Begin Labeling TradeCornerHoldMon routines
* Add wMobileMon party_struct
* Add TRADE_CORNER_REQUEST_LENGTH constant
* Name battle tower action functions
* Label trade corner send/receive buffer
* Label the saved copy of the trade corner pokemon
also fix mailmsg_jp
* So many copies of decodeBase64Character
* Label another buffer
* Fix Alignment and use MOBILE_EMAIL_LENGTH
* `Function11ad8a` -> `MobileIncJumptableIndex`
* Apply Rangi Suggestions pass 1
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
* Apply Suggestions 2
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
2022-09-14 19:49:58 -05:00
Rangi
0d5cf5c8b9
Refer to "Rival", not "Silver" ( #983 )
...
Fixes #982
2022-08-10 21:24:56 -04:00
Rangi
367a104203
PP must be 40 or less
2022-08-10 21:20:53 -04:00
vulcandth
ef9b9bb437
Clean up bugs commented in the source code ( #912 )
...
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-07-09 16:12:02 -05:00
Rangi
f159654054
`spriteanimoam` macro corresponds to `battleanimoam`
2022-07-04 01:11:42 -04:00
Rangi
a2e8f078a4
Split "gfx anims" into "pic anims" and "sprite anims"
...
Fixes #876
2022-07-04 01:11:42 -04:00
vulcandth
5f0597e944
Rename `SLP` to `SLP_MASK` ( #918 )
...
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:56 -04:00
vulcandth
3648afda16
RGBDS syntax updates ( #905 )
...
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
Rangi
ab0f9c287a
Use compound assignment operators
2021-11-23 20:18:08 -05:00
Rangi
39111486ab
Fix #845 : Liz gossips about a beautiful trainer, not Pokémon
2021-11-03 17:24:16 -04:00
Rangi
753ed7186c
Use -1 for terminating happiness probability data
2021-10-28 17:02:13 -04:00
Rangi
f59f1bdb88
Standardize capitalization of ".Jumptable"
2021-06-19 19:52:05 -04:00
Rangi
ed0a0f7159
Move the dbbw, dbww, and dbwww macros to legacy
2021-05-30 15:51:49 -04:00
Rangi
b1dbadbdd3
Require rgbds 0.5.1
...
Use some new features: \<10> macro args, SECTION UNION, SIZEOF/STARTOF, and CHARLEN/CHARSUB
2021-05-09 12:26:28 -04:00
Rangi
316fa4b695
Use rgbds 0.5.0
2021-04-19 16:31:37 -04:00
Rangi
94057c7726
Verify uneven list sizes with list_start, li, and assert_list_length macros
...
This was discussed in #815
2021-03-22 17:17:08 -04:00
Rangi
dbe2360ecd
Miscellaneous cleanup
2021-03-22 16:41:17 -04:00
Rangi
4522162d45
Consistent labels for each nickname in RAM
2021-03-17 16:38:21 -04:00
Rangi
6c8f8609cb
Assert some more table widths
2021-03-17 11:38:01 -04:00
Rangi
3684296583
Revise some constant definitions
2021-03-16 18:06:18 -04:00
Rangi
dbabd8b4a9
Define MAPGROUP_* constants and verify MapGroup_* table sizes
2021-03-10 21:16:54 -05:00
Rangi
ef20126fe5
Verify wild data sizes with def_grass/water_wildmons and end_grass/water_wildmons macros
2021-03-04 17:58:30 -05:00
Rangi
40902ffe24
Verify data table sizes with table_width and assert_table_length macros
...
This was discussed in #706
It also uncovered some off-by-one issues with defining some constants.
A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi
a539578006
Merge pull request #798 from CelestialAmber/master
...
Fix typo
2021-02-05 09:45:18 -08:00
Rangi
4264d53eb6
Identify some more labels
2021-02-05 12:44:21 -05:00