Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use DEF for constants in Music IDs design flaw doc

This commit is contained in:
vulcandth 2022-09-09 10:26:05 -05:00 committed by GitHub
parent ae79200b1d
commit 57a23299fb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
docs/design_flaws.md
View File

@ -247,18 +247,18 @@ Redefine the special music constants in [constants/music_constants.asm](https://
```diff ```diff
-; GetMapMusic picks music for this value (see home/map.asm) -; GetMapMusic picks music for this value (see home/map.asm)
-MUSIC_MAHOGANY_MART EQU $64 -DEF MUSIC_MAHOGANY_MART EQU $64
+; GetMapMusic picks music for these values (see home/map.asm) +; GetMapMusic picks music for these values (see home/map.asm)
+MUSIC_MAHOGANY_MART EQU $fc +DEF MUSIC_MAHOGANY_MART EQU $fc
+MUSIC_RADIO_TOWER EQU $fd +DEF MUSIC_RADIO_TOWER EQU $fd
; ExitPokegearRadio_HandleMusic uses these values ; ExitPokegearRadio_HandleMusic uses these values
RESTART_MAP_MUSIC EQU $fe DEF RESTART_MAP_MUSIC EQU $fe
ENTER_MAP_MUSIC EQU $ff DEF ENTER_MAP_MUSIC EQU $ff
- -
-; GetMapMusic picks music for this bit flag -; GetMapMusic picks music for this bit flag
-RADIO_TOWER_MUSIC_F EQU 7 -DEF RADIO_TOWER_MUSIC_F EQU 7
-RADIO_TOWER_MUSIC EQU 1 << RADIO_TOWER_MUSIC_F -DEF RADIO_TOWER_MUSIC EQU 1 << RADIO_TOWER_MUSIC_F
``` ```
Edit `GetMapMusic`: Edit `GetMapMusic`: