From 57a23299fb014b99aa0cedd598ffbd814c699d96 Mon Sep 17 00:00:00 2001 From: vulcandth Date: Fri, 9 Sep 2022 10:26:05 -0500 Subject: [PATCH] Use DEF for constants in Music IDs design flaw doc --- docs/design_flaws.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/design_flaws.md b/docs/design_flaws.md index f0cf7e5f6..431cb2f66 100644 --- a/docs/design_flaws.md +++ b/docs/design_flaws.md @@ -247,18 +247,18 @@ Redefine the special music constants in [constants/music_constants.asm](https:// ```diff -; GetMapMusic picks music for this value (see home/map.asm) --MUSIC_MAHOGANY_MART EQU $64 +-DEF MUSIC_MAHOGANY_MART EQU $64 +; GetMapMusic picks music for these values (see home/map.asm) -+MUSIC_MAHOGANY_MART EQU $fc -+MUSIC_RADIO_TOWER EQU $fd ++DEF MUSIC_MAHOGANY_MART EQU $fc ++DEF MUSIC_RADIO_TOWER EQU $fd ; ExitPokegearRadio_HandleMusic uses these values - RESTART_MAP_MUSIC EQU $fe - ENTER_MAP_MUSIC EQU $ff + DEF RESTART_MAP_MUSIC EQU $fe + DEF ENTER_MAP_MUSIC EQU $ff - -; GetMapMusic picks music for this bit flag --RADIO_TOWER_MUSIC_F EQU 7 --RADIO_TOWER_MUSIC EQU 1 << RADIO_TOWER_MUSIC_F +-DEF RADIO_TOWER_MUSIC_F EQU 7 +-DEF RADIO_TOWER_MUSIC EQU 1 << RADIO_TOWER_MUSIC_F ``` Edit `GetMapMusic`: