* Add htslib project files
Only build the library and hts_open_fuzzer.o. The binaries are
not needed and fail to build anyway due to missing libfuzzer
symbols.
* Use $LIB_FUZZING_ENGINE
A direct clone now gives you dev which is future Qt 6, none of the
code using Qt expects Qt6 yet
Using 5.15 now (instead 5.12 before) means we have to disable
sanitize=vptr in parts of qt in kimageformats since those
parts now compile with no-rtti
While at it make the compilation script a bit better:
* Don't need to disable compressing rcc files, only needed to pass
the CFLAGS to the QMAKE_CFLAGS
* Also fix the "make qmake faster" sed command
I'm re-enabling AFL since the issue with gmock's main being present was fixed in e8616a31f4
This libunwind changes solve the issues we were seeing with the fuzzers not running in the clusterfuzz bot environment. What this PR does, roughly:
* Copy the .so from the build image into `/out/lib`
* Patch the binaries so they have an rpath which specifies looking in `/out/lib` for libraries in addition to the normal search path
This will work *assuming* `/out/lib` is copied over in the bot environment and is available. I'm relying on code reviewers to let me know if this is true or not. If not, it should be an easy path update.
Test plan:
Verifying the AFL build was easy:
python infra/helper.py build_fuzzers --sanitizer address --engine afl proxygen
python infra/helper.py check_build --engine afl proxygen
python infra/helper.py run_fuzzer --engine afl proxygen ProxygenHTTP1xFuzzer
I verified the libunwind changes by using the shell command (thanks for the tip, didn't know that was there!).
I first built the binary using this build script.
I then used `python infra/helper.py shell --sanitizer address proxygen`
In the shell, I:
* Ran `/out/ProxygenHTTP1xFuzzer` and verified it worked
* Ran `ldd` on it and showed it pointed to `/out/lib` for `libunwind.so.8`
* Uninstalled libunwind
* Verified it still worked
* Used `patchelf --print-rpath ProxygenHTTP1xFuzzer` to verify that the rpath was set as I expected (inside `/out/lib`)
* Removed the patch using `patchelf --remove-rpath to_patch`
* Verified that the fuzzer no longer runs (crashes on startup, complaining about missing `libunwind.so.8`)
* I verified that the binary still finds the system one if rpath isn't set, by reinstalling it, using `patchelf --print-rpath` again, verifying that it prints the path to the system `libunwind` when I run `ldd`, and that the fuzzer runs fine. This implies it can find other system libraries fine too (and I saw that in the `ldd` output)
I don't think I can do any further testing, so we will just have to hope that this works in the bot environment.
Damien Neil