Rooba
/
oss-fuzz
mirror of https://github.com/google/oss-fuzz.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

infra: fix presubmit when project.yaml fails (#10681) 

Currently a `project.yaml` with wrong key names will result in the
following error:

```
...
    return all([check(changed_files) for check in checks])
  File "infra/presubmit.py", line 229, in check_project_yaml
    return all([_check_one_project_yaml(path) for path in paths])
  File "infra/presubmit.py", line 229, in <listcomp>
    return all([_check_one_project_yaml(path) for path in paths])
  File "infra/presubmit.py", line 223, in _check_one_project_yaml
    return checker.do_checks()
  File "infra/presubmit.py", line 131, in do_checks
    check_function()
  File "infra/presubmit.py", line 179, in check_valid_section_names
    self.error(f'{name} is not a valid section name ({valid_names})')
NameError: name 'valid_names' is not defined
```

This fixes it.

Signed-off-by: David Korczynski <david@adalogics.com>
This commit is contained in:
DavidKorczynski 2023-07-13 04:47:05 +01:00 committed by GitHub
parent d3f5ecceb3
commit ff9bb81fa3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
infra/presubmit.py
View File

@ -176,7 +176,8 @@ class ProjectYamlChecker:
"""Returns True if all section names are valid.""" """Returns True if all section names are valid."""
for name in self.data: for name in self.data:
if name not in self.VALID_SECTION_NAMES: if name not in self.VALID_SECTION_NAMES:
self.error(f'{name} is not a valid section name ({valid_names})') self.error(
f'{name} is not a valid section name ({self.VALID_SECTION_NAMES})')
def check_required_sections(self): def check_required_sections(self):
"""Returns True if all required sections are in |self.data|.""" """Returns True if all required sections are in |self.data|."""