Rooba
/
lightning
mirror of https://github.com/Lightning-AI/lightning.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Updated Review guidelines (markdown)

Jirka Borovec 2020-03-14 20:40:07 +01:00
parent f1f9d87e5f
commit ddac7026a8
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Review-guidelines.md

@ -5,6 +5,7 @@ Some recommended steps for reviewing open PRs.
3. Check if the changes (fixed issue) are **covered by tests** 3. Check if the changes (fixed issue) are **covered by tests**
4. Check if the change is mentioned in **CHANGELOG** (no need for typos, docs and CI) 4. Check if the change is mentioned in **CHANGELOG** (no need for typos, docs and CI)
Hints: ## Hints and remarks
- **be nice and constructive**, remember you fist PR and what helped you / made motivated to continue with contributing - **be nice and constructive**, remember you fist PR and what helped you / made motivated to continue with contributing
- use suggestions for simple edits when you know what it shall be intead of long description (you can still add short justification of your proposal) so the author can simply accept it... - **use suggestions** for simple edits when you know what it shall be intead of long description (you can still add short justification of your proposal) so the author can simply accept it...