From ddac7026a80cb5b309cdcfd56646d4069efee78f Mon Sep 17 00:00:00 2001 From: Jirka Borovec Date: Sat, 14 Mar 2020 20:40:07 +0100 Subject: [PATCH] Updated Review guidelines (markdown) --- Review-guidelines.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Review-guidelines.md b/Review-guidelines.md index cc3e5f0..be7e11b 100644 --- a/Review-guidelines.md +++ b/Review-guidelines.md @@ -5,6 +5,7 @@ Some recommended steps for reviewing open PRs. 3. Check if the changes (fixed issue) are **covered by tests** 4. Check if the change is mentioned in **CHANGELOG** (no need for typos, docs and CI) -Hints: +## Hints and remarks + - **be nice and constructive**, remember you fist PR and what helped you / made motivated to continue with contributing -- use suggestions for simple edits when you know what it shall be intead of long description (you can still add short justification of your proposal) so the author can simply accept it... +- **use suggestions** for simple edits when you know what it shall be intead of long description (you can still add short justification of your proposal) so the author can simply accept it...