Rooba
/
lightning
mirror of https://github.com/Lightning-AI/lightning.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Updated Review guidelines (markdown)

Jirka Borovec 2020-10-22 21:09:36 +02:00
parent e0f9e07723
commit 88f14dbfbc
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Review-guidelines.md

@ -52,9 +52,13 @@
- Make sure this works with 16-bit precision. - Make sure this works with 16-bit precision.
### 5. Check if the change is mentioned in CHANGELOG ### 5. Check if the change is mentioned in CHANGELOG
- Any bugfix, feature, substantial change in code behaviour shall be included - Any bugfix, feature, substantial change in code behavior shall be included
- No need for typos, docs, and CI edits - No need for typos, docs, and CI edits
- [this is testing suggestion] make 2 line spacing between all items in "active" section (unreleased changes), this shall prevent collisions in git, later before release we format the active section at once - [this is a testing suggestion] make 2 line spacing between all items in the "active" section (unreleased changes), this shall prevent collisions in git, later before release we format the active section at once
### 6. Ready to go :]
- If you as a reviewer find the PR fine, and all tests are passing, you can place the label "Ready-to-go".
- This "Ready-to-go" labels shall not be used by the PR author 8-]
## Approving PRs ## Approving PRs