From 88f14dbfbc9b55d24fd7d929d68d190aeb2ed11f Mon Sep 17 00:00:00 2001 From: Jirka Borovec Date: Thu, 22 Oct 2020 21:09:36 +0200 Subject: [PATCH] Updated Review guidelines (markdown) --- Review-guidelines.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Review-guidelines.md b/Review-guidelines.md index b9e2aa4..8c7dac3 100644 --- a/Review-guidelines.md +++ b/Review-guidelines.md @@ -52,9 +52,13 @@ - Make sure this works with 16-bit precision. ### 5. Check if the change is mentioned in CHANGELOG -- Any bugfix, feature, substantial change in code behaviour shall be included +- Any bugfix, feature, substantial change in code behavior shall be included - No need for typos, docs, and CI edits -- [this is testing suggestion] make 2 line spacing between all items in "active" section (unreleased changes), this shall prevent collisions in git, later before release we format the active section at once +- [this is a testing suggestion] make 2 line spacing between all items in the "active" section (unreleased changes), this shall prevent collisions in git, later before release we format the active section at once + +### 6. Ready to go :] +- If you as a reviewer find the PR fine, and all tests are passing, you can place the label "Ready-to-go". +- This "Ready-to-go" labels shall not be used by the PR author 8-] ## Approving PRs