edenlightning
7c36c4a413
remove logging from callback ( #3939 )
2020-10-07 10:42:40 -04:00
William Falcon
575e01be82
tests for multiple optimizers and dataloader combinations ( #3937 )
...
* added tests for multiple optimizers and dataloaders
* added tests for multiple optimizers and dataloaders
* added tests for multiple optimizers and dataloaders
2020-10-07 10:13:57 -04:00
Jirka Borovec
05cb6fcc58
Update ci_dockers.yml ( #3935 )
2020-10-07 08:26:07 -04:00
Sean Naren
2aebf65241
Test to ensure ckpt filepath contains correct val score ( #3933 )
...
* Added test to ensure ckpt filepath contains the correct val score reported from the trainer
* Modified to check all saved ckpt files
2020-10-07 07:43:17 -04:00
ananthsub
0c5ca4e2b8
Update lightning.py ( #3929 )
2020-10-07 07:40:38 -04:00
ananthsub
d3f40d6a9e
Update to_disk to use fsspec for remote file support ( #3930 )
...
* Update supporters.py
* Update CHANGELOG.md
* Update supporters.py
* Update supporters.py
* Update supporters.py
* Update supporters.py
* Update supporters.py
* Update supporters.py
* Update CHANGELOG.md
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-10-07 07:28:23 -04:00
William Falcon
9c415d2c71
moves configure ddp to each backend ( #3924 )
...
* moves configure ddp to each backend
* moves configure ddp to each backend
* moves configure ddp to each backend
* added torch manual seed in test_mean_error
* test for complicated batch structure
* test for complicated batch structure
* test for complicated batch structure
Co-authored-by: ananyahjha93 <ananya@pytorchlightning.ai>
2020-10-07 00:50:16 -04:00
Adrian Wälchli
d65b037a40
Mocking Loggers Part 5/5 (final) ( #3926 )
...
* base
* add xfail
* new test
* import
* missing import
* xfail if not installed
include mkpatch
fix test
* mock comet
comet mocks
fix test
remove dep
undo merge duplication
* line
* line
* convert doctest
* doctest
* docs
* prune Results usage in notebooks (#3911 )
* notebooks
* notebooks
* revamp entire metrics (#3868 )
* removed metric
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* added new metrics
Co-authored-by: Teddy Koker teddy.koker@gmail.com
* pep8
Co-authored-by: Teddy Koker teddy.koker@gmail.com
* pep8
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* docs
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* docs
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* win ddp tests skip
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* win ddp tests skip
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* win ddp tests skip
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* win ddp tests skip
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* reset in compute, cache compute
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* reduce_ops handling
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* sync -> sync_dist, type annotations
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* wip docs
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* mean squared error
* docstring
* added mean ___ error metrics
* added mean ___ error metrics
* seperated files
* accuracy doctest
* gpu fix
* remove unnecessary mixin
* metric and accuracy docstring
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* metric docs
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* pep8, changelog
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* refactor dist utils, pep8
* refactor dist utils, pep8
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* Callback docs with autosummary (#3908 )
* callback docs with autosummary
* do not show private methods
* callback base docstring
* skip some docker builds (temporally pass) (#3913 )
* skip some docker builds
* todos
* skip
* use badges only with push (#3914 )
* testtube
* mock test tube
* mock mlflow
* remove mlflow
* clean up
* test
* test
* test
* test
* test
* test
* code blocks
* remove import
* codeblock
* logger
* wandb causes stall
Co-authored-by: William Falcon <waf2107@columbia.edu>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Ananya Harsh Jha <ananya@pytorchlightning.ai>
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
Co-authored-by: Jeff Yang <ydcjeff@outlook.com>
2020-10-06 23:49:06 -04:00
William Falcon
1a345a4a78
test for complicated batch structure ( #3928 )
...
* test for complicated batch structure
* test for complicated batch structure
2020-10-06 23:14:51 -04:00
William Falcon
71a4c61f6e
fixes #3871 ( #3919 )
...
* fixes #3871
* ✅ tests
* ✅ tests
* ✅ tests
* ✅ tests
* ✅ tests
* ✅ tests
* ✅ tests
* moves sync bn to each backend
* moves sync bn to each backend
Co-authored-by: nateraw <nxr9266@g.rit.edu>
2020-10-06 22:56:34 -04:00
William Falcon
e3007ffe0c
moves sync bn to each backend ( #3925 )
2020-10-06 22:42:33 -04:00
William Falcon
af5887c0aa
fixed ddp flag crash ( #3927 )
2020-10-06 22:41:08 -04:00
Adrian Wälchli
9928125768
Mocking Loggers (part 4c, mlflow) ( #3889 )
...
* base
* add xfail
* new test
* import
* missing import
Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-10-06 21:55:59 -04:00
William Falcon
d71ed277d4
moves init apex from LM to apex connector ( #3923 )
2020-10-06 21:31:56 -04:00
Adrian Wälchli
c1559a1476
Mocking Loggers (part 4b, mlflow) ( #3885 )
...
* base
* mock test
Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-10-06 20:50:06 -04:00
ananthsub
6c47535de8
Update tensorboard.py ( #3920 )
2020-10-06 20:34:15 -04:00
Ananya Harsh Jha
4cd14c4237
fixes metrics pickle issue ( #3921 )
...
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
2020-10-06 20:33:57 -04:00
Adrian Wälchli
db0e295f67
Complete mocking Comet and remove dep ( #3910 )
...
* xfail if not installed
include mkpatch
fix test
* mock comet
comet mocks
fix test
remove dep
undo merge duplication
* line
* line
* convert doctest
* doctest
* docs
2020-10-06 19:50:42 -04:00
edenlightning
335bb75356
update docs on logging ( #3916 )
...
* Update loggers.rst
* Update loggers.rst
* Update index.rst
* Create logging.rst
* Delete experiment_reporting.rst
* Delete experiment_logging.rst
* Update __init__.py
2020-10-06 18:53:39 -04:00
Jirka Borovec
217043bc9d
use badges only with push ( #3914 )
2020-10-06 17:30:16 -04:00
Jirka Borovec
7f4a9b75f3
skip some docker builds (temporally pass) ( #3913 )
...
* skip some docker builds
* todos
* skip
2020-10-06 17:29:43 -04:00
Jeff Yang
fe5b943965
Callback docs with autosummary ( #3908 )
...
* callback docs with autosummary
* do not show private methods
* callback base docstring
2020-10-06 17:28:45 -04:00
Ananya Harsh Jha
f76bc5254e
revamp entire metrics ( #3868 )
...
* removed metric
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* added new metrics
Co-authored-by: Teddy Koker teddy.koker@gmail.com
* pep8
Co-authored-by: Teddy Koker teddy.koker@gmail.com
* pep8
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* docs
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* docs
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* win ddp tests skip
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* win ddp tests skip
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* win ddp tests skip
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* win ddp tests skip
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* reset in compute, cache compute
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* reduce_ops handling
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* sync -> sync_dist, type annotations
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* wip docs
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* mean squared error
* docstring
* added mean ___ error metrics
* added mean ___ error metrics
* seperated files
* accuracy doctest
* gpu fix
* remove unnecessary mixin
* metric and accuracy docstring
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* metric docs
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* pep8, changelog
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
* refactor dist utils, pep8
* refactor dist utils, pep8
Co-authored-by: Teddy Koker <teddy.koker@gmail.com>
2020-10-06 17:03:24 -04:00
Jirka Borovec
4722cc0bf0
prune Results usage in notebooks ( #3911 )
...
* notebooks
* notebooks
2020-10-06 16:57:56 -04:00
Nathan Painchaud
c510a7f900
Additional test for logging during validation loop ( #3907 )
...
* Added test for logging in validation step when using dict dataset with string value
* fix recursive issue
* fix recursive issue
Co-authored-by: Nathan Painchaud <nathanpainchaud@gmail.com>
Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-10-06 15:27:18 -04:00
Jirka Borovec
064ae53d63
nb steps in early stop ( #3909 )
...
* nb steps
* if
* skip
* rev
* seed
* seed
2020-10-06 15:20:08 -04:00
maxjeblick
39b3704285
add current_epoch to dumped_params ( #3261 )
...
* add current epoch to __dumped_params
* log
* reset
* add to test
* Update CHANGELOG.md
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <jirka@pytorchlightning.ai>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2020-10-06 19:54:48 +02:00
Lezwon Castelino
69833dad5b
Added check to verify xla device is TPU ( #3274 )
...
* tpu device check
* replaced with xmp spawn
* Revert "replaced with xmp spawn"
This reverts commit 6835380f
* replaced all instances of XLA_AVAILABLE
* moved inner_f to global scope
* made refactors
* added changelog
* added TPU_AVAILABLE variable
* fix codefactor issues
* removed form trainer and early stopping
* add TORCHXLA_AVAILABLE check
* added tests
* refactoring
* Update pytorch_lightning/utilities/xla_device_utils.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* updated function names
* fixed bug
* updated CHANGELOG.md
* added todo
* added type hints
* isort and black
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-10-06 19:54:37 +02:00
William Falcon
2cf17a3718
Adds tests to make sure logging doesn't happen multiple times ( #3899 )
...
* Makes sure logging doesn't ever happen from non-root zero
* Makes sure logging doesn't ever happen from non-root zero
* Makes sure logging doesn't ever happen from non-root zero
* added bug report model
* fix local model
* fix local model
* fix local model
* fix local model
2020-10-06 12:43:51 -04:00
Sean Naren
e4a56fa5cf
Ensure global seed exists before passing into env subprocess.Popen call ( #3904 )
2020-10-06 12:31:49 -04:00
Jirka Borovec
f55a9cf63a
fic CI parsing Horovod version ( #3804 )
2020-10-06 17:18:16 +02:00
Teddy Koker
9600926619
Rename log_save_interval, row_log_interval ( #3748 )
...
* Rename row_log_interval -> log_every_n_steps
log_save_interval -> flush_logs_every_n_steps
* Changelog
* fixed title underline length
* typo
* Update pytorch_lightning/trainer/trainer.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* Update pytorch_lightning/trainer/trainer.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* pep8 + deprecation test
* 'todo: remove in 1.1 comment'
* 1.1 -> 0.11
* log
* docs
* depr API
* add depr tests
* note
* miss
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <jirka@pytorchlightning.ai>
2020-10-06 10:27:06 -04:00
Adrian Wälchli
6272fd39b3
xfail if not installed ( #3860 )
...
include mkpatch
fix test
2020-10-06 10:00:09 -04:00
edenlightning
e6e5406511
update bug template ( #3902 )
2020-10-06 09:26:37 -04:00
Nicki Skafte
f745c4a773
doc update ( #3894 )
2020-10-06 09:13:29 -04:00
Nicki Skafte
3ab43dd779
Fix lr finder for optimizers with states ( #3897 )
...
* fix lr finder
* changelog
* add test
2020-10-06 09:12:29 -04:00
William Falcon
04303b3a2e
added bug report model ( #3901 )
2020-10-06 09:05:20 -04:00
Jeff Yang
90929fa433
Fix apt repo issue for docker ( #3823 )
...
* fix docker repo issue
* docker
* docker
* docker
* no cudnn
* no cudnn
* try 16.04
Co-authored-by: Jirka Borovec <jirka@pytorchlightning.ai>
2020-10-05 23:18:14 -04:00
William Falcon
cb2a3265e5
Fixes #2936 (no fix needed) ( #3892 )
2020-10-05 23:15:52 -04:00
Adrian Wälchli
893bed741f
Mocking Loggers (part 3b, comet) ( #3853 )
...
* ref
* Mocking Loggers (part 3c, comet) (#3859 )
* mock comet
* new line
2020-10-05 23:00:54 -04:00
edenlightning
2119184801
Fix docs for auto_lr_find ( #3883 )
...
* Fix docs for auto_lr_find
* change testcode to codeblock
we are not showing a complete example here
2020-10-05 22:28:38 -04:00
Adrian Wälchli
0823cdd59c
Mocking Loggers (part 4a, mlflow) ( #3884 )
...
* extensive mlflow test
* revert accidental commits
2020-10-05 22:27:06 -04:00
William Falcon
b34c7add23
Fixes #3668 , #3887 as a bonus ( #3888 )
...
* Fixes #3668 , #3887 as a bonus
* Fixes #3668 , #3887 as a bonus
2020-10-05 21:30:41 -04:00
Nathan Raw
1954d7c87a
Write predictions in LightningModule instead of EvalResult ( #3882 )
...
* ✨ add self.write_prediction
* ✨ add self.write_prediction_dict to lightning module
2020-10-05 18:04:02 -04:00
Jean-Baptiste SCHIRATTI
cea5f1f538
Fix for `load_from_checkpoint` ( #2776 )
...
* Fix.
* Fix #2550 : allow to load model from checkpoint if self.save_hyperparameters() was not called.
* Fix? Cleaner way of not calling self.save_hyperparameters in EvalModelTemplate.
* Fix? `_load_model_state` cleanup
* Fix?
* Fix #2550 : allow to load model from checkpoint if self.save_hyperparameters() was not called.
* Fix.
* Fix? Cleaner way of not calling self.save_hyperparameters in EvalModelTemplate.
* Fix? `_load_model_state` cleanup
* Fixed side effect in `test_load_model_from_checkpoint_extra_args`.
* Apply suggestions from code review
* fix
* try
* fixed missing arg in evalmodel
* fixed missing arg in evalmodel
* fix
* update
* fix loading
* add test
* prune
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <jirka@pytorchlightning.ai>
Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-10-05 12:44:23 -04:00
Nrupatunga
7d47ed178b
[Bug-Fix]:properties `current_epoch` and `global_step` between model and trainer same always ( #3785 )
...
* make current_epoch and global_step to be same as trainer, after model restore.
* remove assignment here
* test
* minor modification
* Update pytorch_lightning/core/lightning.py
type check, better clarity
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
* Update pytorch_lightning/core/lightning.py
type check, better clarity
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
* comments for current_epoch and global_step properties
* Update tests/models/test_restore.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* update comments according to the changes made
* Update tests/models/test_restore.py
* add current_epoch, global_step to jit ignore list
* Add comments to CHANGELOG
* Update CHANGELOG.md
* Update tests/models/test_restore.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-10-05 11:10:40 -04:00
Jirka Borovec
6ac0958166
fix init nan for checkpointing ( #3863 )
...
* add test for checkpoint nan
* fix
* pep
2020-10-05 07:36:12 -04:00
William Falcon
b014223f72
Fixes #2678 - enables training_step to return None ( #3862 )
...
* Fixes #2678 - enables training_step to return None
* Fixes #2678 - enables training_step to return None
2020-10-05 07:33:46 -04:00
Paul Baumstark
e2437ebf3f
Update lightning_module.rst ( #3854 )
...
`*_epoch_out` methods expects a return of None.
2020-10-04 23:34:27 -04:00
William Falcon
d787208e76
Fixes #2792 ( #3857 )
2020-10-04 23:25:02 -04:00