Rafał Jankowski
c6478414ee
Fixed uploading best model checkpoint in NeptuneLogger ( #10369 )
2021-12-01 13:58:54 +00:00
Carlos Mocholí
8e1b9b306c
Skip hanging spawn tests ( #10838 )
...
* Skip hanging spawn tests
* Docstring fix
* Add back to TPU spawn
2021-11-30 18:36:12 +00:00
Carlos Mocholí
38ed26ec5a
Do not require omegaconf to run tests ( #10832 )
2021-11-30 14:48:03 +00:00
thomas chaton
6fe6e9e414
Delete TensorBoardLogger experiment before spawning the processes. ( #10777 )
2021-11-26 17:07:57 +00:00
Carlos Mocholí
0fa07da987
Fail the test when a `DeprecationWarning` is raised ( #9940 )
2021-11-17 23:41:50 +01:00
Carlos Mocholí
6dfcb6afc5
Skip strategy=ddp_spawn, accelerator=cpu, python>=3.9 tests ( #10550 )
2021-11-16 10:06:47 +05:30
Espen Haugsdal
89e1360e75
Fix pickling error with CSVLogger ( #10388 )
...
* Don't store csv.Dictwriter in ExperimentWriter
* Add test for pickle after .save()
* Add entry in changelog
2021-11-08 10:36:35 +00:00
Adrian Wälchli
3f9dfe4949
Fix iterating over a DummyLogger when `fast_dev_run > 0` ( #10232 )
2021-10-29 07:22:59 +00:00
Danielle Pintz
203737bfce
Don't raise DeprecationWarning for `LoggerConnector.gpus_metrics` ( #9959 )
2021-10-18 22:51:09 +00:00
Kaushik B
5e8829b97d
(1/n) tests: Use strategy flag instead of accelerator for training strategies ( #9931 )
...
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-10-16 20:40:25 +05:30
ananthsub
28fc8d2016
Add `enable_model_summary` flag and deprecate `weights_summary` ( #9699 )
...
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kaushik B <kaushikbokka@gmail.com>
2021-10-13 17:20:54 +05:30
Rohit Gupta
db322f4bbb
Deprecate `checkpoint_callback` from the `Trainer` constructor in favour of `enable_checkpointing` ( #9754 )
...
* enable_chekpointing
* update codebase
* chlog
* update tests
* fix warning
* Apply suggestions from code review
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Apply suggestions from code review
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
* Apply suggestions from code review
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-10-12 07:55:07 +00:00
Boris Dayma
2db9ea3500
feat(wandb): support media logging ( #9545 )
2021-10-11 10:15:36 +01:00
Rohit Gupta
4decbc0d95
Deprecate `dataloader_idx` from `on_train_batch_start/end` ( #9816 )
...
* deprecate hooks
* dep todo
* explicit
* Apply suggestions from code review
* Apply suggestions from code review
* code review
* base
2021-10-07 10:18:11 +00:00
Danielle Pintz
b3a5c7f442
Add `enable_progress_bar` to Trainer constructor ( #9664 )
2021-09-24 22:53:31 -07:00
Adrian Wälchli
714331bb7b
Report leaking environment variables in tests ( #5872 )
...
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
2021-09-24 12:39:57 +02:00
jjenniferdai
cc77367ffc
Deprecate `LightningLoggerBase.close` ( #9422 )
...
* deprecate loggerbase.close
* deprecate warning
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* add to changelog
* fix import
* fix import alphabetize
* spacing?
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* copy-paste avoid pre-commit.ci?
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* literally match the other comment
* unindent
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* suggest finalize instead of save
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update tests/loggers/test_base.py
* format but to be formatted
* Update pytorch_lightning/loggers/base.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update pytorch_lightning/loggers/base.py
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update pytorch_lightning/loggers/base.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-09-20 22:00:09 +00:00
ananthsub
856ed10581
Improve collision check on hparams between LightningModule and DataModule ( #9496 )
...
* fix hyperparameter logging between LightningModule and DataModule
2021-09-17 18:12:54 +00:00
Adrian Wälchli
b9fa69ea57
mark `FitLoop.should_accumulate` as protected ( #9515 )
...
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-09-15 13:32:14 +00:00
edward-io
c784092013
deprecate flush_logs_every_n_steps on Trainer ( #9366 )
2021-09-14 11:27:56 +01:00
Jakub Kuszneruk
ee3787216a
Adapt `NeptuneLogger` to new `neptune-client` api ( #6867 )
...
* Initial split to NeptuneLegacyLogger and NeptuneLogger
* Adapt NeptuneLogger to neptune-pytorch-lightning repo version
* Fix stylecheck and tests
* Fix style and PR suggestions
* Expect Run object in NeptuneLogger.init
* Model checkpoint support and restructured tests
* Reformat code - use " instead of '
* Fix logging INTEGRATION_VERSION_KEY
* Update CHANGELOG.md
* Fix stylecheck
* Remove NeptuneLegacyLogger
* updated neptune-related docstrings
* PR suggestions
* update CODEOWERS file
* move import logic to imports.py
* minor neptune.py improvements
* formatting fixes and minor updates
* Fix generation of docs
* formatting fixes and minor updates
* fix
* PR fixes vol. 2
* define return type of _dict_paths method
* bump required version of `neptune-client`
* Enable log_* functions
* Update pytorch_lightning/loggers/neptune.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* Revert "Enable log_* functions"
This reverts commit 050a436899b7f3582c0455dc27b171335b85a3a5.
* Make global helper lists internal
* Logger's `name` and `version` methods return proper results
* Initialize Run and its name and id at logger init level
* Make _init_run_instance static
* Add pre-commit hook code changes.
* Fix blacken-docs check
* Fix neptune doctests and test_all
* added docs comment about neptune-specific syntax
* added docs comment about neptune-specific syntax in the loggers.rst
* fix
* Add pickling test
* added myself to neptune codeowners
* Enable some of deprecated log_* functions
* Restore _run_instance for unpickled logger
* Add `step` parameter to log_* functions
* Fix stylecheck
* Fix checkstyle
* Fix checkstyle
* Update pytorch_lightning/loggers/neptune.py
Co-authored-by: thomas chaton <thomas@grid.ai>
* Fix tests
* Fix stylecheck
* fixed project name
* Fix windows tests
* Fix stylechecks
* Fix neptune docs tests
* docformatter fixes
* De-duplicate legacy_kwargs_msg
* Update .github/CODEOWNERS
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: kamil-kaczmarek <kamil.kaczmarek@neptune.ml>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
2021-09-10 18:48:58 +02:00
Jirka Borovec
6e124e7207
CI: precommit - docformatter ( #8584 )
...
* CI: precommit - docformatter
* fix deprecated
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-09-06 12:49:09 +00:00
Soham Tiwari
861f8afeea
[bugfix] Changed CometLogger to stop modifying metrics in place ( #9150 )
...
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-08-31 08:21:16 +00:00
Adrian Wälchli
dfae7342cc
sanitize arrays when logging as hyperparameters in TensorBoardLogger ( #9031 )
...
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
2021-08-24 13:02:06 +02:00
ananthsub
930b81f96c
Remove unused rank_zero_deprecation in WandB logger ( #9034 )
...
* Remove unused imports in WandB logger and corresponding test
2021-08-22 12:58:48 +01:00
Adrian Wälchli
ad3f183bc3
convert warning cache usage to rank_zero_only in WandbLogger ( #8764 )
2021-08-20 10:39:25 +00:00
Adrian Wälchli
3ef8cd654d
Add warning when `wandb.run` already exists ( #8714 )
...
Co-authored-by: thomas chaton <thomas@grid.ai>
2021-08-10 10:14:48 +02:00
Adrian Wälchli
346cef2c3c
Fix tests for new tensorboard >= 2.6 ( #8789 )
2021-08-09 15:12:38 +02:00
Thien Tran
052aefc342
WandbLogger to log model topology by default ( #8662 )
...
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-08-04 10:36:57 +00:00
Carlos Mocholí
e63968ab88
Add `pyupgrade` to `pre-commit` ( #8557 )
...
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-07-26 14:38:12 +02:00
Carlos Mocholí
a64cc37394
Replace `yapf` with `black` ( #7783 )
...
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2021-07-26 13:37:35 +02:00
Carlos Mocholí
f7027a8701
Remove `torch >= 1.6` checks ( #8523 )
2021-07-23 04:03:20 +00:00
deepsource-autofix[bot]
cbf71d0a14
Remove unnecessary comprehension ( #8405 )
2021-07-19 08:30:24 +00:00
Carlos Mocholí
6ce77a102b
Set minimum PyTorch version to 1.6 ( #8288 )
...
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
2021-07-13 17:12:49 +00:00
Kaushik B
9d5ad7639c
Add logger flag to save_hyperparameters ( #7960 )
...
* Add log flag to save_hyperparameters
* FIx setter
* Add test & Update changelog
* Address comments
* Fix conflicts
* Update trainer
* Update CHANGELOG.md
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* Fix datamodule hparams fix
* Fix datamodule hparams fix
* Update test with patch
* Update pytorch_lightning/utilities/hparams_mixin.py
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
* Move log_hyperparams to mixin
* Update hparams mixin
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-07-13 11:36:36 +02:00
Carlos Mocholí
733cdbb9ad
`every_n_val_epochs` -> `every_n_epochs` ( #8383 )
2021-07-13 01:20:20 +02:00
Carlos Mocholí
07d7c37a79
Remove magic monitor support for `ModelCheckpoint` ( #8293 )
2021-07-07 18:36:19 +01:00
Adrian Wälchli
4becd1cf31
rename old `Trainer.train_loop` -> `Trainer.fit_loop` ( #8025 )
2021-06-22 11:49:32 +02:00
Jirka Borovec
15be986558
add logger to __all__ ( #6854 )
2021-06-09 13:07:02 +00:00
Kaushik B
7f4ef6d135
Fix logs overwriting issue for remote fs ( #7889 )
...
* Fix logs overwriting issue for remote fs
* Add test
2021-06-09 11:05:01 +02:00
Boris Dayma
9097347ea8
feat(wandb): log models as artifacts ( #6231 )
...
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-05-27 20:15:02 +02:00
Carlos Mocholí
e2ead9abd7
Refactor some loops code and hook tests ( #7682 )
2021-05-25 13:27:54 +02:00
i-aki-y
7eafd8eac6
Add run_name argument to the MLFlowLogger constructor ( #7622 )
...
* Add run_name argument to the MLFlowLogger
* Update CHANGELOG
* Fix unnecessary line
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Fix style by using yapf
* Fix import error when mlflow is not installed
* Update CHANGELOG.md
* Update tests/loggers/test_mlflow.py
Co-authored-by: akiyuki ishikawa <aki.y.ishikwa@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-05-21 09:17:32 +01:00
Jan-Henrik Lambrechts
608de6abf4
TensorBoardLogger sub_dir parameter for grouping logs ( #6195 )
...
* fixed a small typo
* cleaning up
* added sub_dir argument to tensorboard and wrote test
* sub dir arg exclusively for tensorboard, linted
* resolving merge conflict
* resolved merge conflict
* resolved merge conflict
* resolved merge conflict
* resolve merge conflict before revert
* resolving merge conflict
* reverted to pre-lint
* added tensorboard sub_dir test
* pep8 formatting
* removed sub_dir arg from test_all function:
* updated feature description
* typo in doc description
* updated CHANGELOG
* Update pytorch_lightning/loggers/tensorboard.py
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
* swapped argument position
* added expandvars tests
* added expandvars
* removed model init
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* fix tests
* fix failed test
* Revert "fix failed test"
This reverts commit 50b34c66da
.
* add env var to test
* fix typo in tests
* fix tests
* for test consistency
* fix typo
* fix typo 2
Co-authored-by: Ubuntu <azureuser@devhenrik.evuifrmjd4lepbj4relcwwu5va.ax.internal.cloudapp.net>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
2021-05-19 19:50:58 +00:00
Carlos Mocholí
8c0ea92af2
`TrainerState` refactor [5/5] ( #7173 )
...
* `TrainerState` refactor
* flake8
* Update finished check
* Test cleanup
* Fix tests
* Fixes
* Reorder
* flake8
* Update CHANGELOG
* Better docs
* Better docs
* Remove default
* Update tests
* Bad merge
2021-05-04 12:50:56 +02:00
Boris Dayma
2a20102321
fix(wandb): allow custom init args ( #6989 )
...
* feat(wandb): allow custom init args
* style: pep8
* fix: get dict args
* refactor: simplify init args
* test: test init args
* style: pep8
* docs: update CHANGELOG
* test: check default resume value
* fix: default value of anonymous
* fix: respect order of parameters
* feat: use look-up table for anonymous
* yapf formatting
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-05-04 09:45:36 +00:00
thomas chaton
e76ebd640e
[feat] Add BasePredictionWriter 3/3 ( #7127 )
...
* wip
* update
* update
* update
* update
* update
* typo
* update on comments
* update
* update
* update
* update
* update changelog
* update
* Fix merge
* Fix merge
* move code
* resolve test
* add extra test
* add an extra test
* update on comments
* add typing
* resolve flake8
* Refactor and Docs
* Fix tests
* Fix tests
* Fix tests
* Duplicate
* Fix tests
* resolve bug
* update
* update on comments
* Update pytorch_lightning/utilities/imports.py
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
* Update pytorch_lightning/utilities/device_parser.py
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
* update
* update
* update
* update on comments
* resolve flkae8
* update test
* Apply suggestions from code review
* update on comments
* Update pytorch_lightning/callbacks/prediction_writer.py
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
* Update pytorch_lightning/callbacks/prediction_writer.py
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
* Update pytorch_lightning/callbacks/prediction_writer.py
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
* update on comments
* update
* update on comment
* Apply suggestions from code review
* update
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-04-27 20:23:55 +00:00
Alessio Bonfiglio
ac7d6a35c3
Fix `NeptuneLogger.log_text(step=None)` ( #7194 )
2021-04-26 15:28:55 +02:00
Tharindu Hasthika
c502e47abf
Fixed setting of _save_dir when run initiated externally ( #7106 )
...
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2021-04-23 01:14:46 +00:00
Jirka Borovec
ef5feac7ba
fix version + yapf ( #6999 )
2021-04-22 18:25:51 +00:00