Commit Graph

3040 Commits

Author SHA1 Message Date
William Falcon 43b8d62ccb
Update README.md 2020-09-05 08:07:03 -04:00
Will Price 64ee25ed9c
Correct documentation examples of `optimizer_step` (#3326)
* Correct documentation examples of `optimizer_step`

Without the default arguments set in `optimizer_step` the examples fail due to the arguments not being provided

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2020-09-04 18:57:21 +02:00
William Falcon 227959b3df
added emb similarity (#3349) 2020-09-04 09:45:21 -04:00
Adrian Wälchli 7bd2f946d9
Ref: Pull duplicate data interface definition up into DataHooks class (#3344)
* pull data hooks up into a common interface

* fix multiple inheritance ordering

* docs reference datahooks
2020-09-04 06:04:45 -04:00
Rohit Gupta 24809b0b26
Refactor GPUStatsMonitor to improve training speed (#3257)
* Refactor GPUMonitor to improve training speed

* added gpu ids to monitor

* update tests

* added deprecation warning

* pep

* fix test

* fix docs

* fix log_gpu_memory

* move deprecation check

* chlog

* Update CHANGELOG.md

* suggestions and fix

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-09-04 06:02:16 -04:00
Charles Catta 22045b12b1
Fix non autoplaying videos on Safari iOS (#3343) 2020-09-04 08:49:14 +02:00
Adrian Wälchli 48c22c8bad
update batch size in DataModule when auto scaling batch size (#3266)
* fix datamodule hasattr

* fix patch check

* fix setattr

* update docs

* revert patch fix

* changelog

* fix datamodule passed in as fit arg

* docs

* set datamodule batch size in lightning_setattr

* fix merge

* check with has_attr

* access datamodule via trainer

* pass fit args down to tuner

* docs

* fix typos in docs

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2020-09-03 22:07:49 +02:00
Adrian Wälchli 4ad5a78dce
to_torchscript method for LightningModule (#3258)
* script

* docs

* simple test

* move test

* fix doctest

* no grad context

* extend tests


test


test

* datamodule test

* clean up test

* docs

* name

* fix import

* update changelog

* fix import

* skip pytorch 1.3 in test

* update codeblock

* skip bugged 1.4

* typehints

* doctest not working on all pytorch versions

* rename TestGAN to prevent pytest interference

* add note about pytorch version

* fix torchscript version inconsistency in tests

* reset training state + tests

* update docstring

* Apply suggestions from code review

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>

* update docstring, dict return

* add docs to index

* add link

* doc eval mode

* forward

* optional save to file path

* optional

* test torchscript device

* test save load with file path

* pep

* str

* Commit typing suggestion

Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>

* skip test if cuda not available

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
2020-09-03 20:24:44 +02:00
Rohit Gupta 4a22fca524
Changed LearningRateLogger to LearningRateMonitor (#3251)
* Change LearningRateLogger to LearningRateMonitor

* file rename

* docs

* add LearningRateLogger with deprecation warning

* deprecated LearningRateLogger

* move deprecation check

* chlog

Co-authored-by: Jirka Borovec <jirka@pytorchlightning.ai>
2020-09-03 18:17:15 +00:00
Brendan Fahy 2d8c1b7c54
use fsspec instead of gfile for all IO (#3320)
* use fsspec instead of gfile for all IO

This better supports remote (and local) file operations with a dedicated package

* Apply suggestions from code review

Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>

* chlog

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: Jirka Borovec <jirka@pytorchlightning.ai>
2020-09-03 14:19:20 +02:00
HT Liu d521c1b178
Fix: gather_all_tensors cross GPUs in DDP (#3319)
* Fix: gather_all_tensors cross GPUs in metrics

* add a test case for gather_all_tensors_ddp in #3253
2020-09-03 12:27:32 +02:00
nithin varghese ee72271d20
Docs/improved multigpu doc clarity (#3194)
* + clarifying doc

* improved documentation clarity

* docs minor correction

* remove device from type_as

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2020-09-02 17:57:56 +02:00
Jeff Yang b951097758
Add conda version/downloads, discourse badges to readme (#3247)
* add conda badge to readme

* Update README.md

* Update README.md

* Apply suggestions from code review

* make same color with `pypi package`

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-09-02 15:50:02 +00:00
s-rog 65e6687c54
Fix (weights only) checkpoints loading without pl (#3287)
* cast pl AttributeDict to dict

* fix for omegaconf
2020-09-02 15:36:42 +02:00
William Falcon f747cb6843
ref: moving train loop to own object 2/n (intermediate steps) (#3314)
* ref: moving train loop to own object 2/n (intermediate steps)

* ref: moving train loop to own object 2/n (intermediate steps)
2020-09-01 22:06:15 -04:00
William Falcon 0d90d53a81
ref: moving train loop to own object 2/n (intermediate steps) (#3313)
* ref: moving train loop to own object 2/n (intermediate steps)

* ref: moving train loop to own object 2/n (intermediate steps)
2020-09-01 21:06:40 -04:00
William Falcon a5288fea1a
ref: moving train loop to own object (intermediate steps) (#3312)
* ref: moving train loop to own object (intermediate steps)

* ref: moving train loop to own object (intermediate steps)

* ref: moving train loop to own object (intermediate steps)

* ref: moving train loop to own object (intermediate steps)
2020-09-01 18:03:28 -04:00
William Falcon 60d50f646e
ref: train loop refactor (mid-step) (#3310) 2020-09-01 16:32:54 -04:00
William Falcon 0a119403d6
ref: moved accelerator router (#3309)
* ref: moved accelerator

* ref: moved accelerator

* ref: moved accelerator

* ref: moved accelerator
2020-09-01 15:48:28 -04:00
Nicki Skafte b66ce88f0d
[metrics] Renaming of precision recall metric (#3308)
* rename metrics

* update docs
2020-09-01 14:59:33 -04:00
William Falcon 7d57f8d407
ref: move prepare_data to data connector (#3307)
* ref: moved argparse code to central class

* ref: moved argparse code to central class

* ref: moved argparse code to central class
2020-09-01 14:59:09 -04:00
Lezwon Castelino 3910ad0330
bugfix/3185 transpose (#3252)
* change t() to transpose() as xla devices do not support .t() on 1-dim tensor

* detach tensor before copying

* Revert "detach tensor before copying"

This reverts commit 37cc7bbe

* changed dims

* added test_result_obj_on_tpu

* detach before copying

* detach before copying

* detach before copying

* replace torch.cat with sum
2020-09-01 09:17:52 -04:00
Suraj Donthi 8354c4ad6d
Added missing term 'Data' in 'LigthningModuleAPI' (#3284)
* Added missing term 'Data' in 'LigthningModuleAPI'

This could be a possible typo!

* Update datamodules.rst

Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-09-01 11:40:21 +02:00
Zach Rothenberg cecad9f3ef
distinguished between overfit_batches examples (#3298)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-09-01 09:08:18 +00:00
Sumanth Ratna b22a65e2fe
Fix typo in results.rst (#3277) 2020-09-01 09:58:49 +02:00
William Falcon b0298cead8
ref: move train outside of setup training (#3297)
* ref: move train outside of setup training

* ref: move train outside of setup training

* ref: move train outside of setup training

* ref: move train outside of setup training
2020-08-31 20:36:52 -04:00
William Falcon bcd13f70b8
ref: run_pretrain_routine -> setup_training (#3294)
* ref: .tune()

* ref: run_pretrain_routine -> setup_training
2020-08-31 18:06:11 -04:00
William Falcon 805ff37e8c
ref: .tune() (temporary) (#3293)
* ref: .tune()

* ref: .tune()

* ref: .tune()

* ref: .tune()

* ref: .tune()

* ref: .tune()
2020-08-31 17:36:09 -04:00
William Falcon caf7893f27
ref: modular is_overridden (#3290)
* ref: modular is_overridden

* ref: modular is_overridden

* ref: modular is_overridden

* ref: modular is_overridden
2020-08-31 12:12:02 -04:00
William Falcon b0f77a74a1
ref: added data connector (#3285)
* ref: added data connector

* ref: added data connector

* ref: added data connector

* ref: added data connector

* ref: added data connector

* ref: added data connector

* ref: added data connector

* ref: added data connector

* ref: added data connector

* ref: added data connector
2020-08-31 11:08:22 -04:00
edenlightning b4887d7647
Update README.md (#3289) 2020-08-31 10:52:45 -04:00
Akihiro Nitta a91fced3b8
Update docs/source/new-project.rst (#3272) 2020-08-31 16:48:50 +02:00
William Falcon f46318ebfe
clean docs new guide (#3270)
* updated docs

* updated docs

* updated docs

* updated docs

* updated docs
2020-08-30 11:01:16 -04:00
William Falcon 6f3f688c27
updated docs (#3268)
* updated docs

* updated docs
2020-08-30 10:01:09 -04:00
William Falcon 14b28190dd
simplify docs (#3267)
* updated docs

* updated docs

* updated docs

* updated docs

* updated docs

* updated docs
2020-08-30 09:31:36 -04:00
William Falcon 2b3b968064
Simpledocs (#3265)
* updated docs

* updated docs

* updated docs
2020-08-30 06:51:34 -04:00
Carlos Mocholí cc80749c7e
Parse Union[bool, str] arguments (#3235)
* Parse Union[bool, str] arguments

* Address review

Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-08-29 10:39:42 -04:00
Jeremy Jordan a5d1176cf6
callback method for on_save_checkpoint (#2501)
* initial draft

* fix test

* Update pytorch_lightning/trainer/callback_hook.py

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* fix tests

* remove old code

* untested upgrade script

* document limitations

* clean up and add tests

* Update pytorch_lightning/trainer/training_io.py

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* reflect PR comments

* fix formatting

* Update docs/source/callbacks.rst

* clarify docs

* revert change for loading checkpoints

* small edits

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
2020-08-28 16:50:52 +02:00
James Bockman 79375e6d0a
Bug Fix: Remote Logging with Tensorboard (#3236)
* Changed standard open to cloud_open

* Changed how version numbers are extracted to remove terminal / from paths

* formatting

Co-authored-by: James Bockman <james@aiml.team>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-08-28 07:01:35 -04:00
monney d5254ff9df
warn user when dropping unpicklable hparams (#2874)
* refactored clean_namespace

* Update try except to handle pickling error

* Consolidated clean_namespace. Added is_picklable

* PEP8

* Change warning to use rank_zero_warn. Added Test to ensure proper hparam filtering

* Updated imports

* Corrected Test Case
2020-08-28 09:07:43 +02:00
Rohit Gupta 85cd558a3f
Follow up of #2892 (#3202)
* Follow up of #2892

* typo

* iterabledataset
2020-08-27 15:28:29 -04:00
Ananya Harsh Jha 40eaa2143e
add desc for minimize (#3216) 2020-08-27 14:25:39 -04:00
Rohit Gupta f03943ee94
Fix GpuUsageLogger to work on different platforms (#3008)
* Fix GpuUsageLogger

* docstrings

* misconfigexception

* add basic tests

* skip doctest

* fix parameter and docstring

* rm cl

* skip doctest

* cleanup

* chlog

* add suggestions from review

* add test from suggestions

* fix import

* fix test

* fix test

* fix test

* fix test

* rename GpuUsageLogger to GPUStatsMonitor

* doc fix

* Apply suggestions from code review

* update docs format

* update docs

* miss

* merge

* fix title formatting

* unindent

* punctuation

* simplify if statements

* fix test

* suggestions

* pep

* Update CHANGELOG.md

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* fix on_train_batch_*

* use AttributeDict

* usage

* rank zero

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

* import

* minor changes

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Adrian Wälchli <adrian.waelchli@inf.unibe.ch>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2020-08-27 19:50:32 +02:00
William Falcon b9319d6a42
Update __init__.py 2020-08-27 11:52:51 -04:00
Lezwon Castelino 8b504a15da
update core contributors (#3224) 2020-08-27 11:27:54 -04:00
William Falcon f3c63f7746
tests to ensure correct dataloader calls (#3221)
* tests to ensure correct dataloading interval and sequence

* tests to ensure correct dataloading interval and sequence

* tests to ensure correct dataloading interval and sequence

* tests to ensure correct dataloading interval and sequence

* tests to ensure correct dataloading interval and sequence
2020-08-27 09:49:46 -04:00
Philipp Singer 0aee137ba7
DP device fix (#3196) 2020-08-27 09:01:29 -04:00
Duc Pham 4d98419bb8
Fix potential typo in early stopping `monitor` keys (#3213)
* Fix typo

* ref: group prepare data hook (6) (#3212)

* group prepare data hook

* group prepare data hook

* group prepare data hook

* group prepare data hook

* group prepare data hook

* group prepare data hook

* group prepare data hook

* Fix typo

Co-authored-by: William Falcon <waf2107@columbia.edu>
2020-08-26 22:21:30 -04:00
William Falcon 464a0e7bb1
ref: group prepare data hook (6) (#3212)
* group prepare data hook

* group prepare data hook

* group prepare data hook

* group prepare data hook

* group prepare data hook

* group prepare data hook

* group prepare data hook
2020-08-26 22:20:00 -04:00
William Falcon be0438bb47 group fit data links 2020-08-26 21:34:55 -04:00