230f2b723c
update mergify - master only ( #5682 )
2021-02-05 21:40:40 +01:00
8e04646690
Filter "unsqueeze" warning when using DP ( #5622 )
...
* filtering unsqueeze warning directly in DP
* add changelog
* constrain to module
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-02-05 21:40:40 +01:00
df5cbf5368
resolve conflict
...
resolve failing test
2021-02-05 21:40:39 +01:00
bb7d188318
Fix ModelCheckpoint race condition in file existence check ( #5155 )
...
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
2021-02-05 21:40:39 +01:00
605c5a8c9a
Fix `num_classes` arg in F1 metric ( #5663 )
...
* fix f1 metric
* Apply suggestions from code review
* chlog
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
2021-02-05 21:40:30 +01:00
1feff5d774
move progress bar test to correct test folder ( #5667 )
2021-02-05 21:40:29 +01:00
e1e47ac628
new section + legacy 1.1.6 ( #5666 )
2021-02-05 21:40:29 +01:00
d8f2d8e15a
[Feat-BugFix] Resolve custom DataLoader ( #5745 )
...
* resolve custom dataloader
* update changelog
* fix tests
* update on comments
* resolve comments
* add support for custom batch_sampler
* Update tests/trainer/test_data_loading.py
* resolve test
* resolve flake8
* resolve yapf
Co-authored-by: Ubuntu <ubuntu@ip-172-31-88-60.ec2.internal>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
2021-02-05 09:03:18 +00:00
d2c2e5004d
fix tests
2021-02-04 20:55:58 +01:00
e633787a3d
flake8 + yapf
2021-02-04 20:55:58 +01:00
eb81b7d40c
Prepare 1.1.6 release ( #5661 )
...
* Parepre 1.1.6 release
* Remove headers
* Apply suggestions from code review
* docs: Apply docs suggestions for release
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
(cherry picked from commit c462b274ee
2021-02-04 20:55:58 +01:00
524675705a
Sync working directory with all processes when using Hydra ( #5629 )
...
* Append current work dir (hydra dir) to ensure all processes reference the same directory
* Add changelog
* Add different job name for DDP child processes to log to
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit ca68cac57a
2021-02-04 20:55:41 +01:00
c62f68c7cd
passing batch outputs to on_train_batch_end ( #4369 )
...
* passing batch outputs to on_train_batch_end
* styling
* updating epoch end logic
* also condition on on_train_epoch_end hooks
* more readable
* pep8
* pep8
* readability suggestion accepted
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* adding test_training_epoch_end_metrics_collection_on_override test
* fix formatting
* fix formatting
Co-authored-by: Swetha Mandava <smandava@nvidia.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
(cherry picked from commit 5fcca4e43b
2021-02-04 20:55:41 +01:00
da5ba50727
Unify attribute finding logic, fix not using dataloader when hparams present ( #4559 )
...
* Rebase onto master
* indent fix
* Remove duplicated logic
* Use single return
* Remove extra else
* add `__contains__` to TestHparamsNamespace to fix tests
* Fix lightning_setattr to set all valid attributes
* update doc
* better names
* fix holder order preference
* tests for new behavior
* Comment about using the last holder
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Sean Naren <sean.narenthiran@gmail.com>
(cherry picked from commit eee3b1a284
2021-02-04 20:55:41 +01:00
cc38d4c342
[bugfix] Resolve bug with multiple optimizers and toggle. ( #5574 )
...
* fix toggle_optimizer
* update doc
* resolve bug
* update
* Update pytorch_lightning/core/lightning.py
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* update on comments
* update on comments
* update
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
(cherry picked from commit c76cc23b3d
2021-02-04 20:55:41 +01:00
97e1516349
Fix Metric.state_dict ( #5614 )
...
* Fix Metric.state_dict
* Update CHANGELOG.md
* Update CHANGELOG.md
* Detach tensors in a list if needed
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit e87424adfb
2021-02-04 20:55:41 +01:00
3ca1fbbf49
Ignore `step` param in Neptune logger's log_metric method ( #5510 )
...
* Ignore `step` param in Neptune logger's log_metric method
The `step` parameter is ignored because Neptune requires strictly increasing step values, a condition which is sometimes violated in Lighting e.g. when `fit()` and `test()` are called one after another on some models. `step` could be enabled again once Lightning guarantees that step values are always strictly increasing.
Also a minor bugfix: the `log_text()` method should use Neptune's `log_text()` method.
* Update neptune.py
* Update test_neptune.py
* Update test_all.py
* fix neptune tests
* add chlog
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
(cherry picked from commit 5d76b31881
2021-02-04 20:55:41 +01:00
b3b48c188c
fix error when logging to progress bar with reserved name ( #5620 )
...
* warn about duplicate metrics
* update changelog
* suggestions from rohit
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* multiple values in message
* Apply suggestions from code review
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-04 20:55:41 +01:00
2c9f606af9
Fix tensor printing in `trainer.test()` ( #5138 )
...
* Fix showing test results for tensors
* Fix docs
* Update pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
* Fix lint issues
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
2021-02-04 20:55:41 +01:00
6d67da2142
mergify: less updates ( #5639 )
...
* mergify: less updates
* Drop label
2021-02-04 20:55:41 +01:00
2758db6819
unify pep8 speaks ( #5607 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-04 20:55:41 +01:00
b95471d4a4
Increase TPU check timeout ( #5598 )
...
* change timeout to 100
* add to CHANGELOG.md
* update test
* updates
* reduce TPU_TIMEOUT_CONSTANT during test
* Update tests/utilities/test_xla_device_utils.py
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
* patch TPU_TIMEOUT_CONSTANT
* Apply suggestions from code review
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-04 20:55:41 +01:00
59361d595a
fix Neptune logger creating multiple experiments when gpus > 1 ( #3256 )
...
* DP device fix
* potential fix
* fix merge
* update tests
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-02-04 20:55:40 +01:00
62be060cb8
name typo ( #5612 )
2021-02-04 20:55:40 +01:00
70252f1284
update mergify ( #5608 )
...
* try fix update and review
* less spam
2021-02-04 20:55:40 +01:00
4d9c51d316
Update help steps ( #5564 )
...
* Update help steps
* Update README.md
Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
* Update README.md
* Update README.md
Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
2021-02-04 20:55:40 +01:00
ede1227c39
hotfix: drop bad pyyaml version ( #5606 )
...
* drop potetionaly bad version
* *
2021-02-04 20:55:40 +01:00
74d175bfac
fix PyPI releasing ( #5605 )
2021-02-04 20:55:40 +01:00
e8206a9295
Mnodes ( #5020 )
...
* add a multi-nodesworkflow
Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
2021-02-04 20:55:40 +01:00
3b43e5a4fc
Add note about returning None ( #5578 )
...
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2021-02-04 20:55:40 +01:00
5ff1306582
Add new CHANGELOG section ( #5580 )
2021-02-04 20:55:40 +01:00
e425bf3ba9
[BugOnFeat] Resolve bug with Finetuning ( #5744 )
...
* resolve bug + add doc
* Update pytorch_lightning/callbacks/finetuning.py
* resolve bug
* start adding more test
* add more tests for finetuning callback functions
* rename to flatten_modules
* resolve doc
* Update pytorch_lightning/callbacks/finetuning.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* resolve comments
* remove update on BoringModel
* update on comments
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-02-04 18:36:54 +00:00
d05cdf83f1
Merge remote-tracking branch 'carmocca/sync-1.1.5' into release/1.2-dev
2021-02-04 09:42:59 -05:00
26cc3b5357
Change the seq of on_train_batch_end, on_batch_end & on_train_epoch_end, on_epoch_end hooks ( #5688 )
2021-02-04 18:30:20 +05:30
9555043a29
Force ModelCheckpoint callback to run last ( #5731 )
2021-02-03 16:40:57 -05:00
630a88addb
drop deprecated docs ( #5768 )
...
* drop deprecated docs
* notes
* .
2021-02-03 20:21:19 +00:00
a37416843b
Fix sync
...
resolve wrong merge
tpu
yapf
2021-02-03 20:11:35 +01:00
09b8dc7738
Prepare 1.1.5 release ( #5576 )
...
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2021-02-03 19:41:47 +01:00
2b6738832b
fix argparse conflicting options error ( #5569 )
...
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-02-03 19:41:46 +01:00
1d99530c66
Fix root node resolution in slurm environment
...
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
Co-authored-by: chaton <thomas@grid.ai>
2021-02-03 19:41:46 +01:00
fd6b3ec349
Drop greetings comment ( #5563 )
...
Co-authored-by: chaton <thomas@grid.ai>
2021-02-03 19:41:46 +01:00
f72d93974c
Fix command line run for refinforce_learn_qnet in pl_examples ( #5414 )
...
* fix wrong argument in argparse
* remove wrong default arg in argparser
* disable add help argparse
2021-02-03 19:41:46 +01:00
b7920b1c84
Fix logging on_train_batch_end in a callback with multiple optimizers ( #5521 )
...
* Start with the failing test
* Then fix the failing test
* Update CHANGELOG
2021-02-03 19:41:46 +01:00
f2229fdd50
Fix val_check_interval with fast_dev_run ( #5540 )
...
* fix val_check_interval with fast_dev_run
* chlog
2021-02-03 19:41:45 +01:00
ad4e25fde5
[bugfix] Fix signature mismatch in DDPCPUHPCAccelerator's model_to_device ( #5505 )
...
* Update ddp_cpu_hpc_accelerator.py
* Update CHANGELOG.md
2021-02-03 19:41:45 +01:00
293984bbc0
fix reinit_schedulers with correct optimizer ( #5519 )
...
* update test
* syntax
* fix
* update test
* scheduler
* only apex
* fix
* rev drone
* chlog
2021-02-03 19:41:45 +01:00
a375240c0c
Tensorboard Docu about Hyperparams saving ( #5158 )
...
* Add documentation to tensorboard
* Remove unnecessary whitespaces
* Update pytorch_lightning/loggers/tensorboard.py
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* Add metrics to tensorboard logger
* Whitespace removed
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-02-03 19:41:45 +01:00
43e926b880
Fix Wrong exception message ( #5492 )
...
* Update accelerator_connector.py
* Apply suggestions from code review
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
2021-02-03 19:41:44 +01:00
f8abcf707c
reconfigure mergify ( #5499 )
...
* configure mergify
* drop gha
* drop commented section
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
2021-02-03 19:41:44 +01:00
7b42494d0e
Fix visual progress bar bug / properly reset progress bar ( #4579 )
...
* reset
* fix reset
* changelog
* update chlog
* typing
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
2021-02-03 19:41:44 +01:00
Jirka Borovec