Commit Graph

31423 Commits

Author SHA1 Message Date
Charlie Fenton 8bab12f8f8 client: save a copy of nvc_config.client_version_check_url in client_state.xml file, eliminating need for installer to rename previous nvc_config.xml to old_nvc_config.xml.
newer_version_startup_check() compares gstate.client_version_check_url to nvc_config.client_version_check_url. If different, it clears gstate.newer_version and updates gstate.client_version_check_url.
2018-07-26 02:09:48 -07:00
David Anderson e50cc3a6d9
Merge pull request #2598 from LocutusOfBorg/patch-1
Update screensaver_x11.cpp to new /var/lib/boinc working directory
2018-07-20 13:18:07 -07:00
David Anderson 0ecef40878
Merge pull request #2592 from BOINC/knr_translation_string_fix
web: Fix string that included a variable but needs to be translated s…
2018-07-20 12:17:17 -07:00
Kevin Reed 8446add652
Merge pull request #2607 from BOINC/fix_mac_sa_secure_script_comments
Mac: clarify comments in mac_sa_secure.sh script
2018-07-20 13:52:10 -05:00
Kevin Reed eee34216d4
Merge pull request #2603 from BOINC/caf_New_version_check_config
Add support for new nvc_config.xml file for branded installers
2018-07-20 13:51:09 -05:00
Kevin Reed f5590348ad (branding) Change network_test_url for WCG from http to https 2018-07-20 13:48:55 -05:00
Kevin Reed 77499f5326
Merge pull request #2608 from BOINC/dpa_win_install
update installshield files; update version #s; fix Win custom action build
2018-07-20 13:42:57 -05:00
Kevin Reed 76a055fba3
Merge pull request #2616 from AenBleidd/script_validator_fix_segfault
script_validator segfault fix
2018-07-20 13:42:04 -05:00
Vitalii Koshura e442d8add4
script_validator segfault fix
Fix script to verify that both init_script and compare_script parameters are defined

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
2018-07-20 16:12:28 +03:00
Vitalii Koshura aae36b1d69
script_validator segfault fix
Fix missed semicolon

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
2018-07-20 15:36:20 +03:00
Vitalii Koshura dd7c152bc6
script_validator segfault fix
Current script_validator implementation contains next statements:

sprintf(cmd, "../bin/%s", init_script[0].c_str());

and

sprintf(cmd, "../bin/%s", compare_script[0].c_str());

It is dangerous to use this arrays
that are filled by parsing command line
without validating whether they contain any elements
and leads to next behavior:

Program received signal SIGSEGV, Segmentation fault.
0x000000000040f838 in compare_results (r1=..., r2=..., match=match@entry=@0x7ffffffb6c17: false) at script_validator.cpp:154
154	script_validator.cpp: No such file or directory.
(gdb) bt
#0  0x000000000040f838 in compare_results (r1=..., r2=..., match=match@entry=@0x7ffffffb6c17: false) at script_validator.cpp:154
#1  0x000000000040e85d in check_set (results=std::vector of length 2, capacity 2 = {...}, wu=..., canonicalid=@0x7ffffffb6dd0: 0,
    retry=@0x7ffffffb6dcf: false) at validate_util2.cpp:134
#2  0x000000000040944e in handle_wu (validator=..., items=std::vector of length 3, capacity 4 = {...}) at validator.cpp:411
#3  0x000000000040a9f2 in do_validate_scan () at validator.cpp:730
#4  0x000000000040aae4 in main_loop () at validator.cpp:756
#5  0x00000000004039f6 in main (argc=5, argv=0x7fffffffdd48) at validator.cpp:929

This fix checks whether these arrays contain some elements
and output a readable error of missed inout parameter.

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
2018-07-20 15:21:10 +03:00
tristanolive ccde796026
Merge pull request #2609 from drshawnkwang/drupal_fix-bug-emailchange-time
Drupal: Fixed bug- in emails sent to user when email address changes
2018-07-19 09:28:06 -04:00
Charlie Fenton d2c659eb82 Fix build break on MS Windows 2018-07-19 00:47:38 -07:00
Charlie Fenton b1e629a5fb Move network_test_url tag from cc_config.xml into new nvc_config.xml file, since WCG modifies this for their branded builds (along with new version check info) and it is probably never modified for standard (unbranded) BOINC 2018-07-18 19:10:30 -07:00
Shawn Kwang 35ce74d93e Drupal: Fixed bug- When admin user changing email address, email sent to user contains correct time.
Part of https://dev.gridrepublic.org/browse/DBOINCP-436
2018-07-18 09:24:38 -05:00
David Anderson 1bffea8aaf update installshield files; update version #s; fix Win custom action build 2018-07-17 12:42:39 -07:00
Kevin Reed fd80d891d3
Merge pull request #2597 from BOINC/mac_reorganize_branding
Mac: Consolidate branding strings
2018-07-16 14:43:35 -05:00
Kevin Reed f489d7a404
Merge pull request #2606 from BOINC/dpa_delete_user2
web: code cleanup in delete user area
2018-07-16 14:10:50 -05:00
Kevin Reed 048a278340
Merge pull request #2602 from BOINC/dpa_autoattach3
web: ensure that login token is valid for 24 hours
2018-07-16 14:06:34 -05:00
tristanolive 28c167bdd2
Merge pull request #2601 from drshawnkwang/drupal_fix-recovery-email-path
Drupal: Add a 'menu redirect' to sent users to recover email menu path.
2018-07-16 14:26:35 -04:00
tristanolive 1aed37f4b1
Merge pull request #2599 from drshawnkwang/drupal_fix-bug-emailrecovery
Drupal: Fix bug in recovery email workflow.
2018-07-16 14:26:22 -04:00
Charlie Fenton 9cd1ff4ea4 Mac: update comments in Mac_SA_Insecure.sh script to clarify that it should be run in BOINC Data directory 2018-07-16 00:34:48 -07:00
Charlie Fenton 1fc1d7a587 Mac: update comments in mac_sa_secure.sh script to clarify that it should be run in BOINC Data directory 2018-07-16 00:26:16 -07:00
Charlie Fenton 0e7c376406 Silently skip tags client_version_check_url, client_download_url and client_new_version_text in cc_config.xml if an older client has written them there.
The Manager dialogs Event Log options and Exclusive Applications write the entire set of tags, so these tags typically contained the default values.
2018-07-15 18:53:25 -07:00
Charlie Fenton fc02420dd4 To allow customized new version message to be translatable, allow only the branded name of BOINC to be customized in the message.
Emphasize this difference by changing NVC_CONFIG struct member new_version_text to new_version_name.
Fix a bug I introduced in release_brand.sh script.
2018-07-15 03:24:59 -07:00
Charlie Fenton a03075c73c If version check URL has changed, reset any past new version information
This may happen due to installing a build of BOINC with different branding than before
2018-07-15 02:20:50 -07:00
David Anderson ae431f96d5 web: code cleanup in delete user area
- functions generally return zero on success
- improve function names
- comment formatting

See https://boinc.berkeley.edu/trac/wiki/CodingStyle

todo: fix translatable strings
2018-07-14 20:14:14 -07:00
Charlie Fenton 4f09c1979b Move client_version_check_url, client_download_url and client_new_version_text tags from cc_config.xml into new nvc_config.xml file.
If nvc_config.cml file is absent, use default values.
Branded installers can create or replace this file to customize these values.
Standard (unbranded) BOINC installers should either delete the file or create or replace it with one containing default values.
2018-07-14 04:59:06 -07:00
David Anderson c8aa75b5ef web: ensure that login token is valid for 24 hours 2018-07-13 19:35:20 -07:00
Shawn Kwang c7f61844fb Drupal: Add a 'menu redirect' to sent users to recover email menu path.
Part of https://dev.gridrepublic.org/browse/DBOINCP-436
2018-07-12 16:08:55 -05:00
Shawn Kwang 8cda423988 Drupal: Fix bug in recovery email workflow. 2018-07-12 12:40:51 -05:00
Charlie Fenton c60f22d96f Mac: Add new files for consolidated branding changes 2018-07-11 15:54:56 -07:00
Kevin Reed 80a2cae9b7
Merge pull request #2588 from marius311/vbox_hostinfo
add virtualization info to host info page
2018-07-11 17:04:41 -05:00
Juha Sointusalo 85357325df
Merge pull request #2590 from AenBleidd/auto_reconnect2
[Manager] Always reconnect remote client without user prompt
2018-07-11 20:52:24 +03:00
Juha Sointusalo 51bf79ad4f
Merge pull request #2596 from BOINC/mac_fix_about_dialog_branded_url
Manager: Fix branded link in About Dialog
2018-07-11 20:32:26 +03:00
marius 1238d7841d minor comment fix 2018-07-11 19:01:50 +02:00
marius 6e9d228237 support old-style virtualization info 2018-07-11 18:58:31 +02:00
Gianfranco Costamagna be149bc945
Update screensaver_x11.cpp to new /var/lib/boinc working directory
Thanks Gord Sipko for the report!
2018-07-11 14:23:50 +02:00
Charlie Fenton 7ea4a81865 Mac: Consolidate branding strings in one source file and one header file shared among all files which use them; add checks for missing branding strings. 2018-07-11 03:59:34 -07:00
Charlie Fenton 5d894ff197 Manager: in the About dialog "For more information, visit" hyperlink, set the value of the link to the same string as the text displayed for the link when using a branded skin. 2018-07-11 03:53:19 -07:00
David Anderson 601595b8aa
Merge pull request #2589 from AenBleidd/fix_2583_daily_schedules
[Manager] Fix time verification to allow '24:00' value in Preferences…
2018-07-10 22:57:27 -07:00
David Anderson 137b6563b8
Merge pull request #2593 from JuhaSointusalo/lib-fix-wide-char-conv
lib: fix wide char conversion functions
2018-07-10 14:13:58 -07:00
Juha Sointusalo afc165146d lib: fix wide char conversion functions
When MultiByteToWideChar and WideCharToMultiByte are told to process entire input strings the functions include null terminators in required buffer sizes. std::string on the other hand stores embedded null characters in the string it manages if it's requested to do so.

The way the code constructs std::string's from wide char function outputs makes null terminators part of the strings. This breaks concatenating strings together.

Fix the code by not copying the last character, i.e. the null terminator, to std::string.
2018-07-10 23:36:38 +03:00
Juha Sointusalo 5dac399bec
Merge pull request #2576 from armstrdj/mac_branded_installer_build_script
Generic Mac build script for branded version of Mac manager/screen saver
2018-07-10 19:43:48 +03:00
Charlie Fenton 9d036e7651 Fix branding in About dialog license statement 2018-07-09 15:47:00 -07:00
Kevin Reed 486a7d7d6f web: Fix string that included a variable but needs to be translated so that it uses a placeholder
instead of the variable in the string
2018-07-09 13:37:39 -05:00
Charlie Fenton b2a51d7821 Fix checks for optional -dev argument ($5 not $4), tweak comments and update copyright year. 2018-07-09 03:43:34 -07:00
Vitalii Koshura c5cf28a975
[Manager] Always reconnect remote client without user prompt
This fixes #2440 in the way discussed in  #2441

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
2018-07-07 23:52:57 +03:00
Charlie Fenton 8ff7f01a1f
[Manager] Fix time verification to allow '24:00' value in Preferences dialog
Time verification simplification.

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
2018-07-07 19:48:59 +03:00
marius 9f942cacff add virtualization info to host info page 2018-07-07 16:51:16 +02:00