Rooba
/
boinc
mirror of https://github.com/BOINC/boinc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

mgr: remove CDlgEventLogListCtrl::GetBackgroundColour() 

Since the method is overridden to be private it isn't callable from outside the class and the method isn't used inside the class either.

And overriding a base class method just to return a constant color isn't very useful when the same effect can be had by, e.g., calling SetBackgroundColour() in class' constructor.

On the other hand, trying to force the background color to white may conflict with the color scheme user has chosen and should not be done.

All in all, remove the code as not useful.

Part of #1083.
This commit is contained in:
Juha Sointusalo 2017-10-28 00:06:45 +03:00
parent 9585a50671
commit 61476afc04
2 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clientgui/DlgEventLogListCtrl.cpp
View File

@ -137,11 +137,6 @@ wxListItemAttr* CDlgEventLogListCtrl::OnGetItemAttr(long item) const {
}
wxColour CDlgEventLogListCtrl::GetBackgroundColour() {
return *wxWHITE;
}
void CDlgEventLogListCtrl::OnMouseUp(wxMouseEvent& event) {
m_pParentView->UpdateButtons();
event.Skip();

3
clientgui/DlgEventLogListCtrl.h
View File

@ -33,8 +33,6 @@ class CDlgEventLog;
class CDlgEventLogListCtrl : public DLG_LISTCTRL_BASE
{
using DLG_LISTCTRL_BASE::GetBackgroundColour;
DECLARE_DYNAMIC_CLASS(CDlgEventLogListCtrl)
DECLARE_EVENT_TABLE()
@ -54,7 +52,6 @@ private:
virtual wxString OnGetItemText(long item, long column) const;
virtual int OnGetItemImage(long item) const;
virtual wxListItemAttr* OnGetItemAttr(long item) const;
virtual wxColour GetBackgroundColour();
void OnMouseUp(wxMouseEvent& event);
void OnShow( wxShowEvent& event );